Instead of checking token is not T_INLINE_HTML, explicitly look for string tokens

rebeccahum · rebeccahum · commit 2e175b1636c8 · 2021-03-02T13:35:05.000-07:00
In the case that PHP adds another type of string token
diff --git a/WordPressVIPMinimum/Sniffs/Security/ProperEscapingFunctionSniff.php b/WordPressVIPMinimum/Sniffs/Security/ProperEscapingFunctionSniff.php
@@ -86,7 +86,7 @@ public function process_token( $stackPtr ) {
 
 		$content = $this->tokens[ $html ]['content'];
 
-		if ( $this->tokens[ $html ]['code'] !== 'T_INLINE_HTML' ) {
+		if ( isset( Tokens::$stringTokens[ $this->tokens[ $html ]['code'] ] ) === true ) {
 			$content = Sniff::strip_quotes( $content );
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -86,7 +86,7 @@ public function process_token( $stackPtr ) {`
`86`	`86`
`87`	`87`	`$content = $this->tokens[ $html ]['content'];`
`88`	`88`
`89`		`- if ( $this->tokens[ $html ]['code'] !== 'T_INLINE_HTML' ) {`
	`89`	`+ if ( isset( Tokens::$stringTokens[ $this->tokens[ $html ]['code'] ] ) === true ) {`
`90`	`90`	`$content = Sniff::strip_quotes( $content );`
`91`	`91`	`}`
`92`	`92`