Merge pull request #761 from Automattic/fix/regexcompare-remove-redundant-condition

GaryJones · web-flow · commit 3e73ba26ea7c · 2023-08-23T14:22:01.000+01:00
diff --git a/WordPressVIPMinimum/Sniffs/Performance/RegexpCompareSniff.php b/WordPressVIPMinimum/Sniffs/Performance/RegexpCompareSniff.php
@@ -47,7 +47,6 @@ public function getGroups() {
 	public function callback( $key, $val, $line, $group ) {
 		return ( strpos( $val, 'NOT REGEXP' ) === 0
 			|| strpos( $val, 'REGEXP' ) === 0
-			|| in_array( $val, [ 'REGEXP', 'NOT REGEXP' ], true ) === true
 		);
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,6 @@ public function getGroups() {`
`47`	`47`	`public function callback( $key, $val, $line, $group ) {`
`48`	`48`	`return ( strpos( $val, 'NOT REGEXP' ) === 0`
`49`	`49`	`\|\| strpos( $val, 'REGEXP' ) === 0`
`50`		`- \|\| in_array( $val, [ 'REGEXP', 'NOT REGEXP' ], true ) === true`
`51`	`50`	`);`
`52`	`51`	`}`
`53`	`52`	`}`