Fix minor memory leak in HDF5 utility functions

erictzeng · erictzeng · commit 551168861b44 · 2015-07-30T15:56:00.000-07:00
diff --git a/src/caffe/util/hdf5.cpp b/src/caffe/util/hdf5.cpp
@@ -72,6 +72,7 @@ void hdf5_save_nd_dataset<float>(
   herr_t status = H5LTmake_dataset_float(
       file_id, dataset_name.c_str(), num_axes, dims, data);
   CHECK_GE(status, 0) << "Failed to make float dataset " << dataset_name;
+  delete[] dims;
 }
 
 template <>
@@ -92,6 +93,7 @@ void hdf5_save_nd_dataset<double>(
   herr_t status = H5LTmake_dataset_double(
       file_id, dataset_name.c_str(), num_axes, dims, data);
   CHECK_GE(status, 0) << "Failed to make double dataset " << dataset_name;
+  delete[] dims;
 }
 
 string hdf5_load_string(hid_t loc_id, const string& dataset_name) {

Original file line number	Diff line number	Diff line change
`@@ -72,6 +72,7 @@ void hdf5_save_nd_dataset<float>(`
`72`	`72`	`herr_t status = H5LTmake_dataset_float(`
`73`	`73`	`file_id, dataset_name.c_str(), num_axes, dims, data);`
`74`	`74`	`CHECK_GE(status, 0) << "Failed to make float dataset " << dataset_name;`
	`75`	`+ delete[] dims;`
`75`	`76`	`}`
`76`	`77`
`77`	`78`	`template <>`
`@@ -92,6 +93,7 @@ void hdf5_save_nd_dataset<double>(`
`92`	`93`	`herr_t status = H5LTmake_dataset_double(`
`93`	`94`	`file_id, dataset_name.c_str(), num_axes, dims, data);`
`94`	`95`	`CHECK_GE(status, 0) << "Failed to make double dataset " << dataset_name;`
	`96`	`+ delete[] dims;`
`95`	`97`	`}`
`96`	`98`
`97`	`99`	`string hdf5_load_string(hid_t loc_id, const string& dataset_name) {`