Merge pull request #487 from tonyhallett/improve-logging

Improve logging

Author: tonyhallett

FineCodeCoverageTests/AppOptionsProvider_Tests.cs

@@ -4,6 +4,7 @@
 using AutoMoq;
 using FineCodeCoverage.Core.Utilities;
 using FineCodeCoverage.Options;
+using FineCodeCoverage.Output;
 using Microsoft.VisualStudio.Settings;
 using Moq;
 using NUnit.Framework;
@@ -199,6 +200,7 @@ public void Should_Not_Default_Any_Other_AppOptions_Properties()
                 nameof(IAppOptions.ThresholdForCrapScore),
                 nameof(IAppOptions.ThresholdForNPathComplexity),
                 nameof(IAppOptions.ThresholdForCyclomaticComplexity),
+                nameof(IAppOptions.RunMsCodeCoverage),
                 nameof(IAppOptions.NamespacedClasses),
                 nameof(IAppOptions.ShowCoverageInOverviewMargin),
                 nameof(IAppOptions.ShowCoveredInOverviewMargin),

FineCodeCoverageTests/CoverageProject_Settings_Tests.cs

@@ -2,6 +2,7 @@
 using FineCodeCoverage.Core.Utilities;
 using FineCodeCoverage.Engine.Model;
 using FineCodeCoverage.Options;
+using FineCodeCoverage.Output;
 using FineCodeCoverageTests.TestHelpers;
 using Moq;
 using NUnit.Framework;

FineCodeCoverageTests/CoverageToolOutput_Tests/CoverageToolOutputManager_Tests.cs

@@ -5,6 +5,7 @@
 using FineCodeCoverage.Core.Utilities;
 using FineCodeCoverage.Engine;
 using FineCodeCoverage.Engine.Model;
+using FineCodeCoverage.Output;
 using Moq;
 using NUnit.Framework;
 using SharedProject.Core.CoverageToolOutput;

FineCodeCoverageTests/CoverletConsole_Tests.cs

@@ -9,6 +9,7 @@
 using FineCodeCoverage.Engine.Coverlet;
 using FineCodeCoverage.Engine.Model;
 using FineCodeCoverage.Options;
+using FineCodeCoverage.Output;
 using Moq;
 using NUnit.Framework;
 

FineCodeCoverageTests/CoverletDataCollectorUtil_RunAsync_Tests.cs

@@ -10,6 +10,7 @@
 using FineCodeCoverage.Engine.Coverlet;
 using FineCodeCoverage.Engine.Model;
 using FineCodeCoverage.Options;
+using FineCodeCoverage.Output;
 using Moq;
 using NUnit.Framework;
 
@@ -279,7 +280,7 @@ public async Task Should_Use_The_ProcessResponseProcessor_Async()
             mockProcesUtil.Setup(p => p.ExecuteAsync(It.IsAny<ExecuteRequest>(), ct).Result).Returns(executeResponse);
             var mockProcessResponseProcessor = mocker.GetMock<IProcessResponseProcessor>();
 
-            var logTitle = "Coverlet Collector Run (TestProject)";
+            var logTitle = "Coverlet Collector Run (TestProject) - Output";
             mockProcessResponseProcessor.Setup(rp => rp.Process(executeResponse, It.IsAny<Func<int, bool>>(), true, logTitle, It.IsAny<Action>()));
 
             await coverletDataCollectorUtil.RunAsync(ct);

FineCodeCoverageTests/DotNetToolList_Tests.cs

@@ -2,6 +2,7 @@
 using AutoMoq;
 using FineCodeCoverage.Core.Utilities;
 using FineCodeCoverage.Engine.Coverlet;
+using FineCodeCoverage.Output;
 using NUnit.Framework;
 
 namespace FineCodeCoverageTests

FineCodeCoverageTests/Editor/DynamicCoverage/BufferLineCoverage_Tests.cs

@@ -6,6 +6,7 @@
 using FineCodeCoverage.Engine.Model;
 using FineCodeCoverage.Impl;
 using FineCodeCoverage.Options;
+using FineCodeCoverage.Output;
 using Microsoft.VisualStudio.Text;
 using Microsoft.VisualStudio.Text.Editor;
 using Moq;

FineCodeCoverageTests/Editor/DynamicCoverage/ContainingCodeTrackedLinesBuilder_Tests.cs

@@ -3,6 +3,7 @@
 using FineCodeCoverage.Editor.DynamicCoverage;
 using FineCodeCoverage.Editor.DynamicCoverage.TrackedLinesImpl.Construction;
 using FineCodeCoverage.Engine.Model;
+using FineCodeCoverage.Output;
 using FineCodeCoverageTests.TestHelpers;
 using Microsoft.VisualStudio.Text;
 using Moq;

FineCodeCoverageTests/FCCEngine_Tests.cs

@@ -11,6 +11,7 @@
 using FineCodeCoverage.Engine.Model;
 using FineCodeCoverage.Engine.MsTestPlatform;
 using FineCodeCoverage.Engine.ReportGenerator;
+using FineCodeCoverage.Impl;
 using FineCodeCoverage.Options;
 using FineCodeCoverage.Output;
 using Moq;
@@ -105,13 +106,6 @@ public void SetUp()
             mockAppOptionsProvider.Setup(x => x.Get()).Returns(mockedAppOptions.Object);
         }
 
-        [Test]
-        public async Task Should_Log_Starting_When_Initialized_Async()
-        {
-            await ReloadInitializedCoverage_Async();
-            VerifyLogsReloadCoverageStatus(ReloadCoverageStatus.Start);
-        }
-
         [Test]
         public async Task Should_Prepare_For_Coverage_Suitable_CoverageProjects_Async()
         {
@@ -319,7 +313,7 @@ public async Task Should_Cancel_Existing_ReloadCoverage_When_ReloadCoverage_Asyn
 
         private void VerifyLogsReloadCoverageStatus(ReloadCoverageStatus reloadCoverageStatus)
         {
-            mocker.Verify<ILogger>(l => l.Log(fccEngine.GetLogReloadCoverageStatusMessage(reloadCoverageStatus)));
+            mocker.Verify<ILogger>(l => l.Log(StatusMarkerProvider.Get(reloadCoverageStatus.ToString())));
         }
 
         private async Task StopCoverage_Async()

FineCodeCoverageTests/Initializer_Tests.cs

@@ -8,6 +8,7 @@
 using FineCodeCoverage.Core.Initialization;
 using FineCodeCoverage.Engine;
 using FineCodeCoverage.Engine.Model;
+using FineCodeCoverage.Output;
 using Moq;
 using NUnit.Framework;