Skip to content
This repository was archived by the owner on Aug 18, 2021. It is now read-only.

Commit d63a017

Browse files
authored
Merge pull request #5 from GSA/jrc_toolkit-proofing
Global updates to Toolkit docs
2 parents 2c5896c + 79170b2 commit d63a017

File tree

6 files changed

+14
-94
lines changed

6 files changed

+14
-94
lines changed

.DS_Store

6 KB
Binary file not shown.

.gitignore

Lines changed: 0 additions & 77 deletions
This file was deleted.

CODE_OF_CONDUCT.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,8 @@ Project maintainers who do not follow or enforce the Code of Conduct in good fai
4040

4141
## Attribution
4242

43-
This Code of Conduct is adapted from the [Contributor Covenant][homepage], version 1.4, available at https://www.contributor-covenant.org/version/1/4/code-of-conduct.html
43+
This Code of Conduct is adapted from the [Contributor Covenant][homepage], version 1.4, available at https://www.contributor-covenant.org/version/1/4/code-of-conduct.html.
4444

4545
[homepage]: https://www.contributor-covenant.org
4646

47-
For answers to common questions about this code of conduct, see https://www.contributor-covenant.org/faq
47+
For answers to common questions about this code of conduct, see https://www.contributor-covenant.org/faq.

README.md

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,14 @@
1-
# Open source playbook and toolkit
2-
### By [Code.gov](https://code.gov/) for federal agencies
3-
4-
 
1+
# Federal Source Code and Open Source Toolkit
2+
**By [Code.gov](https://code.gov/) for federal agencies**
53

64
## Description:
7-
This is a government-wide project facilitated by the [Code.gov](https://code.gov/) team to produce a playbook and toolkit pertaining to open sourcing software (OSS).
5+
This is a government-wide project facilitated by the [Code.gov](https://code.gov/) team to produce a toolkit pertaining to open source software (OSS).
86

9-
Excerpt from the initial Open Source Playbook & Tookit Working Group write-up.
7+
Excerpt from the initial Open Source Tookit Working Group write-up.
108

11-
> In the Code.gov open source inventory we are seeing an ongoing issue where agencies are publishing their open source code, but the projects are not set up in a way which makes the code reusable. In order to better align agency projects with the goals of the Federal Source Code Policy, the Code.gov team is launching an open source playbook and toolkit. We’re hoping to provide additional resources for open source maintainers to help support the growing community.
9+
> In the Code.gov open source inventory we are seeing an ongoing issue where agencies are publishing their open source code, but the projects are not set up in a way which makes the code reusable. In order to better align agency projects with the goals of the Federal Source Code Policy, the Code.gov team is launching this toolkit. We believe it offers additional resources for open source maintainers to help support a growing community.
1210
13-
> The goal is to provide info, examples and resources on what really well managed open source projects look like and to give additional federal guidance for developers to follow when publishing projects.
11+
> The goal is to provide info, examples, and resources on what really well managed open source projects look like and to give additional federal guidance for developers to follow when publishing projects.
1412
1513
Additional content urging us to begin this effort can be found in the [background docs](background_docs) section including the [Harvard Engagement Report](background_docs/HarvardEngagementReport.pdf), a recent [UX study](background_docs/Always%20Improving_Making%20the%20Contribution%20to%20Repos%20Better.pdf) we conducted and blogged about, and [Q&A](background_docs/Open%20Source%20Playbook%20Q%26A%20-%2024%20June%202019.pdf) from the first meeting with agencies before official kick-off.
1614

automation.md

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ Don’t make standards too complicated or that they increase barriers to contrib
99

1010
**Maintenance work**
1111
* [Semantic-release](https://github.com/semantic-release/semantic-release) automates releases
12-
* [mention-bo](https://github.com/facebook/mention-bot)t mentions potential reviewers for pull requests
12+
* [mention-bot](https://github.com/facebook/mention-bot) mentions potential reviewers for pull requests
1313
* [Danger](https://github.com/danger/danger) helps automate code review
1414
* [Issue templates and pull request templates](https://github.com/blog/2111-issue-and-pull-request-templates)
1515
* Style guides
@@ -21,6 +21,4 @@ Don’t make standards too complicated or that they increase barriers to contrib
2121
* GitHub’s [Tools for Open Source](https://github.com/collections/tools-for-open-source) – software to make running an open source project a little easier
2222
* GitHub’s [issue templates and pull request templates](https://github.com/blog/2111-issue-and-pull-request-templates)
2323
* [Semantic-release](https://github.com/semantic-release/semantic-release) automates releases
24-
* [mention-bot](https://github.com/facebook/mention-bot) mentions potential reviewers for pull requests
25-
* [Danger](https://github.com/danger/danger) helps automate code review
2624
* [Kubernetes Development Automation](https://github.com/kubernetes/community/blob/master/contributors/devel/automation.md) documentation

community_building.md

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,23 @@
11
# Community building and maintenance
22

33
**Places to Congregate**
4-
It’s important to give your community a place to congregate to help them get to know each other. When communication is public and accessible, anyone can read past archives and get up to speed and participate.
4+
It’s important to give your community a place to congregate to help them get to know each other and to contribute to code repositories. When communication is public and accessible, everyone can read past archives and get up to speed and participate.
55

6-
Secondly, as a maintainer, if you don’t give people a public place to talk about your project, they will likely contact you directly. Public communication can be as simple as directing people to open an issue instead of emailing you directly or commenting on your blog.
6+
As a maintainer, you want to provide a public place for the community to discuss issues with code and submit pull requests (PRs) for review and inclusion in the current code base.
77

88
Ideas for building community:
99

10+
* GitHub repository or similar public code sharing platform
1011
* Live chat (e.g., Slack channels, IRC, or Gitter)
1112
* Forum/thread-based communities (e.g., Discourse)
1213
* In-person meetups, conferences or events
13-
* GitHub issues or listserv
14+
* Community listserv
1415
* Office Hours
1516
* Social Media
1617

1718
Notable exceptions to public communication are: 1) security issues and 2) sensitive code of conduct violations. People should be able to report these issues privately.
1819

19-
# Code Review
20+
## Code Review
2021

2122
* All code in any code-base should look like a single person typed it, no matter how many people contributed. Principles of writing idiomatic JavaScript (WP-CLI)
2223
* Code review should probably always be your top priority, and you should figure out the best way to work it into your event loop (pending code review requests represent blocked threads of execution)

0 commit comments

Comments
 (0)