secretmanager: ephemeral support for `google_secret_manager_secret_version` #14700

ramonvermeulen · 2025-07-31T15:10:53Z

Closes hashicorp/terraform-provider-google#20516

For reference:

Hashicorp docs on ephemeral resources:
https://developer.hashicorp.com/terraform/plugin/framework/ephemeral-resources

Implementation of the original couple of ephemeral resources:
#12469

Release Note Template for Downstream PRs (will be copied)

secretmanager: ephemeral support for `google_secret_manager_secret_version`

ramonvermeulen · 2025-07-31T19:11:22Z

@BBBmau Tagging for visibility since you implemented all the other ephemeral resources.

Tests:

➜ make testacc TEST=./google/services/secretmanager TESTARGS='-run=TestAccEphemeralSecretManagerSecretVersion_'

TF_ACC=1 TF_SCHEMA_PANIC_ON_ERROR=1 go test ./google/services/secretmanager -v -run=TestAccEphemeralSecretManagerSecretVersion_ -timeout 240m -ldflags="-X=github.com/hashicorp/terraform-provider-google/version.ProviderVersion=acc"
=== RUN   TestAccEphemeralSecretManagerSecretVersion_basic
=== PAUSE TestAccEphemeralSecretManagerSecretVersion_basic
=== CONT  TestAccEphemeralSecretManagerSecretVersion_basic
--- PASS: TestAccEphemeralSecretManagerSecretVersion_basic (12.48s)
PASS
ok      github.com/hashicorp/terraform-provider-google/google/services/secretmanager    13.188s

Couldn't really find a lot of testing utilities around ephemeral resources, so decided to also do some manual testing.

For manual testing I used the following config:

locals {
  project_id = "my-project-id"
}

provider "google" {
  project = local.project_id
}

resource "google_secret_manager_secret" "secret" {
  secret_id = "test-ephemeral-secret"

  replication {
    auto {}
  }
}

resource "google_secret_manager_secret_version" "version" {
  secret      = google_secret_manager_secret.secret.id
  secret_data = "foo"
}

ephemeral "google_secret_manager_secret_version" "ephemeral" {
  secret  = google_secret_manager_secret_version.version.secret
  version = google_secret_manager_secret_version.version.version
}

resource "google_secret_manager_secret_version" "version_two_based_on_ephemeral" {
  # This resource is used to test that the ephemeral secret can be used in a resource that uses it's value
  secret                 = google_secret_manager_secret.secret.id
  secret_data_wo         = ephemeral.google_secret_manager_secret_version.ephemeral.secret_data
  secret_data_wo_version = "1"
}

And I can make the second secret version based upon the ephemeral output of the first secret version.

Logs:

google_secret_manager_secret.secret: Creating...
google_secret_manager_secret.secret: Creation complete after 1s [id=projects/my-project-id/secrets/test-ephemeral-secret]
google_secret_manager_secret_version.version: Creating...
google_secret_manager_secret_version.version: Creation complete after 3s [id=projects/XXXXXXXXXXX/secrets/test-ephemeral-secret/versions/1]
ephemeral.google_secret_manager_secret_version.ephemeral: Opening...
ephemeral.google_secret_manager_secret_version.ephemeral: Opening complete after 3s
google_secret_manager_secret_version.version_two_based_on_ephemeral: Creating...
google_secret_manager_secret_version.version_two_based_on_ephemeral: Creation complete after 3s [id=projects/XXXXXXXXXXX/secrets/test-ephemeral-secret/versions/2]
ephemeral.google_secret_manager_secret_version.ephemeral: Closing...
ephemeral.google_secret_manager_secret_version.ephemeral: Closing complete after 0s

Apply complete! Resources: 3 added, 0 changed, 0 destroyed.

EDIT:

Made some changes to the testing set-up in 77dcd03, so ran tests again:

❯ make testacc TEST=./google/services/secretmanager TESTARGS='-run=TestAccEphemeralSecretManagerSecretVersion_'

TF_ACC=1 TF_SCHEMA_PANIC_ON_ERROR=1 go test ./google/services/secretmanager -v -run=TestAccEphemeralSecretManagerSecretVersion_ -timeout 240m -ldflags="-X=github.com/hashicorp/terraform-provider-google/version.ProviderVersion=acc"
=== RUN   TestAccEphemeralSecretManagerSecretVersion_basic
=== PAUSE TestAccEphemeralSecretManagerSecretVersion_basic
=== RUN   TestAccEphemeralSecretManagerSecretVersion_base64
=== PAUSE TestAccEphemeralSecretManagerSecretVersion_base64
=== CONT  TestAccEphemeralSecretManagerSecretVersion_basic
=== CONT  TestAccEphemeralSecretManagerSecretVersion_base64
--- PASS: TestAccEphemeralSecretManagerSecretVersion_base64 (21.17s)
--- PASS: TestAccEphemeralSecretManagerSecretVersion_basic (22.79s)
PASS
ok      github.com/hashicorp/terraform-provider-google/google/services/secretmanager    23.527s

github-actions · 2025-07-31T19:12:25Z

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@SirGitsalot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

SirGitsalot · 2025-07-31T23:10:57Z

Reassigning to a reviewer knowledgable with ephemeral resources

github-actions · 2025-08-05T09:46:55Z

@SirGitsalot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions · 2025-08-07T09:45:59Z

@GoogleCloudPlatform/terraform-team @SirGitsalot This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions · 2025-08-14T09:44:47Z

@GoogleCloudPlatform/terraform-team @SirGitsalot This PR has been waiting for review for 2 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

ramonvermeulen · 2025-08-14T18:45:45Z

Hi @BBBmau

Do you maybe have time somewhere within the next weeks to take a look at this PR as well? I know the original issue has quite a high demand so just tagging as a friendly reminder.

modular-magician · 2025-08-18T16:43:20Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 424 insertions(+))
google-beta provider: Diff ( 4 files changed, 424 insertions(+))

modular-magician · 2025-08-18T18:44:47Z

Tests analytics

Total tests: 5059
Passed tests: 4462
Skipped tests: 591
Affected tests: 6

Click here to see the affected service packages

All service packages are affected

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccAccessContextManager__service_perimeter_dry_run_egress_policy

TestAccDataFusionInstance_dataFusionInstanceCmekExample

TestAccDialogflowEncryptionSpec_dialogflowEncryptionSpecBasicExample

TestAccEphemeralSecretManagerSecretVersion_base64

TestAccEphemeralSecretManagerSecretVersion_basic

TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample

Get to know how VCR tests work

modular-magician · 2025-08-18T19:18:59Z

🟢 Tests passed during RECORDING mode:
TestAccAccessContextManager__access_level [Debug log]
TestAccAccessContextManager__access_level_condition [Debug log]
TestAccAccessContextManager__access_level_custom [Debug log]
TestAccAccessContextManager__access_level_full [Debug log]
TestAccAccessContextManager__access_levels [Debug log]
TestAccAccessContextManager__access_policy [Debug log]
TestAccAccessContextManager__access_policy_scoped [Debug log]
TestAccAccessContextManager__authorized_orgs_desc [Debug log]
TestAccAccessContextManager__gcp_user_access_binding [Debug log]
TestAccAccessContextManager__service_perimeter [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_egress_policy [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_ingress_policy [Debug log]
TestAccAccessContextManager__service_perimeter_update [Debug log]
TestAccAccessContextManager__service_perimeters [Debug log]
TestAccDataFusionInstance_dataFusionInstanceCmekExample [Debug log]
TestAccEphemeralSecretManagerSecretVersion_base64 [Debug log]
TestAccEphemeralSecretManagerSecretVersion_basic [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataFusionInstance_dataFusionInstanceCmekExample [Error message] [Debug log]
TestAccEphemeralSecretManagerSecretVersion_base64 [Error message] [Debug log]
TestAccEphemeralSecretManagerSecretVersion_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccDialogflowEncryptionSpec_dialogflowEncryptionSpecBasicExample [Error message] [Debug log]
TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

ramonvermeulen · 2025-08-19T08:11:20Z

🟢 Tests passed during RECORDING mode: TestAccAccessContextManager__access_level [Debug log] TestAccAccessContextManager__access_level_condition [Debug log] TestAccAccessContextManager__access_level_custom [Debug log] TestAccAccessContextManager__access_level_full [Debug log] TestAccAccessContextManager__access_levels [Debug log] TestAccAccessContextManager__access_policy [Debug log] TestAccAccessContextManager__access_policy_scoped [Debug log] TestAccAccessContextManager__authorized_orgs_desc [Debug log] TestAccAccessContextManager__gcp_user_access_binding [Debug log] TestAccAccessContextManager__service_perimeter [Debug log] TestAccAccessContextManager__service_perimeter_dry_run_egress_policy [Debug log] TestAccAccessContextManager__service_perimeter_dry_run_ingress_policy [Debug log] TestAccAccessContextManager__service_perimeter_update [Debug log] TestAccAccessContextManager__service_perimeters [Debug log] TestAccDataFusionInstance_dataFusionInstanceCmekExample [Debug log] TestAccEphemeralSecretManagerSecretVersion_base64 [Debug log] TestAccEphemeralSecretManagerSecretVersion_basic [Debug log]

🔴 Tests failed when rerunning REPLAYING mode: TestAccDataFusionInstance_dataFusionInstanceCmekExample [Error message] [Debug log] TestAccEphemeralSecretManagerSecretVersion_base64 [Error message] [Debug log] TestAccEphemeralSecretManagerSecretVersion_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode: TestAccDialogflowEncryptionSpec_dialogflowEncryptionSpecBasicExample [Error message] [Debug log] TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Just ran the tests locally one more time because I saw the failures in VCR:

➜ make testacc TEST=./google/services/secretmanager TESTARGS='-run=TestAccEphemeralSecretManagerSecretVersion_'
TF_ACC=1 TF_SCHEMA_PANIC_ON_ERROR=1 go test ./google/services/secretmanager -v -run=TestAccEphemeralSecretManagerSecretVersion_ -timeout 240m -ldflags="-X=github.com/hashicorp/terraform-provider-google/version.ProviderVersion=acc"
=== RUN   TestAccEphemeralSecretManagerSecretVersion_basic
=== PAUSE TestAccEphemeralSecretManagerSecretVersion_basic
=== RUN   TestAccEphemeralSecretManagerSecretVersion_base64
=== PAUSE TestAccEphemeralSecretManagerSecretVersion_base64
=== CONT  TestAccEphemeralSecretManagerSecretVersion_basic
=== CONT  TestAccEphemeralSecretManagerSecretVersion_base64
--- PASS: TestAccEphemeralSecretManagerSecretVersion_basic (15.55s)
--- PASS: TestAccEphemeralSecretManagerSecretVersion_base64 (15.55s)
PASS
ok      github.com/hashicorp/terraform-provider-google/google/services/secretmanager    16.326s

Weirdly I don't run into any issues locally, could you share the VCR logs?

BBBmau · 2025-08-19T14:54:10Z

/gcbrun

BBBmau · 2025-08-20T15:54:37Z

🟢 Tests passed during RECORDING mode: TestAccAccessContextManager__access_level [Debug log] TestAccAccessContextManager__access_level_condition [Debug log] TestAccAccessContextManager__access_level_custom [Debug log] TestAccAccessContextManager__access_level_full [Debug log] TestAccAccessContextManager__access_levels [Debug log] TestAccAccessContextManager__access_policy [Debug log] TestAccAccessContextManager__access_policy_scoped [Debug log] TestAccAccessContextManager__authorized_orgs_desc [Debug log] TestAccAccessContextManager__gcp_user_access_binding [Debug log] TestAccAccessContextManager__service_perimeter [Debug log] TestAccAccessContextManager__service_perimeter_dry_run_egress_policy [Debug log] TestAccAccessContextManager__service_perimeter_dry_run_ingress_policy [Debug log] TestAccAccessContextManager__service_perimeter_update [Debug log] TestAccAccessContextManager__service_perimeters [Debug log] TestAccDataFusionInstance_dataFusionInstanceCmekExample [Debug log] TestAccEphemeralSecretManagerSecretVersion_base64 [Debug log] TestAccEphemeralSecretManagerSecretVersion_basic [Debug log]
🔴 Tests failed when rerunning REPLAYING mode: TestAccDataFusionInstance_dataFusionInstanceCmekExample [Error message] [Debug log] TestAccEphemeralSecretManagerSecretVersion_base64 [Error message] [Debug log] TestAccEphemeralSecretManagerSecretVersion_basic [Error message] [Debug log]
Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.
Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.
🔴 Tests failed during RECORDING mode: TestAccDialogflowEncryptionSpec_dialogflowEncryptionSpecBasicExample [Error message] [Debug log] TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample [Error message] [Debug log]
🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.
View the build log or the debug log for each test

Just ran the tests locally one more time because I saw the failures in VCR:
➜ make testacc TEST=./google/services/secretmanager TESTARGS='-run=TestAccEphemeralSecretManagerSecretVersion_'
TF_ACC=1 TF_SCHEMA_PANIC_ON_ERROR=1 go test ./google/services/secretmanager -v -run=TestAccEphemeralSecretManagerSecretVersion_ -timeout 240m -ldflags="-X=github.com/hashicorp/terraform-provider-google/version.ProviderVersion=acc"
=== RUN   TestAccEphemeralSecretManagerSecretVersion_basic
=== PAUSE TestAccEphemeralSecretManagerSecretVersion_basic
=== RUN   TestAccEphemeralSecretManagerSecretVersion_base64
=== PAUSE TestAccEphemeralSecretManagerSecretVersion_base64
=== CONT  TestAccEphemeralSecretManagerSecretVersion_basic
=== CONT  TestAccEphemeralSecretManagerSecretVersion_base64
--- PASS: TestAccEphemeralSecretManagerSecretVersion_basic (15.55s)
--- PASS: TestAccEphemeralSecretManagerSecretVersion_base64 (15.55s)
PASS
ok      github.com/hashicorp/terraform-provider-google/google/services/secretmanager    16.326s
Weirdly I don't run into any issues locally, could you share the VCR logs?

=== RUN   TestAccEphemeralSecretManagerSecretVersion_base64
=== PAUSE TestAccEphemeralSecretManagerSecretVersion_base64
=== CONT  TestAccEphemeralSecretManagerSecretVersion_base64
    test_utils.go:126: no cassette found on disk for TestAccEphemeralSecretManagerSecretVersion_base64, please replay this testcase in recording mode - open /workspace/.ci/magician/cassettes/beta/TestAccEphemeralSecretManagerSecretVersion_base64.seed: no such file or directory
--- FAIL: TestAccEphemeralSecretManagerSecretVersion_base64 (0.00s)

is this something that we can look into? @melinath

modular-magician · 2025-08-20T16:01:39Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 424 insertions(+))
google-beta provider: Diff ( 4 files changed, 424 insertions(+))

modular-magician · 2025-08-20T18:04:03Z

Tests analytics

Total tests: 5072
Passed tests: 4469
Skipped tests: 594
Affected tests: 9

Click here to see the affected service packages

All service packages are affected

Action taken

Found 9 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccAccessContextManager__service_perimeter_dry_run_egress_policy

TestAccBillingSubaccount_basic

TestAccBillingSubaccount_renameOnDestroy

TestAccComputeRegionBackendService_regionBackendServiceHaPolicyManualLeader_update

TestAccDataFusionInstance_dataFusionInstanceCmekExample

TestAccDialogflowEncryptionSpec_dialogflowEncryptionSpecBasicExample

TestAccEphemeralSecretManagerSecretVersion_base64

TestAccEphemeralSecretManagerSecretVersion_basic

TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample

Get to know how VCR tests work

modular-magician · 2025-08-20T18:40:29Z

🟢 Tests passed during RECORDING mode:
TestAccAccessContextManager__access_level [Debug log]
TestAccAccessContextManager__access_level_condition [Debug log]
TestAccAccessContextManager__access_level_custom [Debug log]
TestAccAccessContextManager__access_level_full [Debug log]
TestAccAccessContextManager__access_levels [Debug log]
TestAccAccessContextManager__access_policy [Debug log]
TestAccAccessContextManager__access_policy_scoped [Debug log]
TestAccAccessContextManager__authorized_orgs_desc [Debug log]
TestAccAccessContextManager__gcp_user_access_binding [Debug log]
TestAccAccessContextManager__service_perimeter [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_egress_policy [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_ingress_policy [Debug log]
TestAccAccessContextManager__service_perimeter_update [Debug log]
TestAccAccessContextManager__service_perimeters [Debug log]
TestAccBillingSubaccount_basic [Debug log]
TestAccBillingSubaccount_renameOnDestroy [Debug log]
TestAccComputeRegionBackendService_regionBackendServiceHaPolicyManualLeader_update [Debug log]
TestAccDataFusionInstance_dataFusionInstanceCmekExample [Debug log]
TestAccDialogflowEncryptionSpec_dialogflowEncryptionSpecBasicExample [Debug log]
TestAccEphemeralSecretManagerSecretVersion_base64 [Debug log]
TestAccEphemeralSecretManagerSecretVersion_basic [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccAccessContextManager__service_perimeter_dry_run_egress_policy [Error message] [Debug log]
TestAccComputeRegionBackendService_regionBackendServiceHaPolicyManualLeader_update [Error message] [Debug log]
TestAccDataFusionInstance_dataFusionInstanceCmekExample [Error message] [Debug log]
TestAccEphemeralSecretManagerSecretVersion_base64 [Error message] [Debug log]
TestAccEphemeralSecretManagerSecretVersion_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

github-actions · 2025-08-21T09:43:43Z

@GoogleCloudPlatform/terraform-team @SirGitsalot This PR has been waiting for review for 3 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

ramonvermeulen · 2025-08-26T15:32:54Z

Small update on this, just rebased and reran tests:

➜ make testacc TEST=./google/services/secretmanager TESTARGS='-run=TestAccEphemeralSecretManagerSecretVersion_'
TF_ACC=1 TF_SCHEMA_PANIC_ON_ERROR=1 go test ./google/services/secretmanager -v -run=TestAccEphemeralSecretManagerSecretVersion_ -timeout 240m -ldflags="-X=github.com/hashicorp/terraform-provider-google/version.ProviderVersion=acc"
=== RUN   TestAccEphemeralSecretManagerSecretVersion_basic
=== PAUSE TestAccEphemeralSecretManagerSecretVersion_basic
=== RUN   TestAccEphemeralSecretManagerSecretVersion_base64
=== PAUSE TestAccEphemeralSecretManagerSecretVersion_base64
=== CONT  TestAccEphemeralSecretManagerSecretVersion_basic
=== CONT  TestAccEphemeralSecretManagerSecretVersion_base64
--- PASS: TestAccEphemeralSecretManagerSecretVersion_base64 (15.58s)
--- PASS: TestAccEphemeralSecretManagerSecretVersion_basic (19.10s)
PASS
ok      github.com/hashicorp/terraform-provider-google/google/services/secretmanager    19.901s

modular-magician · 2025-08-26T19:45:09Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 424 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 4 files changed, 425 insertions(+), 2 deletions(-))

modular-magician · 2025-08-26T21:59:16Z

Tests analytics

Total tests: 5495
Passed tests: 4860
Skipped tests: 595
Affected tests: 40

Click here to see the affected service packages

All service packages are affected

Action taken

Found 40 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccAccessContextManager__service_perimeter_dry_run_egress_policy

TestAccComputeRegionBackendService_regionBackendServiceHaPolicyManualLeader_update

TestAccContainerCluster_withMasterAuthorizedNetworksConfig

TestAccContainerCluster_withNodeConfigKubeletConfigSettingsInNodePool

TestAccContainerNodePool_EmptyGuestAccelerator

TestAccContainerNodePool_autoscaling

TestAccContainerNodePool_fastSocket

TestAccContainerNodePool_gcfsConfig

TestAccContainerNodePool_gvnic

TestAccContainerNodePool_privateRegistry

TestAccContainerNodePool_regionalAutoscaling

TestAccContainerNodePool_resize

TestAccContainerNodePool_resourceManagerTags

TestAccContainerNodePool_totalSize

TestAccContainerNodePool_version

TestAccContainerNodePool_withCgroupMode

TestAccContainerNodePool_withConfidentialNodes

TestAccContainerNodePool_withEnablePrivateNodesToggle

TestAccContainerNodePool_withHugepageConfig

TestAccContainerNodePool_withKubeletConfig

TestAccContainerNodePool_withLegacyNodeConfigAndBootDiskUpdate

TestAccContainerNodePool_withLinuxNodeConfig

TestAccContainerNodePool_withLoggingVariantUpdates

TestAccContainerNodePool_withMachineAndDiskUpdate

TestAccContainerNodePool_withManagement

TestAccContainerNodePool_withMaxRunDuration

TestAccContainerNodePool_withNodeConfig

TestAccContainerNodePool_withNodeConfigWithBootDiskConfig

TestAccContainerNodePool_withNodeConfigWithBootDiskConfigChangeType

TestAccContainerNodePool_withNodeConfigWithBootDiskConfigChangeTypeLegacy

TestAccContainerNodePool_withTaintsUpdate

TestAccContainerNodePool_withUpgradeSettings

TestAccContainerNodePool_withWindowsNodeConfig

TestAccContainerNodePool_withWorkloadIdentityConfig

TestAccDataFusionInstance_dataFusionInstanceCmekExample

TestAccEphemeralSecretManagerSecretVersion_base64

TestAccEphemeralSecretManagerSecretVersion_basic

TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample

TestAccLoggingFolderSettings_update

TestAccResourceFWPubsubLiteReservation_basic

Get to know how VCR tests work

modular-magician · 2025-08-27T00:10:50Z

🟢 Tests passed during RECORDING mode:
TestAccAccessContextManager__access_level [Debug log]
TestAccAccessContextManager__access_level_condition [Debug log]
TestAccAccessContextManager__access_level_custom [Debug log]
TestAccAccessContextManager__access_level_full [Debug log]
TestAccAccessContextManager__access_levels [Debug log]
TestAccAccessContextManager__access_policy [Debug log]
TestAccAccessContextManager__access_policy_scoped [Debug log]
TestAccAccessContextManager__authorized_orgs_desc [Debug log]
TestAccAccessContextManager__gcp_user_access_binding [Debug log]
TestAccAccessContextManager__service_perimeter [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_egress_policy [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_ingress_policy [Debug log]
TestAccAccessContextManager__service_perimeter_update [Debug log]
TestAccAccessContextManager__service_perimeters [Debug log]
TestAccComputeRegionBackendService_regionBackendServiceHaPolicyManualLeader_update [Debug log]
TestAccContainerCluster_withMasterAuthorizedNetworksConfig [Debug log]
TestAccContainerNodePool_EmptyGuestAccelerator [Debug log]
TestAccContainerNodePool_autoscaling [Debug log]
TestAccContainerNodePool_fastSocket [Debug log]
TestAccContainerNodePool_gcfsConfig [Debug log]
TestAccContainerNodePool_gvnic [Debug log]
TestAccContainerNodePool_privateRegistry [Debug log]
TestAccContainerNodePool_regionalAutoscaling [Debug log]
TestAccContainerNodePool_resize [Debug log]
TestAccContainerNodePool_totalSize [Debug log]
TestAccContainerNodePool_version [Debug log]
TestAccContainerNodePool_withCgroupMode [Debug log]
TestAccContainerNodePool_withConfidentialNodes [Debug log]
TestAccContainerNodePool_withEnablePrivateNodesToggle [Debug log]
TestAccContainerNodePool_withHugepageConfig [Debug log]
TestAccContainerNodePool_withKubeletConfig [Debug log]
TestAccContainerNodePool_withLegacyNodeConfigAndBootDiskUpdate [Debug log]
TestAccContainerNodePool_withLinuxNodeConfig [Debug log]
TestAccContainerNodePool_withLoggingVariantUpdates [Debug log]
TestAccContainerNodePool_withMachineAndDiskUpdate [Debug log]
TestAccContainerNodePool_withManagement [Debug log]
TestAccContainerNodePool_withMaxRunDuration [Debug log]
TestAccContainerNodePool_withNodeConfig [Debug log]
TestAccContainerNodePool_withNodeConfigWithBootDiskConfig [Debug log]
TestAccContainerNodePool_withNodeConfigWithBootDiskConfigChangeType [Debug log]
TestAccContainerNodePool_withNodeConfigWithBootDiskConfigChangeTypeLegacy [Debug log]
TestAccContainerNodePool_withTaintsUpdate [Debug log]
TestAccContainerNodePool_withUpgradeSettings [Debug log]
TestAccContainerNodePool_withWindowsNodeConfig [Debug log]
TestAccContainerNodePool_withWorkloadIdentityConfig [Debug log]
TestAccDataFusionInstance_dataFusionInstanceCmekExample [Debug log]
TestAccEphemeralSecretManagerSecretVersion_base64 [Debug log]
TestAccEphemeralSecretManagerSecretVersion_basic [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccComputeRegionBackendService_regionBackendServiceHaPolicyManualLeader_update [Error message] [Debug log]
TestAccDataFusionInstance_dataFusionInstanceCmekExample [Error message] [Debug log]
TestAccEphemeralSecretManagerSecretVersion_base64 [Error message] [Debug log]
TestAccEphemeralSecretManagerSecretVersion_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccContainerCluster_withNodeConfigKubeletConfigSettingsInNodePool [Error message] [Debug log]
TestAccContainerNodePool_resourceManagerTags [Error message] [Debug log]
TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample [Error message] [Debug log]
TestAccLoggingFolderSettings_update [Error message] [Debug log]

🔴 Several tests terminated during RECORDING mode.

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

github-actions · 2025-08-28T09:43:04Z

@GoogleCloudPlatform/terraform-team @SirGitsalot This PR has been waiting for review for 4 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

…ger_secret_version`

github-actions · 2025-09-04T09:42:59Z

@GoogleCloudPlatform/terraform-team @SirGitsalot This PR has been waiting for review for 5 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

bschaatsbergen · 2025-09-07T06:17:32Z

Hey @BBBmau, would it be possible to get this reviewed? This resource is quite important to the community since it completes the ephemeral lifecycle for secrets in GCP. Is there anything @ramonvermeulen or I can do to help move this forward? Thanks!

mvanholsteijn · 2025-09-07T17:47:40Z

Hey @BBBmau, would it be possible to get this reviewed? This resource is quite important to the community since it completes the ephemeral lifecycle for secrets in GCP. Is there anything @ramonvermeulen or I can do to help move this forward? Thanks!

I would be pretty happy to help too!

modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jul 31, 2025

ramonvermeulen marked this pull request as ready for review July 31, 2025 19:11

github-actions bot requested a review from SirGitsalot July 31, 2025 19:12

SirGitsalot requested review from BBBmau and removed request for SirGitsalot July 31, 2025 23:10

ramonvermeulen force-pushed the ramon/20516-ephemeral-support-secret-manager-secret-version branch from 8d381ad to 65fe64f Compare August 11, 2025 17:23

modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Aug 18, 2025

mvanholsteijn mentioned this pull request Aug 18, 2025

feat: support ephemeral private keys for self signed certificates hashicorp/terraform-provider-tls#689

Open

1 task

ramonvermeulen force-pushed the ramon/20516-ephemeral-support-secret-manager-secret-version branch from 65fe64f to e1d5f11 Compare August 19, 2025 08:11

modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Aug 19, 2025

modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Aug 20, 2025

ramonvermeulen force-pushed the ramon/20516-ephemeral-support-secret-manager-secret-version branch from e1d5f11 to 6dc03eb Compare August 26, 2025 15:21

modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Aug 26, 2025

modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Aug 26, 2025

ramonvermeulen force-pushed the ramon/20516-ephemeral-support-secret-manager-secret-version branch from 6dc03eb to 1f240c7 Compare September 2, 2025 08:17

modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Sep 2, 2025

ramonvermeulen added 9 commits September 4, 2025 08:31

feat(secretmanager): WIP on Ephemeral support for `google_secret_mana…

911844d

…ger_secret_version`

fix: typo

ce48830

fix: better description

37aaf16

feat(secretmanager): ephemeral fetch functionality + basic test

1644623

feat(secretmanager): added base64 support + better way of testing

5654681

fix: remove comment

517c164

docs: better description

063bc7e

docs(secretmanager): added documentation page for website

db2c7e0

docs(secretmanager): fix naming inconsistencies

3d46ebc

ramonvermeulen force-pushed the ramon/20516-ephemeral-support-secret-manager-secret-version branch from 1f240c7 to 3d46ebc Compare September 4, 2025 06:31

secretmanager: ephemeral support for google_secret_manager_secret_version #14700

Are you sure you want to change the base?

secretmanager: ephemeral support for google_secret_manager_secret_version #14700

Conversation

ramonvermeulen commented Jul 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ramonvermeulen commented Jul 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jul 31, 2025

Uh oh!

SirGitsalot commented Jul 31, 2025

Uh oh!

github-actions bot commented Aug 5, 2025

Uh oh!

github-actions bot commented Aug 7, 2025

Uh oh!

github-actions bot commented Aug 14, 2025

Uh oh!

ramonvermeulen commented Aug 14, 2025

Uh oh!

modular-magician commented Aug 18, 2025

Diff report

Uh oh!

modular-magician commented Aug 18, 2025

Tests analytics

Action taken

Uh oh!

modular-magician commented Aug 18, 2025

Uh oh!

ramonvermeulen commented Aug 19, 2025

Uh oh!

BBBmau commented Aug 19, 2025

Uh oh!

BBBmau commented Aug 20, 2025

Uh oh!

modular-magician commented Aug 20, 2025

Diff report

Uh oh!

modular-magician commented Aug 20, 2025

Tests analytics

Action taken

Uh oh!

modular-magician commented Aug 20, 2025

Uh oh!

github-actions bot commented Aug 21, 2025

Uh oh!

ramonvermeulen commented Aug 26, 2025

Uh oh!

modular-magician commented Aug 26, 2025

Diff report

Uh oh!

modular-magician commented Aug 26, 2025

Tests analytics

Action taken

Uh oh!

modular-magician commented Aug 27, 2025

Uh oh!

github-actions bot commented Aug 28, 2025

Uh oh!

github-actions bot commented Sep 4, 2025

Uh oh!

bschaatsbergen commented Sep 7, 2025

Uh oh!

mvanholsteijn commented Sep 7, 2025

Uh oh!

Uh oh!

secretmanager: ephemeral support for `google_secret_manager_secret_version` #14700

secretmanager: ephemeral support for `google_secret_manager_secret_version` #14700

ramonvermeulen commented Jul 31, 2025 •

edited

Loading

ramonvermeulen commented Jul 31, 2025 •

edited

Loading