Path tool no longer overrides other hints #3222
Open
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
an alternative would be to call responses.add_front(FrontendMessage::UpdateInputHints { hint_data }); as opposed to responses.add(FrontendMessage::UpdateInputHints { hint_data }); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://discord.com/channels/731730685944922173/881073965047636018/1419968518086197269
Previously the path tool hints would override the hints from other operations (Eg GRS's hints would not show. This was the case for everything but the drag) It was just an order of operations issue. When "update_dynamic_hints" was created (replacing "update_hints"), the path tool updates would always happen after the other tools' hints. This means that, when you are in GRS, the GRS hints will be written and then immediately overwrite. Sending ToolMessage::UpdateHints() after updating the path tool's hints fixes this.