bashdb 5.2-1.2.0

Author: osalbahr

Formula/b/bashdb.rb

@@ -1,9 +1,9 @@
 class Bashdb < Formula
   desc "Bash shell debugger"
   homepage "https://bashdb.sourceforge.net/"
-  url "https://downloads.sourceforge.net/project/bashdb/bashdb/5.0-1.1.2/bashdb-5.0-1.1.2.tar.bz2"
-  version "5.0-1.1.2"
-  sha256 "30176d2ad28c5b00b2e2d21c5ea1aef8fbaf40a8f9d9f723c67c60531f3b7330"
+  url "https://downloads.sourceforge.net/project/bashdb/bashdb/5.2-1.2.0/bashdb-5.2-1.2.0.tar.bz2"
+  version "5.2-1.2.0"
+  sha256 "96fe0c8ffc12bc478c9dc41bb349ae85135da71b692069b8b7f62b27967ce534"
   license "GPL-2.0-or-later"
 
   # We check the "bashdb" directory page because the bashdb project contains
@@ -15,7 +15,7 @@ class Bashdb < Formula
     strategy :page_match
   end
 
-  no_autobump! because: :requires_manual_review
+  no_autobump! because: :incompatible_version_format
 
   bottle do
     rebuild 1
@@ -28,16 +28,12 @@ class Bashdb < Formula
     sha256 cellar: :any_skip_relocation, x86_64_linux:  "8f2ec4abf07b97ccf17dd28f503864ff00ea05049a9b844de637612b85478aa7"
   end
 
-  depends_on "autoconf" => :build # due to patch
-  depends_on "automake" => :build # due to patch
   depends_on "bash"
 
-  # Bypass error with Bash 5.1: "error: This package is only known to work with Bash 5.0"
-  # Upstream ref: https://sourceforge.net/p/bashdb/code/ci/6daffb5c7337620b429f5e94c282b75a0777fc82/
-  patch :DATA
-
   def install
-    system "autoreconf", "--force", "--install", "--verbose"
+    # Update configure to support Bash 5.3 by replacing `'5.2' | '5.0' | '5.1'`
+    inreplace "configure", /(?:'5\.\d+'(?:\s+\|\s+)?)+/, "'#{Formula["bash"].version.major_minor}'"
+
     system "./configure", "--with-bash=#{HOMEBREW_PREFIX}/bin/bash", *std_configure_args
     system "make", "install"
   end
@@ -46,26 +42,3 @@ def install
     assert_match version.to_s, pipe_output("#{bin}/bashdb --version 2>&1")
   end
 end
-
-__END__
---- a/configure.ac
-+++ b/configure.ac
-@@ -107,7 +107,7 @@
- [bash_minor=`$SH_PROG -c 'echo ${BASH_VERSINFO[1]}'`]
- bash_5_or_greater=no
- case "${bash_major}.${bash_minor}" in
--  'OK_BASH_VERS' | '5.0')
-+  'OK_BASH_VERS' | '5.0' | '5.1' | '5.2')
-     bash_5_or_greater=yes
-     ;;
-   *)
-@@ -118,7 +118,8 @@
-
- AC_ARG_WITH(dbg-main, AC_HELP_STRING([--with-dbg-main],
-                   [location of dbg-main.sh]),
--		  DBGR_MAIN=$withval)
-+		  [DBGR_MAIN=$withval]
-+		  [DBGR_MAIN=${ac_default_prefix/prefix}/bashdb/bashdb-main.inc])
- AC_SUBST(DBGR_MAIN)
-
- mydir=$(dirname $0)