macho: 2.4.0 (#284)

* rubocop, gemspec: Enforce Ruby >= 2.5

This is the earliest Ruby we test in CI.

* fat_file: RuboCop autocorrection

* macho: 2.4.0

Author: woodruffw

.rubocop.yml

@@ -1,4 +1,5 @@
 AllCops:
+  TargetRubyVersion: 2.5
   NewCops: enable
 
 Style/StringLiterals:

lib/macho.rb

@@ -16,7 +16,7 @@
 # The primary namespace for ruby-macho.
 module MachO
   # release version
-  VERSION = "2.3.0"
+  VERSION = "2.4.0"
 
   # Opens the given filename as a MachOFile or FatFile, depending on its magic.
   # @param filename [String] the file being opened

lib/macho/fat_file.rb

@@ -398,16 +398,14 @@ def each_macho(options = {})
       errors = []
 
       machos.each_with_index do |macho, index|
-        begin
-          yield macho
-        rescue RecoverableModificationError => e
-          e.macho_slice = index
+        yield macho
+      rescue RecoverableModificationError => e
+        e.macho_slice = index
 
-          # Strict mode: Immediately re-raise. Otherwise: Retain, check later.
-          raise e if strict
+        # Strict mode: Immediately re-raise. Otherwise: Retain, check later.
+        raise e if strict
 
-          errors << e
-        end
+        errors << e
       end
 
       # Non-strict mode: Raise first error if *all* Mach-O slices failed.

ruby-macho.gemspec

@@ -10,7 +10,7 @@ Gem::Specification.new do |s|
   s.authors = ["William Woodruff"]
   s.email = "[email protected]"
   s.files = Dir["LICENSE", "README.md", ".yardopts", "lib/**/*"]
-  s.required_ruby_version = ">= 2.3"
+  s.required_ruby_version = ">= 2.5"
   s.homepage = "https://github.com/Homebrew/ruby-macho"
   s.license = "MIT"
 end