-
Notifications
You must be signed in to change notification settings - Fork 339
feat: Make profileId overwritable per frame to support custom Shelly clusters #1418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Make profileId overwritable per frame to support custom Shelly clusters #1418
Conversation
d5ced11
to
a0bc0fb
Compare
a0bc0fb
to
fe809d2
Compare
We should add complete generic support and add the variables to group/broadcast too. |
- Move shelly profile id to an exported constant - Skip sourceEndpointInfo logic in ember adapters if profileId parameter is present - Skip dynamic endpoint selection if no profile id is given for zStack adapters - Move endpoint selection into function to make it reusable for groups and broadcast for zStack adapters
Support for group and broadcast frames was added. |
787460e
to
7bffe08
Compare
It's a little strange that |
@SvenKirschbaum Off-topic but if you are by any chance interested in also contributing support for this to Home Assistant's ZHA integration as well then please see this discussion in the zigpy/zha community: |
Sorry for taking so long to merge, thanks! |
This is a companion PR to 9468.
This PR exposes a new option, making it possible to override the profileId contained in the APS frame individually.
As zStack does not support changing the profileId directly, in case the profileId but no src endpoint is set, an endpoint with the correct profile is choosen automatically. If the requested profileId cannot be satisfied, an exception is thrown.
Please note, that i only own ember based adapters, so the changes to the other adapters are untested.
I have also added the following Shelly specific changes: