Re-enable IDE0059 for a "reference-like" type (dotnet#13042)

Tanya-Solyanik · LeafShi1 · commit a567547026d3 · 2025-03-06T10:32:59.000+08:00
Fixes dotnet#12997 Re-enable IDE0059 for a "reference-like" type, as our SDK now has the fix for this analyzer.
diff --git a/src/System.Private.Windows.Core/src/System/SpanHelpers.cs b/src/System.Private.Windows.Core/src/System/SpanHelpers.cs
@@ -22,9 +22,7 @@ public static void CopyAndTerminate(this ReadOnlySpan<char> source, Span<char> d
         source.CopyTo(destination);
 
         // Null terminate the string
-#pragma warning disable IDE0059 // Unnecessary assignment of a value
         destination[source.Length] = '\0';
-#pragma warning restore IDE0059
     }
 
     /// <summary>

Original file line number	Diff line number	Diff line change
`@@ -22,9 +22,7 @@ public static void CopyAndTerminate(this ReadOnlySpan<char> source, Span<char> d`
`22`	`22`	`source.CopyTo(destination);`
`23`	`23`
`24`	`24`	`// Null terminate the string`
`25`		`-#pragma warning disable IDE0059 // Unnecessary assignment of a value`
`26`	`25`	`destination[source.Length] = '\0';`
`27`		`-#pragma warning restore IDE0059`
`28`	`26`	`}`
`29`	`27`
`30`	`28`	`/// <summary>`