Skip to content

deprecate add_transform #2091

@t-vi

Description

@t-vi

We favour the JIT interface to be used as
jfoo = thunder.jit(foo, transforms=[A(), B(), C()])
rather than
jfoo = thunder.jit(foo) ; jfoo = add_transform(A()); jfoo = add_transform(B()); jfoo = add_transform(C()); .

In the second pattern, A is applied 3x and B 2x. Also it is unclear what should happen to other parts of compile data.

Thus I propose to remove add_transform.
We do use it in some of our tests, but it should not be too user-facing.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions