-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Add a trainer.ckpt_path
setter for stateful loading
#16187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
⚡ Required checks status: All passing 🟢Groups summary🟢 pytorch_lightning: Tests workflowThese checks are required after the changes to 🟢 pytorch_lightning: Azure GPU
These checks are required after the changes to 🟢 pytorch_lightning: Azure HPU
These checks are required after the changes to 🟢 pytorch_lightning: Azure IPU
These checks are required after the changes to 🟢 pytorch_lightning: Docs
These checks are required after the changes to 🟢 mypy
These checks are required after the changes to 🟢 installThese checks are required after the changes to Thank you for your contribution! 💜
|
ff9708d
to
a67b699
Compare
a67b699
to
b220ba8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand these changes. We were supposed to make things simpler, not more complicated.
What does this PR do?
This is a tool that NeMo can use in replacement of the
resume_checkpoint_path
attribute, removed in #16167: https://github.com/NVIDIA/NeMo/blob/85cc023adc530de59dd13903c4541ca008b260d3/nemo/utils/exp_manager.py#L575cc @Borda @justusschock @awaelchli @SeanNaren @titu1994
Does your PR introduce any breaking changes? If yes, please list them.
None
Before submitting
PR review