Skip to content

Commit 37f672d

Browse files
carmoccalantiga
authored andcommitted
Remove the deprecated code in pl.core.mixins (#16424)
1 parent fd9a380 commit 37f672d

File tree

4 files changed

+2
-36
lines changed

4 files changed

+2
-36
lines changed

src/pytorch_lightning/CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,8 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
6767
* env_prefix
6868
* env_parse
6969

70+
- Removed the deprecated code in `pl.core.mixins` ([#16424](https://github.com/Lightning-AI/lightning/pull/16424))
71+
7072
- Removed the deprecated code in `pl.utilities.distributed` ([#16390](https://github.com/Lightning-AI/lightning/pull/16390))
7173

7274
- Removed the deprecated code in `pl.utilities.apply_func` ([#16413](https://github.com/Lightning-AI/lightning/pull/16413))

src/pytorch_lightning/core/mixins/__init__.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,4 @@
1111
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
1212
# See the License for the specific language governing permissions and
1313
# limitations under the License.
14-
15-
from lightning_fabric.utilities.device_dtype_mixin import _DeviceDtypeModuleMixin # noqa: F401
1614
from pytorch_lightning.core.mixins.hparams_mixin import HyperparametersMixin # noqa: F401

src/pytorch_lightning/core/mixins/device_dtype_mixin.py

Lines changed: 0 additions & 25 deletions
This file was deleted.

tests/tests_pytorch/deprecated_api/test_remove_2-0.py

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
from torch.utils.data import DataLoader
1818

1919
from pytorch_lightning.accelerators.cpu import CPUAccelerator
20-
from pytorch_lightning.core.mixins.device_dtype_mixin import DeviceDtypeModuleMixin
2120
from pytorch_lightning.demos.boring_classes import RandomDataset
2221
from pytorch_lightning.strategies.utils import on_colab_kaggle
2322
from pytorch_lightning.utilities.cloud_io import atomic_save, get_filesystem, load
@@ -31,14 +30,6 @@ def test_v1_10_deprecated_on_colab_kaggle_func():
3130
on_colab_kaggle()
3231

3332

34-
def test_v1_10_deprecated_device_dtype_module_mixin():
35-
class MyModule(DeviceDtypeModuleMixin):
36-
pass
37-
38-
with pytest.deprecated_call(match="mixins.DeviceDtypeModuleMixin` has been deprecated in v1.8.0"):
39-
MyModule()
40-
41-
4233
def test_v1_10_deprecated_cloud_io_utilities(tmpdir):
4334
with pytest.deprecated_call(match="cloud_io.atomic_save` has been deprecated in v1.8.0"):
4435
atomic_save({}, tmpdir / "atomic_save.ckpt")

0 commit comments

Comments
 (0)