Skip to content

Commit d0b101c

Browse files
authored
[App] Temporarily disable ready (#15958)
1 parent 3004f13 commit d0b101c

File tree

2 files changed

+13
-2
lines changed

2 files changed

+13
-2
lines changed

src/lightning_app/core/app.py

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -486,7 +486,15 @@ def _run(self) -> bool:
486486
"""
487487
self._original_state = deepcopy(self.state)
488488
done = False
489-
self.ready = self.root.ready
489+
490+
# TODO: Re-enable the `ready` property once issues are resolved
491+
if not self.root.ready:
492+
warnings.warn(
493+
"One of your Flows returned `.ready` as `False`. "
494+
"This feature is not yet enabled so this will be ignored.",
495+
UserWarning,
496+
)
497+
self.ready = True
490498

491499
self._start_with_flow_works()
492500

src/lightning_app/core/flow.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -232,7 +232,10 @@ def __getattr__(self, item):
232232

233233
@property
234234
def ready(self) -> bool:
235-
"""Override to customize when your App should be ready."""
235+
"""Not currently enabled.
236+
237+
Override to customize when your App should be ready.
238+
"""
236239
flows = self.flows
237240
return all(flow.ready for flow in flows.values()) if flows else True
238241

0 commit comments

Comments
 (0)