Skip to content

Commit fafe429

Browse files
tshu-wBorda
authored andcommitted
Make sure save_dir can be empty str (#15638)
(cherry picked from commit c53dc20)
1 parent d10430a commit fafe429

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

src/pytorch_lightning/callbacks/model_checkpoint.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -574,7 +574,10 @@ def __resolve_ckpt_dir(self, trainer: "pl.Trainer") -> _PATH:
574574
return self.dirpath
575575

576576
if len(trainer.loggers) > 0:
577-
save_dir = trainer.loggers[0].save_dir or trainer.default_root_dir
577+
if trainer.loggers[0].save_dir is not None:
578+
save_dir = trainer.loggers[0].save_dir
579+
else:
580+
save_dir = trainer.default_root_dir
578581
name = trainer.loggers[0].name
579582
version = trainer.loggers[0].version
580583
version = version if isinstance(version, str) else f"version_{version}"

0 commit comments

Comments
 (0)