Skip to content

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Oct 12, 2022

What does this PR do?

Fixes #15088

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

cc @Borda @rohitgr7 @Felonious-Spellfire

@awaelchli awaelchli added the docs Documentation related label Oct 12, 2022
@awaelchli awaelchli added this to the v1.8 milestone Oct 12, 2022
@github-actions github-actions bot added the app (removed) Generic label for Lightning App package label Oct 12, 2022
@awaelchli awaelchli self-assigned this Oct 12, 2022
@mergify mergify bot added the ready PRs ready to be merged label Oct 12, 2022
@awaelchli awaelchli enabled auto-merge (squash) October 12, 2022 12:13
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! But I personally find it confusing to run things which aren't doing anyting.

@awaelchli awaelchli merged commit d2840a2 into master Oct 12, 2022
@awaelchli awaelchli deleted the docs/fix-run branch October 12, 2022 13:32
@awaelchli
Copy link
Contributor Author

@tchaton what would be the alternative in your opinion? The run method needs to be there as per #14760. We could

def run():
    pass

but IMO the pattern should be to run the child components.

@awaelchli awaelchli mentioned this pull request Oct 13, 2022
12 tasks
nicolai86 pushed a commit that referenced this pull request Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app (removed) Generic label for Lightning App package docs Documentation related ready PRs ready to be merged
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Streamlit example app doesn't work
6 participants