BusinessBase SaveAsync exception issue (#4032)

russblair · wfacey · web-flow · commit 27744c99c94e · 2024-06-14T20:40:54.000-05:00
* Remove debugging catch logic in SaveAsync

* Added logic to create unique GUID in FakePerson

---------

Co-authored-by: Will Facey &lt;wfacey@carus.ca&gt;
diff --git a/Source/Csla.Blazor.Test/Fakes/FakePerson.cs b/Source/Csla.Blazor.Test/Fakes/FakePerson.cs
@@ -95,7 +95,7 @@ protected override void OnChildChanged(Csla.Core.ChildChangedEventArgs e)
     [Create]
     private void Create([Inject] IChildDataPortal<FakePersonEmailAddresses> dataPortal)
     {
-      Id = new Guid();
+      Id = Guid.NewGuid();
       // Create an empty list for holding email addresses
       LoadProperty(EmailAddressesProperty, dataPortal.CreateChild());
 
diff --git a/Source/Csla/BusinessBase.cs b/Source/Csla/BusinessBase.cs
@@ -196,10 +196,6 @@ protected async virtual Task<T> SaveAsync(bool forceUpdate, object userState, bo
           {
             result = await dp.UpdateAsync((T)this);
           }
-          catch(Exception ex)
-          {
-            var msg = ex.Message;
-          }
           finally
           {
             if (ApplicationContext.AutoCloneOnUpdate)

Original file line number	Diff line number	Diff line change
`@@ -95,7 +95,7 @@ protected override void OnChildChanged(Csla.Core.ChildChangedEventArgs e)`
`95`	`95`	`[Create]`
`96`	`96`	`private void Create([Inject] IChildDataPortal<FakePersonEmailAddresses> dataPortal)`
`97`	`97`	`{`
`98`		`- Id = new Guid();`
	`98`	`+ Id = Guid.NewGuid();`
`99`	`99`	`// Create an empty list for holding email addresses`
`100`	`100`	`LoadProperty(EmailAddressesProperty, dataPortal.CreateChild());`
`101`	`101`
Original file line number	Diff line number	Diff line change
`@@ -196,10 +196,6 @@ protected async virtual Task<T> SaveAsync(bool forceUpdate, object userState, bo`
`196`	`196`	`{`
`197`	`197`	`result = await dp.UpdateAsync((T)this);`
`198`	`198`	`}`
`199`		`- catch(Exception ex)`
`200`		`- {`
`201`		`- var msg = ex.Message;`
`202`		`- }`
`203`	`199`	`finally`
`204`	`200`	`{`
`205`	`201`	`if (ApplicationContext.AutoCloneOnUpdate)`