Update SMTP proxy tests to use internal SMTP server.

To eliminate need for reliance on external connections during this test.

Setting this up requires auth for the rest of our internal mail tests.

Author: GUI

config/test.yml

@@ -77,6 +77,11 @@ web:
     smtp_settings:
       address: 127.0.0.1
       port: 13102
+      starttls: true
+      ssl_host: ssltest.example.com
+      ssl_verify: false
+      user_name: api_umbrella
+      password: dev_password
   contact_form_email: [email protected]
   analytics_v0_summary_start_time: "2013-07-01T00:00:00.000-06:00"
   analytics_v0_summary_end_time: "2013-08-31T23:59:59.999-06:00"

templates/etc/perp/test-env-mailpit/rc.env.etlua

@@ -1 +1,2 @@
 LD_LIBRARY_PATH=<%- config["_embedded_root_dir"] %>/openresty/luajit/lib:<%- config["_embedded_root_dir"] %>/lib
+MP_SMTP_AUTH=api_umbrella:dev_password

templates/etc/perp/test-env-mailpit/rc.main.etlua

@@ -17,6 +17,8 @@ if [ "${1}" = "start" ]; then
   fi
 
   exec runtool ${run_args[@]+"${run_args[@]}"} mailpit \
+    --smtp-tls-cert "<%- config['_src_root_dir'] %>/test/config/ssl_test.crt" \
+    --smtp-tls-key "<%- config['_src_root_dir'] %>/test/config/ssl_test.key" \
     --smtp "<%- config['mailpit']['bind_addr'] %>:<%- config['mailpit']['smtp_port'] %>" \
     --listen "<%- config['mailpit']['bind_addr'] %>:<%- config['mailpit']['http_port'] %>"
 fi

test/proxy/envoy/test_smtp_proxy.rb

@@ -8,6 +8,9 @@ class Test::Proxy::Envoy::TestSmtpProxy < Minitest::Test
   def setup
     super
     setup_server
+    @ssl_context_params = {
+      ca_file: File.join(API_UMBRELLA_SRC_ROOT, "test/config/ssl_test.crt"),
+    }
   end
 
   def test_disabled_by_default
@@ -17,7 +20,7 @@ def test_disabled_by_default
   end
 
   def test_direct_smtp_sanity_check
-    smtp = Net::SMTP.new("in-v3.mailjet.com", 80, starttls: :always)
+    smtp = Net::SMTP.new("127.0.0.1", $config["mailpit"]["smtp_port"], starttls: :always, ssl_context_params: @ssl_context_params, tls_hostname: "ssltest.example.com")
     smtp.open_timeout = 5
     smtp.start
     assert_equal(true, smtp.esmtp?)
@@ -31,8 +34,8 @@ def test_only_connects_to_single_target
         "smtp_proxy" => {
           "enabled" => true,
           "endpoint" => {
-            "host" => "in-v3.mailjet.com",
-            "port" => 80,
+            "host" => "127.0.0.1",
+            "port" => $config["mailpit"]["smtp_port"],
           },
         },
       },
@@ -41,15 +44,15 @@ def test_only_connects_to_single_target
       assert_equal(true, open)
 
       # Verify that without an explict TLS host, we get a certificate error.
-      smtp = Net::SMTP.new("127.0.0.1", 13003, starttls: :always)
+      smtp = Net::SMTP.new("127.0.0.1", 13003, starttls: :always, ssl_context_params: @ssl_context_params)
       smtp.open_timeout = 5
       error = assert_raises OpenSSL::SSL::SSLError do
         smtp.start
       end
       assert_match("certificate verify failed (hostname mismatch)", error.message)
 
       # Verify normal connection to the expected underlying host.
-      smtp = Net::SMTP.new("127.0.0.1", 13003, starttls: :always, tls_hostname: "in-v3.mailjet.com")
+      smtp = Net::SMTP.new("127.0.0.1", 13003, starttls: :always, ssl_context_params: @ssl_context_params, tls_hostname: "ssltest.example.com")
       smtp.open_timeout = 5
       smtp.start
       assert_equal(true, smtp.esmtp?)
@@ -58,7 +61,7 @@ def test_only_connects_to_single_target
 
       # Verify that trying a different TLS host also results in a certificate
       # error.
-      smtp = Net::SMTP.new("127.0.0.1", 13003, starttls: :always, tls_hostname: "email.us-east-1.amazonaws.com")
+      smtp = Net::SMTP.new("127.0.0.1", 13003, starttls: :always, ssl_context_params: @ssl_context_params, tls_hostname: "email.us-east-1.amazonaws.com")
       smtp.open_timeout = 5
       error = assert_raises OpenSSL::SSL::SSLError do
         smtp.start
@@ -73,8 +76,8 @@ def test_web_app_uses_proxy
         "smtp_proxy" => {
           "enabled" => true,
           "endpoint" => {
-            "host" => "in-v3.mailjet.com",
-            "port" => 80,
+            "host" => "127.0.0.1",
+            "port" => $config["mailpit"]["smtp_port"],
           },
         },
       },