Fix analytics tests and fix analytics APIs for no indices.

GUI · GUI · commit c743e79ad904 · 2018-06-07T15:45:43.000-06:00
- Get all the analytics-related tests working again in this branch of
  merged upgrades/things.
- We had added some tests for the behavior of analytics API queries
  against date ranges without any elasticsearch indices present. Fix
  that behavior in the Rails version of the web-app by handling the lack
  of aggregation results.
- Other test suite fixes.
diff --git a/config/elasticsearch_templates_v1_es1.json b/config/elasticsearch_templates_v1_es1.json
@@ -5,7 +5,7 @@
       "template": "api-umbrella-logs-v1-*",
       "settings": {
         "index": {
-          "number_of_shards": 1,
+          "number_of_shards": 3,
           "codec": "best_compression"
         },
         "analysis": {
@@ -27,21 +27,7 @@
           "_all": {
             "enabled": false
           },
-          "date_detection": false,
-          "numeric_detection": false,
-          "dynamic_templates": [
-            {
-              "string_template": {
-                "match": "*",
-                "match_mapping_type": "string",
-                "mapping": {
-                  "type": "string",
-                  "index": "analyzed",
-                  "analyzer": "keyword_lowercase"
-                }
-              }
-            }
-          ],
+          "dynamic": false,
           "properties": {
             "api_backend_id": {
               "type": "string",
diff --git a/config/elasticsearch_templates_v1_es5.json b/config/elasticsearch_templates_v1_es5.json
@@ -5,7 +5,7 @@
       "template": "api-umbrella-logs-v1-*",
       "settings": {
         "index": {
-          "number_of_shards": 1,
+          "number_of_shards": 3,
           "codec": "best_compression"
         },
         "analysis": {
diff --git a/config/elasticsearch_templates_v2_es5.json b/config/elasticsearch_templates_v2_es5.json
@@ -84,7 +84,8 @@
               "normalizer": "lowercase_normalizer"
             },
             "request_ip_city": {
-              "type": "keyword"
+              "type": "keyword",
+              "normalizer": "lowercase_normalizer"
             },
             "request_ip_country": {
               "type": "keyword",
diff --git a/src/api-umbrella/proxy/startup/init_elasticsearch_templates_data.lua b/src/api-umbrella/proxy/startup/init_elasticsearch_templates_data.lua
@@ -1,6 +1,12 @@
 local cjson = require "cjson"
 
-local path = os.getenv("API_UMBRELLA_SRC_ROOT") .. "/config/elasticsearch_templates_v" .. config["elasticsearch"]["template_version"] .. "_es2x.json"
+local path = os.getenv("API_UMBRELLA_SRC_ROOT") .. "/config/elasticsearch_templates_v" .. config["elasticsearch"]["template_version"]
+if config["elasticsearch"]["api_version"] >= 5 then
+  path = path .. "_es5.json"
+else
+  path = path .. "_es1.json"
+end
+
 local f, err = io.open(path, "rb")
 if err then
   ngx.log(ngx.ERR, "failed to open file: ", err)
diff --git a/src/api-umbrella/web-app/app/controllers/admin/stats_controller.rb b/src/api-umbrella/web-app/app/controllers/admin/stats_controller.rb
@@ -146,7 +146,7 @@ def users
     @search.aggregate_by_user_stats!(aggregation_options)
 
     @result = @search.result
-    buckets = @result.aggregations["user_stats"]["buckets"]
+    buckets = if(@result.aggregations && @result.aggregations["user_stats"]) then @result.aggregations["user_stats"]["buckets"] else [] end
     @total = buckets.length
 
     # If we were sorting by one of the facet fields, then the sorting has
@@ -195,7 +195,9 @@ def users
 
     respond_to do |format|
       format.json
-      format.csv
+      format.csv do
+        @filename = "api_users_#{Time.now.utc.strftime("%Y-%m-%d")}.csv"
+      end
     end
   end
 
@@ -216,7 +218,9 @@ def map
 
     respond_to do |format|
       format.json
-      format.csv
+      format.csv do
+        @filename = "api_map_#{Time.now.utc.strftime("%Y-%m-%d")}.csv"
+      end
     end
   end
 
diff --git a/src/api-umbrella/web-app/app/controllers/api/v1/analytics_controller.rb b/src/api-umbrella/web-app/app/controllers/api/v1/analytics_controller.rb
@@ -28,7 +28,9 @@ def drilldown
     @result = @search.result
 
     respond_to do |format|
-      format.csv
+      format.csv do
+        @filename = "api_drilldown_#{Time.now.utc.strftime("%Y-%m-%d")}.csv"
+      end
       format.json do
         @breadcrumbs = [
           :crumb => "All Hosts",
@@ -51,48 +53,50 @@ def drilldown
           :rows => [],
         }
 
-        @result.aggregations["top_path_hits_over_time"]["buckets"].each do |bucket|
-          @hits_over_time[:cols] << {
-            :id => bucket["key"],
-            :label => bucket["key"].split("/", 2).last,
-            :type => "number",
-          }
-        end
-
-        has_other_hits = false
-        @result.aggregations["hits_over_time"]["buckets"].each_with_index do |total_bucket, index|
-          cells = [
-            { :v => total_bucket["key"], :f => formatted_interval_time(total_bucket["key"]) },
-          ]
-
-          path_total_hits = 0
-          @result.aggregations["top_path_hits_over_time"]["buckets"].each do |path_bucket|
-            bucket = path_bucket["drilldown_over_time"]["buckets"][index]
-            cells << { :v => bucket["doc_count"], :f => number_with_delimiter(bucket["doc_count"]) }
-            path_total_hits += bucket["doc_count"]
+        if @result.aggregations
+          @result.aggregations["top_path_hits_over_time"]["buckets"].each do |bucket|
+            @hits_over_time[:cols] << {
+              :id => bucket["key"],
+              :label => bucket["key"].split("/", 2).last,
+              :type => "number",
+            }
           end
 
-          other_hits = total_bucket["doc_count"] - path_total_hits
-          cells << { :v => other_hits, :f => number_with_delimiter(other_hits) }
-
-          @hits_over_time[:rows] << {
-            :c => cells,
-          }
-
-          if(other_hits > 0)
-            has_other_hits = true
+          has_other_hits = false
+          @result.aggregations["hits_over_time"]["buckets"].each_with_index do |total_bucket, index|
+            cells = [
+              { :v => total_bucket["key"], :f => formatted_interval_time(total_bucket["key"]) },
+            ]
+
+            path_total_hits = 0
+            @result.aggregations["top_path_hits_over_time"]["buckets"].each do |path_bucket|
+              bucket = path_bucket["drilldown_over_time"]["buckets"][index]
+              cells << { :v => bucket["doc_count"], :f => number_with_delimiter(bucket["doc_count"]) }
+              path_total_hits += bucket["doc_count"]
+            end
+
+            other_hits = total_bucket["doc_count"] - path_total_hits
+            cells << { :v => other_hits, :f => number_with_delimiter(other_hits) }
+
+            @hits_over_time[:rows] << {
+              :c => cells,
+            }
+
+            if(other_hits > 0)
+              has_other_hits = true
+            end
           end
-        end
 
-        if(has_other_hits)
-          @hits_over_time[:cols] << {
-            :id => "other",
-            :label => "Other",
-            :type => "number",
-          }
-        else
-          @hits_over_time[:rows].each do |row|
-            row[:c].slice!(-1)
+          if(has_other_hits)
+            @hits_over_time[:cols] << {
+              :id => "other",
+              :label => "Other",
+              :type => "number",
+            }
+          else
+            @hits_over_time[:rows].each do |row|
+              row[:c].slice!(-1)
+            end
           end
         end
       end
diff --git a/src/api-umbrella/web-app/app/models/log_result/base.rb b/src/api-umbrella/web-app/app/models/log_result/base.rb
@@ -19,36 +19,40 @@ def aggregations
   end
 
   def hits_over_time
-    if(!@hits_over_time && aggregations["hits_over_time"])
+    unless @hits_over_time
       @hits_over_time = {}
 
-      aggregations["hits_over_time"]["buckets"].each do |bucket|
-        @hits_over_time[bucket["key"]] = bucket["doc_count"]
+      if(aggregations && aggregations["hits_over_time"])
+        aggregations["hits_over_time"]["buckets"].each do |bucket|
+          @hits_over_time[bucket["key"]] = bucket["doc_count"]
+        end
       end
     end
 
     @hits_over_time
   end
 
   def drilldown
-    if(!@drilldown && aggregations["drilldown"])
+    unless @drilldown
       @drilldown = []
 
-      aggregations["drilldown"]["buckets"].each do |bucket|
-        depth, path = bucket["key"].split("/", 2)
-        terminal = !path.end_with?("/")
-
-        depth = depth.to_i
-        descendent_depth = depth + 1
-        descendent_prefix = File.join(descendent_depth.to_s, path)
-
-        @drilldown << {
-          :depth => depth,
-          :path => path,
-          :terminal => terminal,
-          :descendent_prefix => descendent_prefix,
-          :hits => bucket["doc_count"],
-        }
+      if(aggregations && aggregations["drilldown"])
+        aggregations["drilldown"]["buckets"].each do |bucket|
+          depth, path = bucket["key"].split("/", 2)
+          terminal = !path.end_with?("/")
+
+          depth = depth.to_i
+          descendent_depth = depth + 1
+          descendent_prefix = File.join(descendent_depth.to_s, path)
+
+          @drilldown << {
+            :depth => depth,
+            :path => path,
+            :terminal => terminal,
+            :descendent_prefix => descendent_prefix,
+            :hits => bucket["doc_count"],
+          }
+        end
       end
     end
 
@@ -86,23 +90,25 @@ def cities
     unless @cities
       @cities = {}
 
-      @regions = aggregations["regions"]["buckets"]
-      if(@search.query[:aggregations][:regions][:terms][:field] == "request_ip_city")
-        @city_names = @regions.map { |bucket| bucket["key"] }
-        @cities = {}
-
-        if @city_names.any?
-          cities = LogCityLocation.where(:country => @search.country)
-          if @search.state
-            cities = cities.where(:region => @search.state)
-          end
-          cities = cities.where(:city.in => @city_names)
-
-          cities.each do |city|
-            @cities[city.city] = {
-              "lat" => city.location["coordinates"][1],
-              "lon" => city.location["coordinates"][0],
-            }
+      if(aggregations && aggregations["regions"])
+        @regions = aggregations["regions"]["buckets"]
+        if(@search.query[:aggregations][:regions][:terms][:field] == "request_ip_city")
+          @city_names = @regions.map { |bucket| bucket["key"] }
+          @cities = {}
+
+          if @city_names.any?
+            cities = LogCityLocation.where(:country => @search.country)
+            if @search.state
+              cities = cities.where(:region => @search.state)
+            end
+            cities = cities.where(:city.in => @city_names)
+
+            cities.each do |city|
+              @cities[city.city] = {
+                "lat" => city.location["coordinates"][1],
+                "lon" => city.location["coordinates"][0],
+              }
+            end
           end
         end
       end
diff --git a/src/api-umbrella/web-app/app/views/admin/stats/map.rabl b/src/api-umbrella/web-app/app/views/admin/stats/map.rabl
@@ -5,32 +5,40 @@ node :region_field do
 end
 
 node :regions do
-  rows = @result.aggregations["regions"]["buckets"].map do |bucket|
-    {
-      :id => region_id(bucket["key"]),
-      :name => region_name(bucket["key"]),
-      :hits => bucket["doc_count"],
-    }
-  end
+  if(@result.aggregations && @result.aggregations["regions"])
+    rows = @result.aggregations["regions"]["buckets"].map do |bucket|
+      {
+        :id => region_id(bucket["key"]),
+        :name => region_name(bucket["key"]),
+        :hits => bucket["doc_count"],
+      }
+    end
 
-  if(@result.aggregations["missing_regions"]["doc_count"] > 0)
-    rows << {
-      :id => "missing",
-      :name => "Unknown",
-      :hits => @result.aggregations["missing_regions"]["doc_count"],
-    }
-  end
+    if(@result.aggregations["missing_regions"]["doc_count"] > 0)
+      rows << {
+        :id => "missing",
+        :name => "Unknown",
+        :hits => @result.aggregations["missing_regions"]["doc_count"],
+      }
+    end
 
-  rows
+    rows
+  else
+    []
+  end
 end
 
 node :map_regions do
-  @result.aggregations["regions"]["buckets"].map do |bucket|
-    {
-      :c => region_location_columns(bucket) + [
-        { :v => bucket["doc_count"], :f => number_with_delimiter(bucket["doc_count"]) },
-      ]
-    }
+  if(@result.aggregations && @result.aggregations["regions"])
+    @result.aggregations["regions"]["buckets"].map do |bucket|
+      {
+        :c => region_location_columns(bucket) + [
+          { :v => bucket["doc_count"], :f => number_with_delimiter(bucket["doc_count"]) },
+        ]
+      }
+    end
+  else
+    []
   end
 end
 
diff --git a/test/apis/admin/stats/test_logs.rb b/test/apis/admin/stats/test_logs.rb
@@ -101,6 +101,7 @@ def test_query_builder_case_insensitive_defaults
 
   def test_query_builder_api_key_case_sensitive
     FactoryBot.create(:log_item, :request_at => Time.parse("2015-01-16T06:06:28.816Z").utc, :api_key => "AbCDeF", :request_user_agent => unique_test_id)
+    LogItem.refresh_indices!
 
     response = Typhoeus.get("https://127.0.0.1:9081/admin/stats/logs.json", http_options.deep_merge(admin_session).deep_merge({
       :params => {
diff --git a/test/apis/admin/stats/test_users.rb b/test/apis/admin/stats/test_users.rb
diff --git a/test/proxy/logging/test_basics.rb b/test/proxy/logging/test_basics.rb
diff --git a/test/support/api_umbrella_test_helpers/logging.rb b/test/support/api_umbrella_test_helpers/logging.rb
