feat: NoSuperfluousPhpdocTagsFixer - support asymmetric visibility (#8700)

Author: kubawerlos

src/Fixer/Phpdoc/NoSuperfluousPhpdocTagsFixer.php

@@ -83,6 +83,9 @@ final class NoSuperfluousPhpdocTagsFixer extends AbstractFixer implements Config
         T_FINAL,
         T_STATIC,
         FCT::T_READONLY,
+        FCT::T_PRIVATE_SET,
+        FCT::T_PROTECTED_SET,
+        FCT::T_PUBLIC_SET,
     ];
 
     public function getDefinition(): FixerDefinitionInterface
@@ -515,7 +518,7 @@ private function parseTypeHint(Tokens $tokens, int $index): array
         while (true) {
             $type = '';
 
-            if ($tokens[$index]->isGivenKind(FCT::T_READONLY)) {
+            if ($tokens[$index]->isGivenKind([FCT::T_READONLY, FCT::T_PRIVATE_SET, FCT::T_PROTECTED_SET, FCT::T_PUBLIC_SET])) {
                 $index = $tokens->getNextMeaningfulToken($index);
             }
 

tests/Fixer/Phpdoc/NoSuperfluousPhpdocTagsFixerTest.php

@@ -3196,4 +3196,84 @@ public function foo(): null { return null; }
 }',
         ];
     }
+
+    /**
+     * @dataProvider provideFix84Cases
+     *
+     * @requires PHP 8.4
+     */
+    public function testFix84(string $expected, ?string $input = null): void
+    {
+        $this->testFix($expected, $input);
+    }
+
+    /**
+     * @return iterable<string, array{0: string, 1?: string}>
+     */
+    public static function provideFix84Cases(): iterable
+    {
+        yield 'asymmetric visibility in property' => [
+            <<<'PHP'
+                <?php class Foo
+                {
+                    /**
+                     */
+                    public public(set) bool $a;
+                    /**
+                     */
+                    public protected(set) bool $b;
+                    /**
+                     */
+                    public private(set) bool $c;
+                }
+                PHP,
+            <<<'PHP'
+                <?php class Foo
+                {
+                    /**
+                     * @var bool
+                     */
+                    public public(set) bool $a;
+                    /**
+                     * @var bool
+                     */
+                    public protected(set) bool $b;
+                    /**
+                     * @var bool
+                     */
+                    public private(set) bool $c;
+                }
+                PHP,
+        ];
+
+        yield 'asymmetric visibility in promoted property' => [
+            <<<'PHP'
+                <?php class Foo
+                {
+                    /**
+                     */
+                    public function __construct(
+                        public public(set) bool $a,
+                        public protected(set) bool $b,
+                        public private(set) bool $c,
+                    ) {}
+                }
+                PHP,
+            <<<'PHP'
+                <?php class Foo
+                {
+                    /**
+                     * @param bool $a
+                     * @param bool $b
+                     * @param bool $c
+                     */
+                    public function __construct(
+                        public public(set) bool $a,
+                        public protected(set) bool $b,
+                        public private(set) bool $c,
+                    ) {}
+                }
+                PHP,
+        ];
+    }
 }