Export only data cells/columns in toArray

Worksheet::toArray now calls these methods:

         $maxCol = $this->getHighestDataColumn();
         $maxRow = $this->getHighestDataRow();

instead of getHighestColumn and getHighestRow. This is to make sure
that rows/columns that only have some formatting are not included.
Otherwise the export would contain 16384 columns if e.g. column width
setting is applied.

Author: zoltan-vespertool

src/PhpSpreadsheet/Worksheet/Worksheet.php

@@ -3286,9 +3286,9 @@ public function toArray(
         $this->garbageCollect();
         $this->calculateArrays($calculateFormulas);
 
-        //    Identify the range that we need to extract from the worksheet
-        $maxCol = $this->getHighestColumn();
-        $maxRow = $this->getHighestRow();
+        // Identify the range that we need to extract from the worksheet
+        $maxCol = $this->getHighestDataColumn();
+        $maxRow = $this->getHighestDataRow();
 
         // Return
         return $this->rangeToArray("A1:{$maxCol}{$maxRow}", $nullValue, $calculateFormulas, $formatData, $returnCellRef, $ignoreHidden, $reduceArrays);

tests/PhpSpreadsheetTests/Worksheet/ToArrayTest.php

@@ -76,4 +76,21 @@ public static function testMaxCol(): void
         self::assertSame('start', $array[0][0]);
         self::assertSame('end', $array[0][16383]);
     }
+
+
+    public static function testToArrayConsidersValuesButNotFormatting(): void
+    {
+         $spreadsheet = new Spreadsheet();
+         $sheet = $spreadsheet->getActiveSheet();
+
+         $sheet->getCell('A1')->setValue("hello");
+         $array = $sheet->toArray(null, false, false, false, false);
+         self::assertSame([['hello']], $array);
+
+         // Create column dimension object that didn't exist yet
+         $sheet->getColumnDimension('C');
+         $array = $sheet->toArray(null, false, false, false, false);
+         // Yet there should be no column C in the export
+         self::assertSame([['hello']], $array);
+     }
 }