update color highlight logic

Author: williamchange

material_maker/icons/down.tres

@@ -1,8 +1,7 @@
-[gd_resource type="AtlasTexture" load_steps=2 format=3]
+[gd_resource type="AtlasTexture" load_steps=2 format=3 uid="uid://bp2jrkwyb64m5"]
 
-[ext_resource type="Texture2D" path="res://material_maker/icons/icons.tres" id="1"]
+[ext_resource type="Texture2D" uid="uid://c0j4px4n72di5" path="res://material_maker/icons/icons.tres" id="1"]
 
 [resource]
-flags = 4
-atlas = ExtResource( 1 )
-region = Rect2( 32, 48, 16, 16 )
+atlas = ExtResource("1")
+region = Rect2(32, 48, 16, 16)

material_maker/panels/graph_edit/graph_edit.gd

@@ -215,14 +215,14 @@ func _gui_input(event) -> void:
 				KEY_ALT:
 					if (Input.is_mouse_button_pressed(MOUSE_BUTTON_LEFT)
 							and has_graph_node_selection()):
-						hint_node_drop_blocked(false, true)
+						hint_node_drop_allowed(false)
 						highlight_connection(target_drop_connection)
 		elif not event.pressed:
 			var scancode_with_modifiers = event.get_keycode_with_modifiers()
 			match scancode_with_modifiers:
 				KEY_ALT:
 					if has_graph_node_selection():
-						hint_node_drop_blocked(true, true)
+						hint_node_drop_allowed(true)
 		match event.get_keycode():
 			KEY_SHIFT, KEY_CTRL, KEY_ALT:
 				var found_tip : bool = false
@@ -260,7 +260,7 @@ func _gui_input(event) -> void:
 		if (get_selected_nodes().size() == 1
 				and event.button_mask & MOUSE_BUTTON_MASK_LEFT != 0
 				and event.relative.length() > 0.0):
-			hint_node_drop_blocked(not event.alt_pressed, true)
+			hint_node_drop_allowed(not event.alt_pressed)
 			var node : GraphElement = get_selected_nodes()[0]
 			if node is not GraphNode:
 				return
@@ -277,19 +277,16 @@ func _gui_input(event) -> void:
 				if conns.size() > 1:
 					conns.sort_custom(compare_connection_by_port_position_y)
 				active_conn = conns.front()
+				highlight_connection(active_conn)
 				if not event.alt_pressed:
 					target_drop_connection = active_conn
 					target_drop_node = node
-				set_connection_activity(active_conn.from_node, active_conn.from_port,
-						active_conn.to_node, active_conn.to_port,
-						0.5 if has_theme_color_override("activity") else 1.0)
 			else:
 				target_drop_connection.clear()
 				target_drop_node = null
 			for c in get_connection_list():
 				if c != active_conn:
-					set_connection_activity(c.from_node, c.from_port,
-							c.to_node, c.to_port, 0.0)
+					highlight_connection(c, 0.0)
 		else:
 			remove_theme_color_override("activity")
 			remove_theme_color_override("connection_hover_tint_color")
@@ -325,12 +322,12 @@ func drop_node_on_connection(node : GraphNode, connection : Dictionary) -> void:
 				break
 		undoredo.end_group()
 
-func hint_node_drop_blocked(should_block: bool, force_connection_redraw: bool = false) -> void:
-	if should_block:
+func hint_node_drop_allowed(should_allow: bool, force_connection_redraw: bool = true) -> void:
+	add_theme_color_override("connection_hover_tint_color", Color.TRANSPARENT)
+	if should_allow:
 		remove_theme_color_override("activity")
 	else:
 		add_theme_color_override("activity", Color.BLACK)
-	add_theme_color_override("connection_hover_tint_color", Color.TRANSPARENT)
 	if force_connection_redraw:
 		get_node("_connection_layer").queue_redraw()