Ignore sun packages when importing full classpath

resolves #1446

The CI build has recently often failed on `ubuntu` and `macos` with Java 8,
due to `java.lang.OutOfMemoryError: GC overhead limit exceeded`.

This is due to `ClassFileImporterSlowTest` importing the full classpath in some tests,
which gives more than 20k classes on Java 8,
which contains 7k classes in `com.sun` and 4k classes in `sun` packages
that can easily be ignored.

Signed-off-by: Manfred Hanke <[email protected]>

Author: hankem

archunit/src/test/java/com/tngtech/archunit/core/importer/ClassFileImporterSlowTest.java

@@ -179,18 +179,19 @@ public void creates_JavaPackages() {
     }
 
     private JavaClasses importJavaBase() {
-        return new ClassFileImporter()
-                .withImportOption(location ->
-                        // before Java 9 packages like java.lang were in rt.jar
-                        location.contains("rt.jar") ||
-                                // from Java 9 on those packages were in a JRT with name 'java.base'
-                                (location.asURI().getScheme().equals("jrt") && location.contains("java.base"))
-                )
-                .importClasspath();
+        return new ClassFileImporter().withImportOption(location -> !isSunPackage(location) && (
+                // before Java 9 packages like java.lang were in rt.jar;
+                location.contains("rt.jar") ||
+                        // from Java 9 on those packages were in a JRT with name 'java.base'
+                        (location.asURI().getScheme().equals("jrt") && location.contains("java.base"))
+        )).importClasspath();
     }
 
     private ImportOption importJavaBaseOrRtAndJUnitJarAndFilesOnTheClasspath() {
         return location -> {
+            if (isSunPackage(location)) {
+                return false;
+            }
             if (!location.isArchive()) {
                 return true;
             }
@@ -200,4 +201,13 @@ private ImportOption importJavaBaseOrRtAndJUnitJarAndFilesOnTheClasspath() {
             return location.asURI().getScheme().equals("jrt") && location.contains("java.base");
         };
     }
+
+    /**
+     * Importing the full classpath may give thousands of classes in {@link sun} and (especially for Java 8) {@link com.sun} packages.
+     * Importing those would increase the memory footprint tremendously, but not give an additional benefit for the test,
+     * so it is convenient to ignore those.
+     */
+    private static boolean isSunPackage(Location location) {
+        return location.contains("/sun/");
+    }
 }