Skip to content

Commit ec8f6a0

Browse files
authored
Stop verify.xunit.props from interfering with verify.props (#1252)
1 parent eead6f8 commit ec8f6a0

File tree

3 files changed

+18
-18
lines changed

3 files changed

+18
-18
lines changed

src/Directory.Build.props

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
<Project>
33
<PropertyGroup>
44
<NoWarn>CS1591;CS0649;xUnit1026;xUnit1013;CS1573;VerifyTestsProjectDir;VerifySetParameters;PolyFillTargetsForNuget</NoWarn>
5-
<Version>26.0.0</Version>
5+
<Version>26.0.1</Version>
66
<ImplicitUsings>enable</ImplicitUsings>
77
<LangVersion>preview</LangVersion>
88
<AssemblyVersion>1.0.0</AssemblyVersion>

src/Verify.Xunit/buildTransitive/Verify.Xunit.props

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,16 +14,16 @@
1414
Inputs="$(MSBuildAllProjects)"
1515
Outputs="$(IntermediateOutputPath)$(VerifyXunitAttributesFile)">
1616
<PropertyGroup>
17-
<AttributesFilePath>$(IntermediateOutputPath)$(VerifyXunitAttributesFile)</AttributesFilePath>
17+
<VerifyXunitAttributesFilePath>$(IntermediateOutputPath)$(VerifyXunitAttributesFile)</VerifyXunitAttributesFilePath>
1818
</PropertyGroup>
1919
<ItemGroup>
20-
<Attributes Include="VerifyXunit.UseVerifyAttribute" />
20+
<VerifyXunitAttributes Include="VerifyXunit.UseVerifyAttribute" />
2121
<!-- Ensure not part of Compile, as a workaround for https://github.com/dotnet/sdk/issues/114 -->
22-
<Compile Remove="$(AttributesFilePath)" />
22+
<Compile Remove="$(VerifyXunitAttributesFilePath)" />
2323
</ItemGroup>
24-
<WriteCodeFragment AssemblyAttributes="@(Attributes)"
24+
<WriteCodeFragment AssemblyAttributes="@(VerifyXunitAttributes)"
2525
Language="$(Language)"
26-
OutputFile="$(AttributesFilePath)">
26+
OutputFile="$(VerifyXunitAttributesFilePath)">
2727
<Output TaskParameter="OutputFile" ItemName="Compile" Condition="$(Language) != 'F#'" />
2828
<Output TaskParameter="OutputFile" ItemName="CompileBefore" Condition="$(Language) == 'F#'" />
2929
<Output TaskParameter="OutputFile" ItemName="FileWrites" />

src/Verify/buildTransitive/Verify.props

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -3,37 +3,37 @@
33
<PropertyGroup>
44
<Deterministic>false</Deterministic>
55
<DeterministicSourcePaths>false</DeterministicSourcePaths>
6-
<AttributesFile>Verify.Attributes$(MSBuildProjectExtension.Replace('proj', ''))</AttributesFile>
6+
<VerifyAttributesFile>Verify.Attributes$(MSBuildProjectExtension.Replace('proj', ''))</VerifyAttributesFile>
77
<NoWarn>$(NoWarn);CA2255</NoWarn>
88
</PropertyGroup>
99
<Target Name="WriteVerifyAttributes"
1010
Condition="$(Language) == 'VB' or $(Language) == 'C#' or $(Language) == 'F#'"
1111
BeforeTargets="BeforeCompile;CoreCompile"
1212
Inputs="$(MSBuildAllProjects)"
13-
Outputs="$(IntermediateOutputPath)$(AttributesFile)">
13+
Outputs="$(IntermediateOutputPath)$(VerifyAttributesFile)">
1414
<PropertyGroup>
15-
<AttributesFilePath>$(IntermediateOutputPath)$(AttributesFile)</AttributesFilePath>
15+
<VerifyAttributesFilePath>$(IntermediateOutputPath)$(VerifyAttributesFile)</VerifyAttributesFilePath>
1616
</PropertyGroup>
1717
<ItemGroup>
18-
<Attributes Include="System.Reflection.AssemblyMetadata">
18+
<VerifyAttributes Include="System.Reflection.AssemblyMetadata">
1919
<_Parameter1>Verify.TargetFrameworks</_Parameter1>
2020
<_Parameter2>$(TargetFrameworks)</_Parameter2>
21-
</Attributes>
22-
<Attributes Include="System.Reflection.AssemblyMetadata">
21+
</VerifyAttributes>
22+
<VerifyAttributes Include="System.Reflection.AssemblyMetadata">
2323
<_Parameter1>Verify.ProjectDirectory</_Parameter1>
2424
<_Parameter2>$(ProjectDir)</_Parameter2>
25-
</Attributes>
26-
<Attributes Include="System.Reflection.AssemblyMetadata"
25+
</VerifyAttributes>
26+
<VerifyAttributes Include="System.Reflection.AssemblyMetadata"
2727
Condition="'$(SolutionDir)' != '' And '$(SolutionDir)' != '*Undefined*'">
2828
<_Parameter1>Verify.SolutionDirectory</_Parameter1>
2929
<_Parameter2>$(SolutionDir)</_Parameter2>
30-
</Attributes>
30+
</VerifyAttributes>
3131
<!-- Ensure not part of Compile, as a workaround for https://github.com/dotnet/sdk/issues/114 -->
32-
<Compile Remove="$(AttributesFilePath)" />
32+
<Compile Remove="$(VerifyAttributesFilePath)" />
3333
</ItemGroup>
34-
<WriteCodeFragment AssemblyAttributes="@(Attributes)"
34+
<WriteCodeFragment AssemblyAttributes="@(VerifyAttributes)"
3535
Language="$(Language)"
36-
OutputFile="$(AttributesFilePath)">
36+
OutputFile="$(VerifyAttributesFilePath)">
3737
<Output TaskParameter="OutputFile" ItemName="Compile" Condition="$(Language) != 'F#'" />
3838
<Output TaskParameter="OutputFile" ItemName="CompileBefore" Condition="$(Language) == 'F#'" />
3939
<Output TaskParameter="OutputFile" ItemName="FileWrites" />

0 commit comments

Comments
 (0)