fix(testmdepermissions): 🐛 Added fix for handling null roles and a test case

Author: itpropro

README.md

@@ -185,26 +185,3 @@ See [Contributing Guide](https://github.com/Visorian/PSMDE/blob/main/CONTRIBUTIN
 Made with :heart:
 
 Published under [MIT License](./LICENCE).
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-

src/private/Test-MdePermissions.ps1

@@ -15,21 +15,25 @@ function Test-MdePermissions {
     $script:initialize = $false
   }
   $roles = (Get-MdeAuthorizationInfo).roles
-  $requiredRoles = (Get-Help $functionName -Full).role | Invoke-Expression
-  $containsRole = $false
-  foreach ($role in $requiredRoles) {
-    $evaluation = $roles.contains($role.permission)
-    Write-Verbose "Checking for '[$($role.permissionType)] $($role.permission)': $evaluation"
-    $containsRole = $containsRole -or $evaluation
-  }
-  if ($detailed) {
-    return @{
-      validTokenPermission = $containsRole
-      requiredRoles        = $requiredRoles.permission
-      currentRoles         = $roles
+  if ($roles) {
+    $requiredRoles = (Get-Help $functionName -Full).role | Invoke-Expression
+    $containsRole = $false
+    foreach ($role in $requiredRoles) {
+      $evaluation = $roles.contains($role.permission)
+      Write-Verbose "Checking for '[$($role.permissionType)] $($role.permission)': $evaluation"
+      $containsRole = $containsRole -or $evaluation
+    }
+    if ($detailed) {
+      return @{
+        validTokenPermission = $containsRole
+        requiredRoles        = $requiredRoles.permission
+        currentRoles         = $roles
+      }
     }
+    return $containsRole
   }
-  return $containsRole
+  Write-Warning "No roles found, are you logged in?"
+  return $false
 }
 
 # SIG # Begin signature block

tests/private/Test-MdePermissions.Tests.ps1

@@ -62,4 +62,14 @@ Describe 'Test-MdePermissions' {
       }
     }
   }
+
+  It 'Should handle and return $false when roles are null' {
+    InModuleScope PSMDE {
+      Mock Get-MdeAuthorizationHeader { }
+      Mock Get-MdeAuthorizationInfo { return $null }
+      $warning = $( & Test-MdePermissions -functionName 'Get-MdeMachine' ) 3>&1
+      $warning.message | Should -Be 'No roles found, are you logged in?'
+      Should -Invoke Get-MdeAuthorizationInfo
+    }
+  }
 }