Merge branch 'fix/url_safety_net' of https://github.com/Zipstack/unstract into fix/url_safety_net

Author: gaya3-zipstack

backend/account_v2/templates/login.html

@@ -94,8 +94,7 @@
         .logo-box{
             width: 100%;
             text-align: center;
-            margin-bottom: 20px;
-            margin-top: 20px;
+            margin: 20px 0;
         }
         .login-heading{
             font-size: 24px;
@@ -109,9 +108,8 @@
             <!-- Spinner animation -->
             <div class="lds-dual-ring"></div>
         </div>
-        {% load static %}
         <div class="logo-box">
-            <img src="{% static 'logo.svg' %}" alt="My image">
+            <img src="/icons/logo.svg" alt="Unstract Logo">
         </div>
         <h2 class="login-heading">Login</h2>
         {% if error_message %}

backend/workflow_manager/endpoint_v2/destination.py

@@ -321,7 +321,7 @@ def copy_output_to_output_directory(self) -> None:
         except ConnectorError as e:
             raise UnstractFSException(core_err=e) from e
 
-    def insert_into_db(self, input_file_path: str, error: str | None) -> None:
+    def insert_into_db(self, input_file_path: str, error: str | None = None) -> None:
         """Insert data into the database."""
         connector_instance: ConnectorInstance = self.endpoint.connector_instance
         connector_settings: dict[str, Any] = connector_instance.connector_metadata
@@ -345,17 +345,19 @@ def insert_into_db(self, input_file_path: str, error: str | None) -> None:
             destination_configurations.get(DestinationKey.EXECUTION_ID, "execution_id")
         )
 
-        data = self.get_tool_execution_result()
+        data = self.get_tool_execution_result() if not error else None
         metadata = self.get_combined_metadata()
 
-        # If no data and no error, don't execute CREATE or INSERT query
         if not data and not error:
             logger.info("No data obtained from tool to insert into destination DB.")
             return
 
-        # Remove metadata from result
-        # Tool text-extractor returns data in the form of string.
-        # Don't pop out metadata in this case.
+        # Log when we're proceeding with error insertion
+        if error and not data:
+            logger.info(
+                f"Proceeding with error record insertion for {input_file_path}: {error}"
+            )
+
         if isinstance(data, dict):
             data.pop("metadata", None)
 

backend/backend/static/logo.svg renamed to frontend/public/icons/logo.svg

@@ -20,6 +20,7 @@ function PdfViewer({ fileUrl, highlightData, currentHighlightIndex }) {
   const pageNavigationPluginInstance = pageNavigationPlugin();
   const { jumpToPage } = pageNavigationPluginInstance;
   const parentRef = useRef(null);
+
   function removeZerosAndDeleteIfAllZero(highlightData) {
     if (Array.isArray(highlightData))
       return highlightData?.filter((innerArray) => {
@@ -36,27 +37,36 @@ function PdfViewer({ fileUrl, highlightData, currentHighlightIndex }) {
   const processedHighlightData =
     processHighlightData?.length > 0 ? processHighlightData : [[0, 0, 0, 0]];
 
-  const highlightPluginInstance = useMemo(() => {
+  // Determine current highlight data
+  const currentHighlightData = useMemo(() => {
     if (
       RenderHighlights &&
       Array.isArray(processedHighlightData) &&
       processedHighlightData?.length > 0
     ) {
-      // Only pass the current highlight to render
-      const currentHighlight =
-        currentHighlightIndex !== null &&
+      return currentHighlightIndex !== null &&
         currentHighlightIndex < processedHighlightData.length
-          ? [processedHighlightData[currentHighlightIndex]]
-          : processedHighlightData;
-
-      return highlightPlugin({
-        renderHighlights: (props) => (
-          <RenderHighlights {...props} highlightData={currentHighlight} />
-        ),
-      });
+        ? [processedHighlightData[currentHighlightIndex]]
+        : processedHighlightData;
     }
-    return "";
-  }, [RenderHighlights, processedHighlightData, currentHighlightIndex]);
+    return null;
+  }, [processedHighlightData, currentHighlightIndex]);
+
+  // Always create both plugins at top level to maintain hook order
+  const baseHighlightPlugin = highlightPlugin();
+  const customHighlightPlugin = highlightPlugin({
+    renderHighlights:
+      currentHighlightData && RenderHighlights
+        ? (props) => (
+            <RenderHighlights {...props} highlightData={currentHighlightData} />
+          )
+        : undefined,
+  });
+
+  // Choose which plugin to use
+  const highlightPluginInstance = currentHighlightData
+    ? customHighlightPlugin
+    : baseHighlightPlugin;
 
   // Jump to page when highlightData changes or when navigating through highlights
   useEffect(() => {