Skip to content

Commit 6ab4580

Browse files
committed
ARTEMIS-5346 fix bug exposed by new logic
1 parent 3ddac72 commit 6ab4580

File tree

1 file changed

+5
-3
lines changed
  • artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/amq

1 file changed

+5
-3
lines changed

artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/amq/AMQConsumer.java

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@
3535
import org.apache.activemq.artemis.api.core.ICoreMessage;
3636
import org.apache.activemq.artemis.api.core.Message;
3737
import org.apache.activemq.artemis.api.core.QueueConfiguration;
38+
import org.apache.activemq.artemis.api.core.RoutingType;
3839
import org.apache.activemq.artemis.api.core.SimpleString;
3940
import org.apache.activemq.artemis.core.client.impl.ClientConsumerImpl;
4041
import org.apache.activemq.artemis.core.protocol.openwire.OpenWireConstants;
@@ -215,6 +216,7 @@ private SimpleString createTopicSubscription(boolean isDurable,
215216
if (info.getDestination().isComposite()) {
216217
queueName = queueName.concat(physicalName);
217218
}
219+
QueueConfiguration queueConfiguration = QueueConfiguration.of(queueName).setAddress(address).setRoutingType(RoutingType.MULTICAST).setFilterString(selector).setInternal(internalAddress);
218220
QueueQueryResult result = session.getCoreSession().executeQueueQuery(queueName);
219221
if (result.isExists()) {
220222
// Already exists
@@ -235,10 +237,10 @@ private SimpleString createTopicSubscription(boolean isDurable,
235237
session.getCoreSession().deleteQueue(queueName);
236238

237239
// Create the new one
238-
session.getCoreSession().createQueue(QueueConfiguration.of(queueName).setAddress(address).setFilterString(selector).setInternal(internalAddress));
240+
session.getCoreSession().createQueue(queueConfiguration);
239241
}
240242
} else {
241-
session.getCoreSession().createQueue(QueueConfiguration.of(queueName).setAddress(address).setFilterString(selector).setInternal(internalAddress));
243+
session.getCoreSession().createQueue(queueConfiguration);
242244
}
243245
} else {
244246
// The consumer may be using FQQN in which case the queue might already exist.
@@ -251,7 +253,7 @@ private SimpleString createTopicSubscription(boolean isDurable,
251253
queueName = SimpleString.of(UUID.randomUUID().toString());
252254
}
253255

254-
session.getCoreSession().createQueue(QueueConfiguration.of(queueName).setAddress(address).setFilterString(selector).setDurable(false).setTemporary(true).setInternal(internalAddress));
256+
session.getCoreSession().createQueue(QueueConfiguration.of(queueName).setAddress(address).setRoutingType(RoutingType.MULTICAST).setFilterString(selector).setDurable(false).setTemporary(true).setInternal(internalAddress));
255257
}
256258

257259
return queueName;

0 commit comments

Comments
 (0)