Skip to content

Commit d3a33da

Browse files
jscheffljscheffl
authored
Generally do not force version_compat.py to have pytests (#52496)
1 parent 67613f0 commit d3a33da

File tree

1 file changed

+2
-45
lines changed

1 file changed

+2
-45
lines changed

‎airflow-core/tests/unit/always/test_project_structure.py

Lines changed: 2 additions & 45 deletions
Original file line numberDiff line numberDiff line change
@@ -61,8 +61,6 @@ def test_providers_modules_should_have_tests(self):
6161
# We should make sure that one goes to 0
6262
# TODO(potiuk) - check if that test actually tests something
6363
OVERLOOKED_TESTS = [
64-
"providers/airbyte/tests/unit/airbyte/test_version_compat.py",
65-
"providers/alibaba/tests/unit/alibaba/test_version_compat.py",
6664
"providers/amazon/tests/unit/amazon/aws/auth_manager/datamodels/test_login.py",
6765
"providers/amazon/tests/unit/amazon/aws/auth_manager/security_manager/test_aws_security_manager_override.py",
6866
"providers/amazon/tests/unit/amazon/aws/executors/batch/test_batch_executor_config.py",
@@ -84,26 +82,12 @@ def test_providers_modules_should_have_tests(self):
8482
"providers/amazon/tests/unit/amazon/aws/utils/test_rds.py",
8583
"providers/amazon/tests/unit/amazon/aws/utils/test_sagemaker.py",
8684
"providers/amazon/tests/unit/amazon/aws/waiters/test_base_waiter.py",
87-
"providers/amazon/tests/unit/amazon/test_version_compat.py",
88-
"providers/apache/cassandra/tests/unit/apache/cassandra/test_version_compat.py",
89-
"providers/apache/flink/tests/unit/apache/flink/test_version_compat.py",
90-
"providers/apache/hdfs/tests/unit/apache/hdfs/test_version_compat.py",
9185
"providers/apache/hdfs/tests/unit/apache/hdfs/hooks/test_hdfs.py",
9286
"providers/apache/hdfs/tests/unit/apache/hdfs/log/test_hdfs_task_handler.py",
9387
"providers/apache/hdfs/tests/unit/apache/hdfs/sensors/test_hdfs.py",
94-
"providers/apache/hive/tests/unit/apache/hive/test_version_compat.py",
9588
"providers/apache/hive/tests/unit/apache/hive/plugins/test_hive.py",
96-
"providers/apache/impala/tests/unit/apache/impala/test_version_compat.py",
97-
"providers/apache/livy/tests/unit/apache/livy/test_version_compat.py",
98-
"providers/apache/pig/tests/unit/apache/pig/test_version_compat.py",
99-
"providers/apache/spark/tests/unit/apache/spark/test_version_compat.py",
100-
"providers/apache/tinkerpop/tests/unit/apache/tinkerpop/test_version_compat.py",
101-
"providers/arangodb/tests/unit/arangodb/test_version_compat.py",
102-
"providers/asana/tests/unit/asana/test_version_compat.py",
103-
"providers/atlassian/jira/tests/unit/atlassian/jira/test_version_compat.py",
10489
"providers/celery/tests/unit/celery/executors/test_celery_executor_utils.py",
10590
"providers/celery/tests/unit/celery/executors/test_default_celery.py",
106-
"providers/celery/tests/unit/celery/test_version_compat.py",
10791
"providers/cloudant/tests/unit/cloudant/test_cloudant_fake.py",
10892
"providers/cncf/kubernetes/tests/unit/cncf/kubernetes/executors/test_kubernetes_executor_types.py",
10993
"providers/cncf/kubernetes/tests/unit/cncf/kubernetes/executors/test_kubernetes_executor_utils.py",
@@ -114,35 +98,25 @@ def test_providers_modules_should_have_tests(self):
11498
"providers/cncf/kubernetes/tests/unit/cncf/kubernetes/test_kube_config.py",
11599
"providers/cncf/kubernetes/tests/unit/cncf/kubernetes/test_python_kubernetes_script.py",
116100
"providers/cncf/kubernetes/tests/unit/cncf/kubernetes/test_secret.py",
117-
"providers/cncf/kubernetes/tests/unit/cncf/kubernetes/test_version_compat.py",
118101
"providers/cncf/kubernetes/tests/unit/cncf/kubernetes/triggers/test_kubernetes_pod.py",
119102
"providers/cncf/kubernetes/tests/unit/cncf/kubernetes/utils/test_delete_from.py",
120103
"providers/cncf/kubernetes/tests/unit/cncf/kubernetes/utils/test_k8s_hashlib_wrapper.py",
121104
"providers/cncf/kubernetes/tests/unit/cncf/kubernetes/utils/test_xcom_sidecar.py",
122-
"providers/common/sql/tests/unit/common/sql/test_version_compat.py",
123105
"providers/common/compat/tests/unit/common/compat/lineage/test_entities.py",
124106
"providers/common/compat/tests/unit/common/compat/standard/test_operators.py",
125107
"providers/common/compat/tests/unit/common/compat/standard/test_triggers.py",
126108
"providers/common/compat/tests/unit/common/compat/standard/test_utils.py",
127-
"providers/common/compat/tests/unit/common/compat/test_version_compat.py",
128-
"providers/common/io/tests/unit/common/io/test_version_compat.py",
129109
"providers/common/messaging/tests/unit/common/messaging/providers/test_base_provider.py",
130110
"providers/common/messaging/tests/unit/common/messaging/providers/test_sqs.py",
131-
"providers/datadog/tests/unit/datadog/test_version_compat.py",
132-
"providers/databricks/tests/unit/databricks/test_version_compat.py",
133-
"providers/dbt/cloud/tests/unit/dbt/cloud/test_version_compat.py",
134-
"providers/docker/tests/unit/docker/test_version_compat.py",
135111
"providers/edge3/tests/unit/edge3/models/test_edge_job.py",
136112
"providers/edge3/tests/unit/edge3/models/test_edge_logs.py",
137113
"providers/edge3/tests/unit/edge3/models/test_edge_worker.py",
138-
"providers/edge3/tests/unit/edge3/test_version_compat.py",
139114
"providers/edge3/tests/unit/edge3/worker_api/routes/test__v2_compat.py",
140115
"providers/edge3/tests/unit/edge3/worker_api/routes/test__v2_routes.py",
141116
"providers/edge3/tests/unit/edge3/worker_api/routes/test_jobs.py",
142117
"providers/edge3/tests/unit/edge3/worker_api/test_app.py",
143118
"providers/edge3/tests/unit/edge3/worker_api/test_auth.py",
144119
"providers/edge3/tests/unit/edge3/worker_api/test_datamodels.py",
145-
"providers/elasticsearch/tests/unit/elasticsearch/test_version_compat.py",
146120
"providers/fab/tests/unit/fab/auth_manager/api_fastapi/datamodels/test_login.py",
147121
"providers/fab/tests/unit/fab/migrations/test_env.py",
148122
"providers/fab/tests/unit/fab/www/api_connexion/test_exceptions.py",
@@ -165,8 +139,6 @@ def test_providers_modules_should_have_tests(self):
165139
"providers/fab/tests/unit/fab/www/test_session.py",
166140
"providers/fab/tests/unit/fab/www/test_utils.py",
167141
"providers/fab/tests/unit/fab/www/test_views.py",
168-
"providers/ftp/tests/unit/ftp/test_version_compat.py",
169-
"providers/github/tests/unit/github/test_version_compat.py",
170142
"providers/google/tests/unit/google/cloud/fs/test_gcs.py",
171143
"providers/google/tests/unit/google/cloud/links/test_automl.py",
172144
"providers/google/tests/unit/google/cloud/links/test_base.py",
@@ -215,34 +187,17 @@ def test_providers_modules_should_have_tests(self):
215187
"providers/google/tests/unit/google/common/test_consts.py",
216188
"providers/google/tests/unit/google/common/hooks/test_operation_helpers.py",
217189
"providers/google/tests/unit/google/test_go_module_utils.py",
218-
"providers/google/tests/unit/google/test_version_compat.py",
219-
"providers/http/tests/unit/http/test_version_compat.py",
220190
"providers/http/tests/unit/http/test_exceptions.py",
221-
"providers/imap/tests/unit/imap/test_version_compat.py",
222-
"providers/jenkins/tests/unit/jenkins/test_version_compat.py",
223191
"providers/keycloak/tests/unit/keycloak/auth_manager/datamodels/test_token.py",
224-
"providers/mongo/tests/unit/mongo/test_version_compat.py",
225192
"providers/microsoft/azure/tests/unit/microsoft/azure/operators/test_adls.py",
226-
"providers/microsoft/azure/tests/unit/microsoft/azure/test_version_compat.py",
227-
"providers/openlineage/tests/unit/openlineage/test_version_compat.py",
228-
"providers/opensearch/tests/unit/opensearch/test_version_compat.py",
229-
"providers/oracle/tests/unit/oracle/test_version_compat.py",
230-
"providers/presto/tests/unit/presto/test_version_compat.py",
231-
"providers/redis/tests/unit/redis/test_version_compat.py",
232-
"providers/sftp/tests/unit/sftp/test_version_compat.py",
233-
"providers/snowflake/tests/unit/snowflake/test_version_compat.py",
234193
"providers/snowflake/tests/unit/snowflake/triggers/test_snowflake_trigger.py",
235194
"providers/standard/tests/unit/standard/operators/test_branch.py",
236195
"providers/standard/tests/unit/standard/operators/test_empty.py",
237196
"providers/standard/tests/unit/standard/operators/test_latest_only.py",
238197
"providers/standard/tests/unit/standard/operators/test_trigger_dagrun.py",
239198
"providers/standard/tests/unit/standard/sensors/test_external_task.py",
240199
"providers/standard/tests/unit/standard/sensors/test_filesystem.py",
241-
"providers/standard/tests/unit/standard/test_version_compat.py",
242200
"providers/standard/tests/unit/standard/utils/test_sensor_helper.py",
243-
"providers/tableau/tests/unit/tableau/test_version_compat.py",
244-
"providers/trino/tests/unit/trino/test_version_compat.py",
245-
"providers/weaviate/tests/unit/weaviate/test_version_compat.py",
246201
]
247202
modules_files: list[pathlib.Path] = list(
248203
AIRFLOW_PROVIDERS_ROOT_PATH.glob("**/src/airflow/providers/**/*.py")
@@ -274,6 +229,8 @@ def test_providers_modules_should_have_tests(self):
274229
current_test_files = set(f for f in current_test_files if not f.name == "__init__.py")
275230
# Exclude node_modules
276231
current_test_files = set(f for f in current_test_files if "node_modules" not in f.parts)
232+
# Exclude version_compat.py
233+
modules_files = filter(lambda f: f.name != "version_compat.py", modules_files)
277234

278235
modules_files_set = set(modules_files)
279236
expected_test_files = set(

0 commit comments

Comments
 (0)