From 6ae615ad5cc7af870490731f96f98ace4467571c Mon Sep 17 00:00:00 2001 From: Ankit Chaurasia <8670962+sunank200@users.noreply.github.com> Date: Tue, 24 Jun 2025 22:24:33 +0545 Subject: [PATCH] remove pytest db_test marker where unnecessary --- .../fab/auth_manager/api/auth/backend/test_basic_auth.py | 1 - .../unit/fab/auth_manager/api/auth/backend/test_session.py | 1 - .../unit/fab/auth_manager/api_fastapi/routes/test_login.py | 3 --- .../unit/fab/auth_manager/api_fastapi/services/test_login.py | 1 - .../tests/unit/fab/auth_manager/cli_commands/test_utils.py | 2 -- .../fab/tests/unit/fab/auth_manager/test_fab_auth_manager.py | 5 ----- 6 files changed, 13 deletions(-) diff --git a/providers/fab/tests/unit/fab/auth_manager/api/auth/backend/test_basic_auth.py b/providers/fab/tests/unit/fab/auth_manager/api/auth/backend/test_basic_auth.py index 845e601a947e9..b48b33a4fc2fd 100644 --- a/providers/fab/tests/unit/fab/auth_manager/api/auth/backend/test_basic_auth.py +++ b/providers/fab/tests/unit/fab/auth_manager/api/auth/backend/test_basic_auth.py @@ -59,7 +59,6 @@ def function_decorated(): mock_call() -@pytest.mark.db_test class TestBasicAuth: def setup_method(self) -> None: mock_call.reset_mock() diff --git a/providers/fab/tests/unit/fab/auth_manager/api/auth/backend/test_session.py b/providers/fab/tests/unit/fab/auth_manager/api/auth/backend/test_session.py index 296edd11b7bc9..2d8b1fec909a8 100644 --- a/providers/fab/tests/unit/fab/auth_manager/api/auth/backend/test_session.py +++ b/providers/fab/tests/unit/fab/auth_manager/api/auth/backend/test_session.py @@ -38,7 +38,6 @@ def function_decorated(): mock_call() -@pytest.mark.db_test class TestSessionAuth: def setup_method(self) -> None: mock_call.reset_mock() diff --git a/providers/fab/tests/unit/fab/auth_manager/api_fastapi/routes/test_login.py b/providers/fab/tests/unit/fab/auth_manager/api_fastapi/routes/test_login.py index b596e76f5d9da..aaf53d6af209e 100644 --- a/providers/fab/tests/unit/fab/auth_manager/api_fastapi/routes/test_login.py +++ b/providers/fab/tests/unit/fab/auth_manager/api_fastapi/routes/test_login.py @@ -19,12 +19,9 @@ from unittest.mock import patch -import pytest - from airflow.providers.fab.auth_manager.api_fastapi.datamodels.login import LoginBody, LoginResponse -@pytest.mark.db_test class TestLogin: dummy_login_body = LoginBody(username="dummy", password="dummy") dummy_token = LoginResponse(access_token="DUMMY_TOKEN") diff --git a/providers/fab/tests/unit/fab/auth_manager/api_fastapi/services/test_login.py b/providers/fab/tests/unit/fab/auth_manager/api_fastapi/services/test_login.py index 5014177fe0ef6..89dfd3e1ca481 100644 --- a/providers/fab/tests/unit/fab/auth_manager/api_fastapi/services/test_login.py +++ b/providers/fab/tests/unit/fab/auth_manager/api_fastapi/services/test_login.py @@ -29,7 +29,6 @@ from airflow.providers.fab.auth_manager.api_fastapi.datamodels.login import LoginResponse -@pytest.mark.db_test @patch("airflow.providers.fab.auth_manager.api_fastapi.services.login.get_auth_manager") class TestLogin: def setup_method( diff --git a/providers/fab/tests/unit/fab/auth_manager/cli_commands/test_utils.py b/providers/fab/tests/unit/fab/auth_manager/cli_commands/test_utils.py index 4cb7485cf1c07..262ecd0477765 100644 --- a/providers/fab/tests/unit/fab/auth_manager/cli_commands/test_utils.py +++ b/providers/fab/tests/unit/fab/auth_manager/cli_commands/test_utils.py @@ -32,8 +32,6 @@ with ignore_provider_compatibility_error("2.9.0+", __file__): from airflow.providers.fab.auth_manager.cli_commands.utils import get_application_builder -pytestmark = pytest.mark.db_test - @pytest.fixture def flask_app(): diff --git a/providers/fab/tests/unit/fab/auth_manager/test_fab_auth_manager.py b/providers/fab/tests/unit/fab/auth_manager/test_fab_auth_manager.py index b4d99b6928409..69f3cedf26da9 100644 --- a/providers/fab/tests/unit/fab/auth_manager/test_fab_auth_manager.py +++ b/providers/fab/tests/unit/fab/auth_manager/test_fab_auth_manager.py @@ -154,7 +154,6 @@ def test_serialize_user(self, flask_app, auth_manager_with_appbuilder): result = auth_manager_with_appbuilder.serialize_user(user) assert result == {"sub": str(user.id)} - @pytest.mark.db_test @mock.patch.object(FabAuthManager, "get_user") def test_is_logged_in(self, mock_get_user, auth_manager_with_appbuilder): user = Mock() @@ -163,7 +162,6 @@ def test_is_logged_in(self, mock_get_user, auth_manager_with_appbuilder): assert auth_manager_with_appbuilder.is_logged_in() is False - @pytest.mark.db_test @mock.patch.object(FabAuthManager, "get_user") def test_is_logged_in_with_inactive_user(self, mock_get_user, auth_manager_with_appbuilder): user = Mock() @@ -690,11 +688,9 @@ def test_get_authorized_dag_ids( delete_user(flask_app, "username") - @pytest.mark.db_test def test_security_manager_return_fab_security_manager_override(self, auth_manager_with_appbuilder): assert isinstance(auth_manager_with_appbuilder.security_manager, FabAirflowSecurityManagerOverride) - @pytest.mark.db_test def test_security_manager_return_custom_provided(self, flask_app, auth_manager_with_appbuilder): class TestSecurityManager(FabAirflowSecurityManagerOverride): pass @@ -702,7 +698,6 @@ class TestSecurityManager(FabAirflowSecurityManagerOverride): flask_app.config["SECURITY_MANAGER_CLASS"] = TestSecurityManager assert isinstance(auth_manager_with_appbuilder.security_manager, TestSecurityManager) - @pytest.mark.db_test def test_security_manager_wrong_inheritance_raise_exception( self, flask_app, auth_manager_with_appbuilder ):