add ecr test

Author: tomoyamachi

extractor/docker/token/ecr/ecr.go

@@ -46,7 +46,7 @@ func getSession(option types.DockerOption) (*session.Session, error) {
 
 func (e *ECR) CheckOptions(domain string, option types.DockerOption) error {
 	if !strings.HasSuffix(domain, ecrURL) {
-		return xerrors.New("invalid ECR url pattern")
+		return xerrors.Errorf("ECR : %w", types.InvalidURLPattern)
 	}
 	sess := session.Must(getSession(option))
 	svc := ecr.New(sess)

extractor/docker/token/ecr/ecr_test.go

@@ -4,13 +4,45 @@ import (
 	"context"
 	"testing"
 
+	"github.com/knqyf263/fanal/types"
+	"golang.org/x/xerrors"
+
 	"github.com/aws/aws-sdk-go/aws/request"
 
 	"github.com/aws/aws-sdk-go/aws"
 	"github.com/aws/aws-sdk-go/service/ecr"
 	"github.com/aws/aws-sdk-go/service/ecr/ecriface"
 )
 
+func TestCheckOptions(t *testing.T) {
+	var tests = map[string]struct {
+		domain  string
+		opt     types.DockerOption
+		wantErr error
+	}{
+		"InvalidURL": {
+			domain:  "alpine:3.9",
+			opt:     types.DockerOption{},
+			wantErr: types.InvalidURLPattern,
+		},
+		"NoOption": {
+			domain: "xxx.ecr.ap-northeast-1.amazonaws.com",
+			opt:    types.DockerOption{},
+		},
+	}
+
+	for testname, v := range tests {
+		a := &ECR{}
+		err := a.CheckOptions(v.domain, v.opt)
+		if err != nil {
+			if !xerrors.Is(err, v.wantErr) {
+				t.Errorf("[%s]\nexpected error based on %v\nactual : %v", testname, v.wantErr, err)
+			}
+			continue
+		}
+	}
+}
+
 type mockedECR struct {
 	ecriface.ECRAPI
 	Resp ecr.GetAuthorizationTokenOutput

extractor/docker/token/gcr/gcr_test.go

@@ -36,8 +36,8 @@ func TestCheckOptions(t *testing.T) {
 	}
 
 	for testname, v := range tests {
-		a := &GCR{}
-		err := a.CheckOptions(v.domain, v.opt)
+		g := &GCR{}
+		err := g.CheckOptions(v.domain, v.opt)
 		if v.wantErr != nil {
 			if err == nil {
 				t.Errorf("%s : expected error but no error", testname)
@@ -48,8 +48,8 @@ func TestCheckOptions(t *testing.T) {
 			}
 			continue
 		}
-		if !reflect.DeepEqual(v.gcr, a) {
-			t.Errorf("[%s]\nexpected : %v\nactual : %v", testname, v.gcr, a)
+		if !reflect.DeepEqual(v.gcr, g) {
+			t.Errorf("[%s]\nexpected : %v\nactual : %v", testname, v.gcr, g)
 		}
 	}
 }