Bug fix: wrap nil err (fanal#37)

knqyf263 · web-flow · commit 4a9f3d9aa9f5 · 2019-09-25T14:11:35.000+03:00
diff --git a/analyzer/analyzer.go b/analyzer/analyzer.go
@@ -164,8 +164,10 @@ func GetPackages(filesMap extractor.FileMap) ([]Package, error) {
 		// Differentiate between a package manager not being found and another error
 		if err != nil && err == ErrNoPkgsDetected {
 			continue
+		} else if err != nil {
+			return nil, xerrors.Errorf("failed to analyze packages: %w", err)
 		}
-		return pkgs, xerrors.Errorf("failed to analyze packages: %w", err)
+		return pkgs, nil
 	}
 	return nil, ErrPkgAnalysis
 }

Original file line number	Diff line number	Diff line change
`@@ -164,8 +164,10 @@ func GetPackages(filesMap extractor.FileMap) ([]Package, error) {`
`164`	`164`	`// Differentiate between a package manager not being found and another error`
`165`	`165`	`if err != nil && err == ErrNoPkgsDetected {`
`166`	`166`	`continue`
	`167`	`+ } else if err != nil {`
	`168`	`+ return nil, xerrors.Errorf("failed to analyze packages: %w", err)`
`167`	`169`	`}`
`168`		`- return pkgs, xerrors.Errorf("failed to analyze packages: %w", err)`
	`170`	`+ return pkgs, nil`
`169`	`171`	`}`
`170`	`172`	`return nil, ErrPkgAnalysis`
`171`	`173`	`}`