fix: k8s escape resource filename

Signed-off-by: chenk <[email protected]>

Author: chen-keinan

pkg/k8s/scanner/io.go

@@ -3,8 +3,8 @@ package scanner
 import (
 	"fmt"
 	"os"
+	"regexp"
 	"runtime"
-	"strings"
 
 	"golang.org/x/xerrors"
 	"gopkg.in/yaml.v3"
@@ -18,8 +18,8 @@ func createTempFile(artifact *artifacts.Artifact) (string, error) {
 	filename := fmt.Sprintf("%s-%s-%s-*.yaml", artifact.Namespace, artifact.Kind, artifact.Name)
 
 	if runtime.GOOS == "windows" {
-		//sanitize file name to removed unsupported char on windows os
-		filename = strings.ReplaceAll(filename, ":", "-")
+		//removes characters not permitted in file/directory names on Windows
+		filename = filenameWindowsFriendly(filename)
 	}
 	file, err := os.CreateTemp("", filename)
 	if err != nil {
@@ -44,3 +44,9 @@ func removeFile(filename string) {
 		log.Logger.Errorf("failed to remove temp file %s: %s:", filename, err)
 	}
 }
+
+var r, _ = regexp.Compile("\\\\|/|:|\\*|\\?|<|>")
+
+func filenameWindowsFriendly(name string) string {
+	return r.ReplaceAllString(name, "_")
+}

pkg/k8s/scanner/io_test.go

@@ -0,0 +1,34 @@
+package scanner
+
+import (
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+)
+
+func Test_FilenameWindowsFriendly(t *testing.T) {
+
+	tests := []struct {
+		name     string
+		fileName string
+		want     string
+	}{
+		{
+			name:     "name with invalid char - colon",
+			fileName: `kube-system-Role-system:controller:bootstrap-signer-2934213283.yaml`,
+			want:     `kube-system-Role-system_controller_bootstrap-signer-2934213283.yaml`,
+		},
+		{
+			name:     "name with no invalid chars",
+			fileName: `kube-system-Role-system-controller-bootstrap-signer-2934213283.yaml`,
+			want:     `kube-system-Role-system-controller-bootstrap-signer-2934213283.yaml`,
+		},
+	}
+
+	for _, test := range tests {
+		t.Run(test.name, func(t *testing.T) {
+			got := filenameWindowsFriendly(test.fileName)
+			assert.Equal(t, test.want, got)
+		})
+	}
+}