chore: enable stringXbytes rule from go-critic

mmorel-35 · mmorel-35 · commit 87eccea2dfd7 · 2025-08-18T08:26:23.000+02:00
Signed-off-by: Matthieu MOREL &lt;matthieu.morel35@gmail.com&gt;
diff --git a/.golangci.yaml b/.golangci.yaml
@@ -26,7 +26,6 @@ linters:
         - importShadow
         - paramTypeCombine
         - rangeValCopy
-        - stringXbytes
         - typeSwitchVar
         - unnamedResult
         - whyNoLint
diff --git a/pkg/diff/diff.go b/pkg/diff/diff.go
@@ -473,7 +473,7 @@ func normalizeTypedValue(tv *typed.TypedValue) ([]byte, error) {
 
 func buildDiffResult(predictedBytes []byte, liveBytes []byte) *DiffResult {
 	return &DiffResult{
-		Modified:       string(liveBytes) != string(predictedBytes),
+		Modified:       !bytes.Equal(liveBytes, predictedBytes),
 		NormalizedLive: liveBytes,
 		PredictedLive:  predictedBytes,
 	}

Original file line number	Diff line number	Diff line change
`@@ -473,7 +473,7 @@ func normalizeTypedValue(tv *typed.TypedValue) ([]byte, error) {`
`473`	`473`
`474`	`474`	`func buildDiffResult(predictedBytes []byte, liveBytes []byte) *DiffResult {`
`475`	`475`	`return &DiffResult{`
`476`		`- Modified: string(liveBytes) != string(predictedBytes),`
	`476`	`+ Modified: !bytes.Equal(liveBytes, predictedBytes),`
`477`	`477`	`NormalizedLive: liveBytes,`
`478`	`478`	`PredictedLive: predictedBytes,`
`479`	`479`	`}`