Skip to content

Commit fbc8b23

Browse files
authored
Meetings fix (#835)
* fixed incorrect meeting times on catalog and enumerated by meeting on scheduler * single meeting assumption fix
1 parent ab485ae commit fbc8b23

File tree

6 files changed

+35
-33
lines changed

6 files changed

+35
-33
lines changed

apps/frontend/src/app/Schedule/Editor/SideBar/Class/Section/index.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,8 @@ export default function Section({
2222
number,
2323
meetings,
2424
}: SectionProps & ISection) {
25-
const meeting = meetings.length > 0 ? meetings[0] : null;
26-
return (
25+
const meetingsAdjusted = meetings.length > 0 ? meetings : [null];
26+
return meetingsAdjusted.map((meeting) => (
2727
<div
2828
className={classNames(styles.root, {
2929
[styles.active]: active,
@@ -44,5 +44,5 @@ export default function Section({
4444
className={styles.time}
4545
/>
4646
</div>
47-
);
47+
));
4848
}

apps/frontend/src/app/Schedule/Week/index.tsx

Lines changed: 19 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -100,23 +100,25 @@ export default function Week({
100100

101101
const relevantSections = sections
102102
// Filter sections for the current day which have a time specified
103-
.filter(
104-
(section) =>
105-
section.meetings.length > 0 &&
106-
section.meetings[0].days[day] &&
107-
section.meetings[0].startTime &&
108-
getY(section.meetings[0].startTime) > 0
109-
)
110-
.map(
111-
(section) =>
112-
({
113-
section,
114-
startTime: section.meetings[0].startTime,
115-
endTime: section.meetings[0].endTime,
116-
days: section.meetings[0].days,
117-
id: section.sectionId,
118-
type: "section",
119-
}) as ScheduleEvent
103+
.flatMap((section) =>
104+
section.meetings
105+
.filter(
106+
(meeting) =>
107+
meeting.days[day] &&
108+
meeting.startTime &&
109+
getY(meeting.startTime) > 0
110+
)
111+
.map(
112+
(meeting) =>
113+
({
114+
section,
115+
startTime: meeting.startTime,
116+
endTime: meeting.endTime,
117+
days: meeting.days,
118+
id: section.sectionId,
119+
type: "section",
120+
}) as ScheduleEvent
121+
)
120122
);
121123

122124
const relevantEventsAndSections = [

apps/frontend/src/components/Class/Overview/index.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,9 @@ export default function Overview() {
1212
<Box p="5">
1313
<Container size="3">
1414
<Flex direction="column" gap="5">
15-
<Details {..._class.primarySection.meetings[0]} />
15+
{_class.primarySection.meetings.map((meeting, i) => (
16+
<Details {...meeting} key={i} />
17+
))}
1618
<Flex direction="column" gap="2">
1719
<p className={styles.label}>Description</p>
1820
<p className={styles.description}>

apps/frontend/src/components/Class/Sections/index.tsx

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -149,13 +149,9 @@ export default function Sections() {
149149
</a>
150150
</Tooltip>
151151
</div>
152-
<Details
153-
days={section.meetings[0].days}
154-
startTime={section.meetings[0].startTime}
155-
endTime={section.meetings[0].endTime}
156-
location={section.meetings[0].location}
157-
instructors={section.meetings[0].instructors}
158-
/>
152+
{section.meetings.map((meeting, i) => (
153+
<Details {...meeting} key={i} />
154+
))}
159155
</div>
160156
))}
161157
</div>

apps/frontend/src/components/ClassCard/index.tsx

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -82,10 +82,12 @@ export default function ClassCard({
8282
</Card.Footer>
8383
</Card.Body>
8484
<Card.Actions>
85-
<AverageGrade
86-
gradeDistribution={gradeDistribution}
87-
style={{ marginTop: 0.5, fontSize: 15 }}
88-
/>
85+
{gradeDistribution && (
86+
<AverageGrade
87+
gradeDistribution={gradeDistribution}
88+
style={{ marginTop: 0.5, fontSize: 15 }}
89+
/>
90+
)}
8991
{bookmarked && bookmarkToggle && (
9092
<Card.ActionIcon onClick={bookmarkToggle}>
9193
{bookmarked ? (

apps/frontend/src/components/Time/index.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ export default function Time({
7575
.reduce(
7676
(time, day, index) =>
7777
day
78-
? [...time, ["Su", "M", "Tu", "W", "Th", "F", "Sa"][index]]
78+
? [...time, ["M", "Tu", "W", "Th", "F", "Sa", "Su"][index]]
7979
: time,
8080
[] as string[]
8181
)

0 commit comments

Comments
 (0)