Skip to content

Commit 0bac401

Browse files
larochjdoug-walker
authored andcommitted
Review Fix, ChannelCrosstalk
1 parent 2a96167 commit 0bac401

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

src/OpenColorIO/ops/gradinghuecurve/GradingHueCurveOpData.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ class GradingHueCurveOpData : public OpData
3939
bool isNoOp() const override;
4040
bool isIdentity() const override;
4141

42-
bool hasChannelCrosstalk() const override { return false; }
42+
bool hasChannelCrosstalk() const override { return true; }
4343

4444
bool isInverse(ConstGradingHueCurveOpDataRcPtr & r) const;
4545
GradingHueCurveOpDataRcPtr inverse() const;

tests/cpu/ops/gradinghuecurve/GradingHueCurveOpData_tests.cpp

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88

99
namespace OCIO = OCIO_NAMESPACE;
1010

11+
// Test coming from GradingRGBCurveOpData_tests.cpp
1112
OCIO_ADD_TEST(GradingHueCurveOpData, accessors)
1213
{
1314
// Create GradingHueCurveOpData and check values. Changes them and check.
@@ -30,7 +31,7 @@ OCIO_ADD_TEST(GradingHueCurveOpData, accessors)
3031
OCIO_CHECK_ASSERT(curves->isIdentity());
3132
OCIO_CHECK_ASSERT(gc.isIdentity());
3233
OCIO_CHECK_ASSERT(gc.isNoOp());
33-
OCIO_CHECK_ASSERT(!gc.hasChannelCrosstalk());
34+
OCIO_CHECK_ASSERT(gc.hasChannelCrosstalk());
3435
OCIO_CHECK_ASSERT(!gc.getBypassLinToLog());
3536

3637
gc.setStyle(OCIO::GRADING_LIN);
@@ -91,7 +92,7 @@ OCIO_ADD_TEST(GradingHueCurveOpData, accessors)
9192
OCIO_CHECK_ASSERT(!gc1.slopesAreDefault(OCIO::HUE_SAT));
9293

9394
OCIO_CHECK_EQUAL(gc1.isIdentity(), false);
94-
OCIO_CHECK_ASSERT(!gc1.hasChannelCrosstalk());
95+
OCIO_CHECK_ASSERT(gc1.hasChannelCrosstalk());
9596

9697
// Check isInverse.
9798

0 commit comments

Comments
 (0)