Added EventBridgePutEventsPolicy template #1409
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It doesn’t look as though this overcomes the blockers described in the previous attempt to add such a policy. |
jlhood
suggested changes
Jan 23, 2020
jmnarloch
force-pushed
the
eventbridge-policy
branch
from
d5a0fac to
257ee3e
Compare
jmnarloch
force-pushed
the
eventbridge-policy
branch
from
257ee3e to
5e11259
Compare
|
I had updated the pull request. Changes made added EventBus name as parameter and I removed the policy on PutPartnerEvents. |
Codecov Report
@@ Coverage Diff @@
## develop #1409 +/- ##
========================================
Coverage 94.37% 94.37%
========================================
Files 78 78
Lines 4678 4678
Branches 934 934
========================================
Hits 4415 4415
Misses 121 121
Partials 142 142Continue to review full report at Codecov.
|
jlhood
approved these changes
Feb 11, 2020
keetonian
approved these changes
Feb 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes: Adds a dedicated template policy for EventBridge granting the permissions to publish events to EventBus either custom ones or partner events.
Description of how you validated changes: Unit tests for transformed had been added to validate that the additional policy had been output.
Checklist:
make prpassesexamples/2016-10-31By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.