Skip to content

Conversation

keetonian
Copy link
Contributor

@keetonian keetonian commented Mar 4, 2020

Issue #, if available:
#1451

Description of changes:
Support RouteSettings at multiple levels.

Description of how you validated changes:
Deployed templates to verify changes.

Checklist:

  • Write/update tests
  • make pr passes
  • Update documentation
  • Verify transformed template deploys and application functions as expected
  • Add/update example to examples/2016-10-31

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@praneetap praneetap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also add it to globals documentation.

@codecov-io
Copy link

Codecov Report

Merging #1490 into develop will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1490      +/-   ##
===========================================
+ Coverage     94.1%   94.13%   +0.03%     
===========================================
  Files           78       78              
  Lines         4900     4926      +26     
  Branches       988      991       +3     
===========================================
+ Hits          4611     4637      +26     
  Misses         134      134              
  Partials       155      155
Impacted Files Coverage Δ
samtranslator/model/eventsources/push.py 90.78% <ø> (ø) ⬆️
samtranslator/plugins/globals/globals.py 99.05% <ø> (ø) ⬆️
samtranslator/model/sam_resources.py 94.29% <ø> (ø) ⬆️
samtranslator/model/apigatewayv2.py 94.73% <ø> (ø) ⬆️
samtranslator/plugins/api/implicit_api_plugin.py 98.24% <100%> (+0.01%) ⬆️
...translator/plugins/api/implicit_http_api_plugin.py 97.43% <100%> (+0.94%) ⬆️
...translator/plugins/api/implicit_rest_api_plugin.py 100% <100%> (ø) ⬆️
samtranslator/model/api/http_api_generator.py 92.27% <100%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef92c3f...08dfcde. Read the comment docs.

@keetonian keetonian changed the title Stage route settings feat: support RouteSettings for HttpApi Mar 5, 2020
@ShreyaGangishetty ShreyaGangishetty merged commit 7b229d9 into aws:develop Mar 5, 2020
@keetonian keetonian deleted the stage-route-settings branch March 11, 2020 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants