Skip to content

Commit cbb41e0

Browse files
committed
workflows: improve shell quoting
As it stands, the architecture and the container are not user-controllable and do not presently contain spaces or other shell metacharacters, so there's no security or functionality problems by leaving the relevant environment variables unquoted. However, it's a good practice to quote these variables just in case, so let's do that.
1 parent 182368f commit cbb41e0

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

.github/workflows/ci.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -205,11 +205,11 @@ jobs:
205205
docker version -f '{{.Server.Experimental}}'
206206
- uses: docker/setup-qemu-action@v3
207207
- run: git clone https://github.com/git-lfs/build-dockers.git "$HOME/build-dockers"
208-
- run: (cd "$HOME/build-dockers" && ./build_dockers.bsh --arch=$ARCH $CONTAINER)
208+
- run: (cd "$HOME/build-dockers" && ./build_dockers.bsh --arch="$ARCH" "$CONTAINER")
209209
env:
210210
ARCH: ${{matrix.arch}}
211211
CONTAINER: ${{matrix.container}}
212-
- run: ./docker/run_dockers.bsh --prune --arch=$ARCH $CONTAINER
212+
- run: ./docker/run_dockers.bsh --prune --arch="$ARCH" "$CONTAINER"
213213
env:
214214
ARCH: ${{matrix.arch}}
215215
CONTAINER: ${{matrix.container}}

.github/workflows/release.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -208,11 +208,11 @@ jobs:
208208
docker version -f '{{.Server.Experimental}}'
209209
- uses: docker/setup-qemu-action@v3
210210
- run: git clone https://github.com/git-lfs/build-dockers.git "$HOME/build-dockers"
211-
- run: (cd "$HOME/build-dockers" && ./build_dockers.bsh --arch=$ARCH $CONTAINER)
211+
- run: (cd "$HOME/build-dockers" && ./build_dockers.bsh --arch="$ARCH" "$CONTAINER")
212212
env:
213213
ARCH: ${{matrix.arch}}
214214
CONTAINER: ${{matrix.container}}
215-
- run: ./docker/run_dockers.bsh --prune --arch=$ARCH $CONTAINER
215+
- run: ./docker/run_dockers.bsh --prune --arch="$ARCH" "$CONTAINER"
216216
env:
217217
ARCH: ${{matrix.arch}}
218218
CONTAINER: ${{matrix.container}}

0 commit comments

Comments
 (0)