Skip to content

Commit 3d9d9d0

Browse files
feat(router): Added unit tests for routerDisabled version.
1 parent 70adf55 commit 3d9d9d0

File tree

4 files changed

+960
-191
lines changed

4 files changed

+960
-191
lines changed

src/elements/common/types/SidebarNavigation.js.flow

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,14 +10,14 @@ export const ViewType = Object.freeze({
1010
METADATA_REDESIGN: 'metadata_redesign',
1111
SKILLS: 'skills',
1212
ACTIVITY: 'activity',
13-
VERSIONS: 'versions',
1413
DOCGEN: 'docgen',
1514
});
1615

1716
export const FeedEntryType = Object.freeze({
1817
ANNOTATIONS: 'annotations',
1918
COMMENTS: 'comments',
2019
TASKS: 'tasks',
20+
VERSIONS: 'versions',
2121
});
2222

2323
export type ViewTypeValues = $Values<typeof ViewType>;
@@ -34,6 +34,7 @@ export type SidebarNavigation = {
3434

3535
export type InternalSidebarNavigation = SidebarNavigation & {
3636
open?: boolean,
37+
silent?: boolean,
3738
};
3839

3940
export type SidebarNavigationHandler = (sidebar: SidebarNavigation, replace?: boolean) => void;

src/elements/common/types/SidebarNavigation.ts

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,24 +5,25 @@ export enum ViewType {
55
METADATA_REDESIGN = 'metadata_redesign',
66
BOXAI = 'boxai',
77
ACTIVITY = 'activity',
8-
VERSIONS = 'versions',
98
DOCGEN = 'docgen',
109
}
1110

1211
export enum FeedEntryType {
1312
ANNOTATIONS = 'annotations',
1413
COMMENTS = 'comments',
1514
TASKS = 'tasks',
15+
VERSIONS = 'versions',
1616
}
1717

1818
type VersionSidebarView = {
1919
sidebar: ViewType.ACTIVITY | ViewType.DETAILS;
20-
versionId: string;
20+
activeFeedEntryType: FeedEntryType.VERSIONS;
21+
versionId?: string;
2122
};
2223

2324
export type MetadataSidebarView = {
2425
sidebar: ViewType.METADATA | ViewType.METADATA_REDESIGN;
25-
filteredTemplateIds?: string[];
26+
filteredTemplateIds: string[];
2627
};
2728

2829
export type ActivityAnnotationsSidebarView = {
@@ -48,6 +49,7 @@ export type SidebarNavigation =
4849

4950
export type InternalSidebarNavigation = SidebarNavigation & {
5051
open?: boolean;
52+
silent?: boolean;
5153
};
5254

5355
export type SidebarNavigationHandler = (sidebar: SidebarNavigation, replace?: boolean) => void;

0 commit comments

Comments
 (0)