fix: PR nits

Author: jlandisBox

src/common/types/metadata.js

@@ -101,7 +101,7 @@ type MetadataCascadingPolicyData = {
     id?: string,
     isEnabled: boolean,
     overwrite: boolean,
-    cascadePolicyConfiguration?: MetadataCascadePolicyConfiguration | null,
+    cascadePolicyConfiguration: MetadataCascadePolicyConfiguration | null,
 };
 
 type MetadataInstance = {

src/features/metadata-instance-editor/CascadePolicy.js

@@ -18,6 +18,7 @@ import Link from '../../components/link/Link';
 import IconAlertDefault from '../../icons/general/IconAlertDefault';
 import messages from './messages';
 import './CascadePolicy.scss';
+import { STANDARD_AGENT_ID, ENHANCED_AGENT_ID } from './constants';
 
 const COMMUNITY_LINK = 'https://support.box.com/hc/en-us/articles/360044195873-Cascading-metadata-in-folders';
 const AI_LINK = 'https://www.box.com/ai';
@@ -64,12 +65,12 @@ const CascadePolicy = ({
     const agents = React.useMemo(
         () => [
             {
-                id: '1',
+                id: STANDARD_AGENT_ID,
                 name: formatMessage(messages.standardAgentName),
                 isEnterpriseDefault: true,
             },
             {
-                id: '2',
+                id: ENHANCED_AGENT_ID,
                 name: formatMessage(messages.enhancedAgentName),
                 isEnterpriseDefault: false,
                 customIcon: BoxAiAdvancedColor,

src/features/metadata-instance-editor/Instance.js

@@ -25,7 +25,12 @@ import MetadataInstanceConfirmDialog from './MetadataInstanceConfirmDialog';
 import Footer from './Footer';
 import messages from './messages';
 import { FIELD_TYPE_FLOAT, FIELD_TYPE_INTEGER } from '../metadata-instance-fields/constants';
-import { CASCADE_POLICY_TYPE_AI_EXTRACT, TEMPLATE_CUSTOM_PROPERTIES, ENHANCED_AGENT_CONFIGURATION } from './constants';
+import {
+    CASCADE_POLICY_TYPE_AI_EXTRACT,
+    TEMPLATE_CUSTOM_PROPERTIES,
+    ENHANCED_AGENT_CONFIGURATION,
+    ENHANCED_AGENT_ID,
+} from './constants';
 import {
     JSON_PATCH_OP_REMOVE,
     JSON_PATCH_OP_ADD,
@@ -71,10 +76,10 @@ type Props = {
 };
 
 type State = {
+    cascadePolicyConfiguration: MetadataCascadePolicyConfiguration | null,
     data: Object,
     errors: { [string]: React.Node },
     isAIFolderExtractionEnabled: boolean,
-    cascadePolicyConfiguration?: MetadataCascadePolicyConfiguration | null,
     isBusy: boolean,
     isCascadingEnabled: boolean,
     isCascadingOverwritten: boolean,
@@ -215,12 +220,12 @@ class Instance extends React.PureComponent<Props, State> {
             onSave,
         }: Props = this.props;
         const {
+            cascadePolicyConfiguration,
             data: currentData,
             errors,
             isAIFolderExtractionEnabled,
             isCascadingEnabled,
             isCascadingOverwritten,
-            cascadePolicyConfiguration,
         }: State = this.state;
 
         if (!this.isEditing() || !isDirty || !onSave || Object.keys(errors).length) {
@@ -354,7 +359,7 @@ class Instance extends React.PureComponent<Props, State> {
      */
     onAIAgentSelect = (agent: AgentType | null): void => {
         // '2' is the id for the enhanced agent
-        if (agent && agent.id === '2') {
+        if (agent && agent.id === ENHANCED_AGENT_ID) {
             this.setState({
                 cascadePolicyConfiguration: {
                     agent: ENHANCED_AGENT_CONFIGURATION,
@@ -374,10 +379,10 @@ class Instance extends React.PureComponent<Props, State> {
         const isCascadingEnabled = this.isCascadingEnabledThroughProps(props);
 
         return {
+            cascadePolicyConfiguration: null,
             data: cloneDeep(props.data),
             errors: {},
             isAIFolderExtractionEnabled: this.isAIFolderExtractionEnabledThroughProps(props),
-            cascadePolicyConfiguration: null,
             isBusy: false,
             isCascadingEnabled,
             isCascadingOverwritten: false,
@@ -705,10 +710,10 @@ class Instance extends React.PureComponent<Props, State> {
                                             isCascadingOverwritten={isCascadingOverwritten}
                                             isCustomMetadata={isProperties}
                                             isExistingCascadePolicy={isExistingCascadePolicy}
+                                            onAIAgentSelect={this.onAIAgentSelect}
                                             onAIFolderExtractionToggle={this.onAIFolderExtractionToggle}
                                             onCascadeModeChange={this.onCascadeModeChange}
                                             onCascadeToggle={this.onCascadeToggle}
-                                            onAIAgentSelect={this.onAIAgentSelect}
                                             shouldShowCascadeOptions={shouldShowCascadeOptions}
                                         />
                                     )}

src/features/metadata-instance-editor/__tests__/MetadataInstanceEditor.test.js

@@ -4,7 +4,6 @@ import { render, screen } from '../../../test-utils/testing-library';
 
 import MetadataInstanceEditor from '../MetadataInstanceEditor';
 import Instances from '../Instances';
-import { CASCADE_POLICY_TYPE_AI_EXTRACT } from '../constants';
 
 // Templates
 
@@ -541,7 +540,7 @@ describe('MetadataInstanceEditor - canUseAIFolderExtractionAgentSelector prop',
             canUseAIFolderExtraction: true,
             canUseAIFolderExtractionAgentSelector: true,
         });
-        props.editors[0].instance.cascadePolicy.cascadePolicyType = CASCADE_POLICY_TYPE_AI_EXTRACT;
+        props.editors[0].instance.cascadePolicy.cascadePolicyType = 'ai_extract';
         render(<MetadataInstanceEditor {...props} />);
 
         const editButton = await screen.findByRole('button', { name: 'Edit Metadata' }, { timeout: 3000 });
@@ -587,7 +586,7 @@ describe('MetadataInstanceEditor - canUseAIFolderExtractionAgentSelector prop',
             canUseAIFolderExtraction: true,
             canUseAIFolderExtractionAgentSelector: true,
         });
-        props.editors[0].instance.cascadePolicy.cascadePolicyType = CASCADE_POLICY_TYPE_AI_EXTRACT;
+        props.editors[0].instance.cascadePolicy.cascadePolicyType = 'ai_extract';
         props.editors[0].instance.cascadePolicy.id = null;
 
         render(<MetadataInstanceEditor {...props} />);

src/features/metadata-instance-editor/constants.js

@@ -3,5 +3,13 @@
 const CASCADE_POLICY_TYPE_AI_EXTRACT = 'ai_extract';
 const TEMPLATE_CUSTOM_PROPERTIES: 'properties' = 'properties';
 const ENHANCED_AGENT_CONFIGURATION = 'enhanced_extract_agent';
+const STANDARD_AGENT_ID = '1';
+const ENHANCED_AGENT_ID = '2';
 
-export { CASCADE_POLICY_TYPE_AI_EXTRACT, TEMPLATE_CUSTOM_PROPERTIES, ENHANCED_AGENT_CONFIGURATION };
+export {
+    CASCADE_POLICY_TYPE_AI_EXTRACT,
+    TEMPLATE_CUSTOM_PROPERTIES,
+    ENHANCED_AGENT_CONFIGURATION,
+    STANDARD_AGENT_ID,
+    ENHANCED_AGENT_ID,
+};