fix: Resource Status Comparison (#112)

This fix allows for complex status objects.

Author: erin-allison

src/KubeOps/Operator/Caching/ResourceCache.cs

@@ -77,7 +77,7 @@ private CacheComparisonResult CompareCache(TEntity resource)
                 return CacheComparisonResult.NotModified;
             }
 
-            if (comparison.Differences.All(d => d.ParentPropertyName == Status))
+            if (comparison.Differences.All(d => d.PropertyName.Split('.')[0] == Status))
             {
                 return CacheComparisonResult.StatusModified;
             }

tests/KubeOps.Test/Operator/Caching/ResourceCache.Test.cs

@@ -1,4 +1,5 @@
-using System.Collections.Generic;
+using System;
+using System.Collections.Generic;
 using FluentAssertions;
 using k8s.Models;
 using KubeOps.Operator;
@@ -135,6 +136,58 @@ public void Should_Remove_Object()
                     CacheComparisonResult.StatusModified,
                 },
                 new object?[]
+                {
+                    new TestStatusEntity
+                    {
+                        Metadata = new V1ObjectMeta { Uid = "test" },
+                        Status = new TestStatusEntityStatus { StatusString = "status" },
+                    },
+                    new TestStatusEntity
+                    {
+                        Metadata = new V1ObjectMeta { Uid = "test" },
+#pragma warning disable 8625
+                        Status = null,
+#pragma warning restore 8625
+                    },
+                    CacheComparisonResult.StatusModified,
+                },
+                new object?[]
+                {
+                    new TestStatusEntity
+                    {
+                        Metadata = new V1ObjectMeta { Uid = "test" },
+                        Status = new TestStatusEntityStatus
+                        {
+                            StatusString = "status",
+                            StatusList = new List<ComplexStatusObject>()
+                            {
+                                new ComplexStatusObject()
+                                {
+                                    ObjectName = "status",
+                                    LastModified = DateTime.Parse("2020-01-01")
+                                }
+                            }
+                        },
+                    },
+                    new TestStatusEntity
+                    {
+                        Metadata = new V1ObjectMeta { Uid = "test" },
+                        Status = new TestStatusEntityStatus
+                        {
+                            StatusString = "status",
+                            StatusList = new List<ComplexStatusObject>()
+                            {
+                                new ComplexStatusObject()
+                                {
+                                    ObjectName = "status",
+                                    LastModified = DateTime.Parse("2020-01-02")
+                                }
+                            }
+                        },
+                    },
+                    CacheComparisonResult.StatusModified,
+                },
+                new object?[]
                 {
                     new TestStatusEntity
                     {

tests/KubeOps.Test/TestEntities/TestStatusEntity.cs

@@ -1,4 +1,6 @@
-using k8s.Models;
+using System;
+using System.Collections.Generic;
+using k8s.Models;
 using KubeOps.Operator.Entities;
 
 namespace KubeOps.Test.TestEntities
@@ -11,6 +13,13 @@ public class TestStatusEntitySpec
     public class TestStatusEntityStatus
     {
         public string StatusString { get; set; } = string.Empty;
+        public List<ComplexStatusObject> StatusList { get; set; } = new List<ComplexStatusObject>();
+    }
+
+    public class ComplexStatusObject
+    {
+        public string ObjectName { get; set; } = string.Empty;
+        public DateTime LastModified { get; set; }
     }
 
     [KubernetesEntity(Group = "kubeops.test.dev", ApiVersion = "V1")]