Skip to content

Commit 8221e91

Browse files
committed
t/t-clone.sh: remove test skip checks for libnss3
In commit e4e5ada of PR git-lfs#5882 we added an initial check to the t/t-clone.sh test script which detects whether libcurl is linked against the legacy libnss3 library on Linux, and if so, sets a GIT_LIBNSS variable. We then check that variable at the start of several tests in the script, and if it is set, skip performing the tests. This workaround was introduced because the libnss3 library rejects TLS/SSL certificates which have both an Extended Key Usage attribute for TLS Web Server Authentication and a Basic Constraint setting of "CA:TRUE", and the self-signed certificate used by our lfstest-gitserver utility program has both attributes, so our tests would otherwise fail. The only platform on which our tests run which used the legacy libnss3 library was the one based on Red Hat Enterprise Linux (RHEL) 7. All the distribution versions based on RHEL 7, CentOS 7, and SUSE Linux Enterprise Server (SLES) 12 for which we previously built RPM packages have now reached the end of their standard LTS (Long-Term Support) periods, and so future releases of the Git LFS client will no longer build packages for them. We therefore removed the Dockerfile we used to build packages for the RHEL/CentOS 7 and SLES 12 platforms in commit git-lfs/build-dockers@cfde130 of PR git-lfs/build-dockers#71. As well, in a prior commit in this PR we removed the entries for these platforms from the list of our supported Linux distribution versions in the DistroMap Ruby class source file, which is utilized by several scripts run by our GitHub Actions CI and release workflow jobs. Since our CI and release workflows will no longer run on any platforms where libcurl is linked against the legacy libnss3 library, we can now also remove the checks for the libnss3 library from our t/t-clone.sh test script.
1 parent ba2b392 commit 8221e91

File tree

1 file changed

+0
-22
lines changed

1 file changed

+0
-22
lines changed

t/t-clone.sh

Lines changed: 0 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -4,13 +4,6 @@
44

55
ensure_git_version_isnt $VERSION_LOWER "2.2.0"
66

7-
# Check for a libnss3 dependency in Git until we drop support for CentOS 7.
8-
GIT_LIBNSS=0
9-
if [ "$IS_WINDOWS" -eq 0 -a "$IS_MAC" -eq 0 ]; then
10-
GIT_LIBNSS="$(ldd "$(git --exec-path)"/git-remote-https | grep -c '^\s*libnss3\.' || true)"
11-
fi
12-
export GIT_LIBNSS
13-
147
export CREDSDIR="$REMOTEDIR/creds-clone"
158
setup_creds
169

@@ -121,11 +114,6 @@ begin_test "cloneSSL"
121114
(
122115
set -e
123116

124-
if [ "$GIT_LIBNSS" -eq 1 ]; then
125-
echo "skip: libnss does not support the Go httptest server certificate"
126-
exit 0
127-
fi
128-
129117
if [ "$IS_WINDOWS" -eq 1 ]; then
130118
git config --global "http.sslBackend" "openssl"
131119
fi
@@ -205,11 +193,6 @@ begin_test "clone ClientCert"
205193
(
206194
set -e
207195

208-
if [ "$GIT_LIBNSS" -eq 1 ]; then
209-
echo "skip: libnss does not support the Go httptest server certificate"
210-
exit 0
211-
fi
212-
213196
if [ "$IS_WINDOWS" -eq 1 ]; then
214197
git config --global "http.sslBackend" "openssl"
215198
fi
@@ -330,11 +313,6 @@ begin_test "clone ClientCert with homedir certs"
330313
(
331314
set -e
332315

333-
if [ "$GIT_LIBNSS" -eq 1 ]; then
334-
echo "skip: libnss does not support the Go httptest server certificate"
335-
exit 0
336-
fi
337-
338316
if [ "$IS_WINDOWS" -eq 1 ]; then
339317
git config --global "http.sslBackend" "openssl"
340318
fi

0 commit comments

Comments
 (0)