t/t-clone.sh: assert clean status when appropriate

In commit caaa0f9 of PR git-lfs#2647 a
number of tests of the "git lfs clone" and "git lfs pull" commands
were enhanced so as to check that after those commands are invoked,
the "git status" command returns a "working tree clean" message.
To perform these checks, a call to our assert_clean_status()
shell function was added to the tests.

In the case of the "cloneSSL" test, an assert_clean_status() call
was added, but left commented out; it was then uncommented in commit
e0eede1 of the same PR.  Unfortunately,
the call is made when the current working directory has not yet been
changed to that of the newly cloned repository's working tree, and
so should fail as it stands now.

However, as described in git-lfs#5658, the "cloneSSL" test and the "clone
ClientCert" tests in our t/t-clone.sh test script do not actually
run to completion, a consequence of an improper check of the TRAVIS
variable (which is no longer used since we migrated our test suite to
GitHub Actions in PR git-lfs#3808).  Instead, the tests exit early and
always declare success.

We will address this problem in a subsequent commit in this PR, and when
we do so, the "cloneSSL" test will fail because the misplaced assertion.
Therefore we move the assertion into the block of checks performed
after a "pushd" shell command changes the current directory to that
of the new clone's working tree, which will allow the test to pass
when we resolve the bug with the TRAVIS variable check.

We also take the opportunity to add assert_clean_status() calls to a
number of other tests in the t/t-clone.sh test script, so the tests are
all performing similar sets of checks.  This will help us keep the
tests in that script more consistent with each other in the future.

Author: chrisd8088

t/t-clone.sh

@@ -143,7 +143,6 @@ begin_test "cloneSSL"
 
   newclonedir="testcloneSSL1"
   git lfs clone "$SSLGITSERVER/$reponame" "$newclonedir" 2>&1 | tee lfsclone.log
-  assert_clean_status
   grep "Cloning into" lfsclone.log
   grep "Downloading LFS objects:" lfsclone.log
   # should be no filter errors
@@ -158,6 +157,7 @@ begin_test "cloneSSL"
   [ $(wc -c < "file2.dat") -eq 75 ]
   [ $(wc -c < "file3.dat") -eq 30 ]
   assert_hooks "$(dot_git_dir)"
+  assert_clean_status
   popd
 
 
@@ -369,6 +369,7 @@ begin_test "clone with flags"
   # confirm remote is called differentorigin
   git remote get-url differentorigin
   assert_hooks "$(dot_git_dir)"
+  assert_clean_status
   popd
   rm -rf "$newclonedir"
 
@@ -382,6 +383,9 @@ begin_test "clone with flags"
   [ -e "$newclonedir/.git" ]
   [ -d "$gitdir/objects" ]
   assert_hooks "$gitdir"
+  pushd "$newclonedir"
+    assert_clean_status
+  popd
   rm -rf "$newclonedir"
   rm -rf "$gitdir"
 
@@ -443,6 +447,7 @@ begin_test "clone (with include/exclude args)"
   [ "$(pointer $contents_a_oid 1)" = "$(cat dupe-a.dat)" ]
   [ "$(pointer $contents_b_oid 1)" = "$(cat b.dat)" ]
   assert_hooks "$(dot_git_dir)"
+  assert_clean_status
   popd
 
   local_reponame="clone_with_excludes"
@@ -453,6 +458,7 @@ begin_test "clone (with include/exclude args)"
   [ "$(pointer $contents_a_oid 1)" = "$(cat a.dat)" ]
   [ "b" = "$(cat b.dat)" ]
   assert_hooks "$(dot_git_dir)"
+  assert_clean_status
   popd
 )
 end_test
@@ -515,6 +521,7 @@ begin_test "clone (with .lfsconfig)"
   assert_local_object "$contents_a_oid" 1
   refute_local_object "$contents_b_oid"
   assert_hooks "$(dot_git_dir)"
+  assert_clean_status
   popd
 
   echo "test: clone with lfs.fetchinclude in .lfsconfig, and args"
@@ -524,6 +531,7 @@ begin_test "clone (with .lfsconfig)"
   refute_local_object "$contents_a_oid"
   assert_local_object "$contents_b_oid" 1
   assert_hooks "$(dot_git_dir)"
+  assert_clean_status
   popd
 
   popd
@@ -547,6 +555,7 @@ begin_test "clone (with .lfsconfig)"
   assert_local_object "$contents_b_oid" 1
   refute_local_object "$contents_a_oid"
   assert_hooks "$(dot_git_dir)"
+  assert_clean_status
   popd
 
   echo "test: clone with lfs.fetchexclude in .lfsconfig, and args"
@@ -556,6 +565,7 @@ begin_test "clone (with .lfsconfig)"
   assert_local_object "$contents_a_oid" 1
   refute_local_object "$contents_b_oid"
   assert_hooks "$(dot_git_dir)"
+  assert_clean_status
   popd
 
   popd
@@ -669,6 +679,7 @@ begin_test "clone with submodules"
   # check everything is where it should be
   cd $local_reponame
   assert_hooks "$(dot_git_dir)"
+  assert_clean_status
   # check LFS store and working copy
   assert_local_object "$contents_root_oid" "${#contents_root}"
   [ $(wc -c < "root.dat") -eq ${#contents_root} ]
@@ -720,6 +731,7 @@ begin_test "clone in current directory"
     assert_local_object "$contents_oid" 8
     assert_hooks "$(dot_git_dir)"
     [ ! -f ./lfs ]
+    assert_clean_status
   popd
 )
 end_test