.github/workflows: upgrade to ruby/setup-ruby@v1

As the actions/setup-ruby GitHub Action is deprecated in favour of
the ruby/setup-ruby Action, we upgrade to use the latter in our CI and
release workflows.

In the Windows builds, the ruby/setup-ruby@v1 Action installs the MSYS2
build tools and sets some environment variables which persist for
subsequent steps in the workflow, such as the TMPDIR variable.

These differences from the actions/setup-ruby Action introduce failures
into our test suite, principally by causing Actions to run the Bash shell
in C:\msys64\usr\bin instead of the one in C:\Program Files\Git\bin, which
in turn results in the "git" command running the git.exe binary found in
C:\Program Files\Git\bin instead of C:\Program Files\Git\mingw64\bin.

The Git binary in C:\Program Files\Git\bin, when asked to run a "git lfs"
command, then finds the git-lfs.exe binary in C:\Program Files\Git\cmd
instead of the one we have built, despite our changing the PATH
environment variable so that our built git-lfs.exe binary should be
found first.

We resolve this problem by renaming the C:\msys64 directory with a
temporary name after installing the asciidoctor Ruby gem.

Also note that we do not need to specify the Bash shell to run the
"gem install acsiidoctor" step, and that we move this step below the
ruby/setup-ruby@v1 step in all cases so as to make the dependency
more clear.  (We also move the "gem install packagecloud-ruby" step
into the same relative location, for the same reason.)

The ruby/setup-ruby@v1 Action also sets the TMPDIR environment variable
for all subsequent steps, and this results in other test suite failures
on Windows because we create paths for our temporary test repositories
in our GIT_LFS_TEST_DIR path, which we set using mktemp(1), and that
derives its defaut path from TMPDIR.  However, some of our test helper
programs such as lfstest-customadapter use the Go language ioutil.TempFile()
function to construct paths, which calls os.TempDir(), and on Windows
that does not refer to the TMPDIR environment variable but the TMP and
TEMP ones instead.

The consequence is that tests using those helper programs try to
move files between directories creating using both techniques of
temporary path creation, and these return paths on different volumes,
so the test fails when trying to move files between D:\a\_temp
and C:\Users\RUNNER~1\AppData\Local\Temp.

Therefore we take care to unset the TMPDIR variable before running
commands which might make use of mktemp(1).

h/t MSP-Greg for the suggestion to rename C:\msys64

Author: chrisd8088

.github/workflows/ci.yml

@@ -11,7 +11,8 @@ jobs:
     runs-on: ${{ matrix.os }}
     steps:
     - uses: actions/checkout@v1
-    - uses: actions/setup-ruby@v1
+    - uses: ruby/setup-ruby@v1
+    - run: gem install asciidoctor
     - uses: actions/setup-go@v2
       with:
         go-version: ${{ matrix.go }}
@@ -21,7 +22,6 @@ jobs:
       if: ${{ startsWith(matrix.os, 'ubuntu-') }}
       env:
           DEBIAN_FRONTEND: noninteractive
-    - run: gem install asciidoctor
     - run: script/cibuild
       env:
           FORCE_LOCALIZE: true
@@ -51,7 +51,9 @@ jobs:
     runs-on: windows-latest
     steps:
     - uses: actions/checkout@v1
-    - uses: actions/setup-ruby@v1
+    - uses: ruby/setup-ruby@v1
+    - run: gem install asciidoctor
+    - run: Rename-Item -Path C:\msys64 -NewName msys64-tmp -Force
     - uses: actions/setup-go@v2
       with:
         go-version: '1.19.x'
@@ -61,13 +63,11 @@ jobs:
     - run: cinst InnoSetup -y
     - run: cinst strawberryperl -y
     - run: refreshenv
-    - run: gem install asciidoctor
-      shell: bash
     - run: make man
       shell: bash
     - run: GOPATH="$HOME/go" PATH="$HOME/go/bin:$PATH" go install github.com/josephspurrier/goversioninfo/cmd/goversioninfo@latest
       shell: bash
-    - run: GOPATH="$HOME/go" PATH="$HOME/go/bin:$PATH" script/cibuild
+    - run: GOPATH="$HOME/go" PATH="$HOME/go/bin:$PATH" env -u TMPDIR script/cibuild
       shell: bash
     - run: rm -f commands/mancontent_gen.go
       shell: bash
@@ -126,7 +126,7 @@ jobs:
     runs-on: ubuntu-20.04
     steps:
     - uses: actions/checkout@v1
-    - uses: actions/setup-ruby@v1
+    - uses: ruby/setup-ruby@v1
     - run: git clone https://github.com/git-lfs/build-dockers.git "$HOME/build-dockers"
     - run: (cd "$HOME/build-dockers" && ./build_dockers.bsh)
     - run: ./docker/run_dockers.bsh --prune
@@ -139,7 +139,7 @@ jobs:
         container: [debian_11]
     steps:
     - uses: actions/checkout@v1
-    - uses: actions/setup-ruby@v1
+    - uses: ruby/setup-ruby@v1
     - run: |
         echo '{"experimental": true}' | sudo tee /etc/docker/daemon.json
         sudo systemctl restart docker.service

.github/workflows/release.yml

@@ -12,7 +12,9 @@ jobs:
         go: ['1.19.x']
     steps:
     - uses: actions/checkout@v1
-    - uses: actions/setup-ruby@v1
+    - uses: ruby/setup-ruby@v1
+    - run: gem install asciidoctor
+    - run: Rename-Item -Path C:\msys64 -NewName msys64-tmp -Force
     - uses: actions/setup-go@v2
       with:
         go-version: ${{ matrix.go }}
@@ -23,34 +25,33 @@ jobs:
     - run: cinst strawberryperl -y
     - run: cinst zip -y
     - run: cinst jq -y
-    - run: gem install asciidoctor
     - run: refreshenv
     - run: GOPATH="$HOME/go" PATH="$HOME/go/bin:$PATH" go install github.com/josephspurrier/goversioninfo/cmd/goversioninfo@latest
       shell: bash
     - run: mkdir -p bin/releases
       shell: bash
-    - run: CERT_FILE="$HOME/cert.pfx" make release-write-certificate
+    - run: CERT_FILE="$HOME/cert.pfx" env -u TMPDIR make release-write-certificate
       shell: bash
       env:
         CERT_CONTENTS: ${{secrets.WINDOWS_CERT_BASE64}}
-    - run: PATH="$HOME/go/bin:$PATH" GOARCH=amd64 go generate && make bin/releases/git-lfs-windows-amd64-$(git describe).zip
+    - run: PATH="$HOME/go/bin:$PATH" GOARCH=amd64 go generate && env -u TMPDIR make bin/releases/git-lfs-windows-amd64-$(git describe).zip
       shell: bash
       env:
         FORCE_LOCALIZE: true
-    - run: PATH="$HOME/go/bin:$PATH" GOARCH=386 go generate && make bin/releases/git-lfs-windows-386-$(git describe).zip
+    - run: PATH="$HOME/go/bin:$PATH" GOARCH=386 go generate && env -u TMPDIR make bin/releases/git-lfs-windows-386-$(git describe).zip
       shell: bash
       env:
         FORCE_LOCALIZE: true
-    - run: PATH="$HOME/go/bin:$PATH" GOARCH=arm64 go generate && make bin/releases/git-lfs-windows-arm64-$(git describe).zip
+    - run: PATH="$HOME/go/bin:$PATH" GOARCH=arm64 go generate && env -u TMPDIR make bin/releases/git-lfs-windows-arm64-$(git describe).zip
       shell: bash
       env:
         FORCE_LOCALIZE: true
-    - run: PATH="$HOME/go/bin:/c/Program Files (x86)/Windows Kits/10/bin/10.0.17763.0/x86:$PATH" CERT_FILE="$HOME/cert.pfx" make release-windows
+    - run: PATH="$HOME/go/bin:/c/Program Files (x86)/Windows Kits/10/bin/10.0.17763.0/x86:$PATH" CERT_FILE="$HOME/cert.pfx" env -u TMPDIR make release-windows
       shell: bash
       env:
         CERT_PASS: ${{secrets.WINDOWS_CERT_PASS}}
         FORCE_LOCALIZE: true
-    - run: make release-windows-rebuild
+    - run: env -u TMPDIR make release-windows-rebuild
       shell: bash
     - uses: actions/upload-artifact@v1
       with:
@@ -64,13 +65,13 @@ jobs:
         go: ['1.19.x']
     steps:
     - uses: actions/checkout@v1
-    - uses: actions/setup-ruby@v1
+    - uses: ruby/setup-ruby@v1
+    - run: gem install asciidoctor
     - uses: actions/setup-go@v2
       with:
         go-version: ${{ matrix.go }}
     - run: brew install gettext
     - run: brew install mitchellh/gon/gon
-    - run: gem install asciidoctor
     - run: make release
       env:
           FORCE_LOCALIZE: true
@@ -100,7 +101,8 @@ jobs:
         go: ['1.19.x']
     steps:
     - uses: actions/checkout@v1
-    - uses: actions/setup-ruby@v1
+    - uses: ruby/setup-ruby@v1
+    - run: gem install asciidoctor
     - uses: actions/setup-go@v2
       with:
         go-version: ${{ matrix.go }}
@@ -113,7 +115,6 @@ jobs:
     - uses: actions/download-artifact@v1
       with:
         name: macos-assets
-    - run: gem install asciidoctor
     - run: CGO_ENABLED=0 make release
     - run: rm -f bin/releases/*windows* bin/releases/*darwin*
     - run: 'find windows-assets -name "*windows*" -type f | xargs -L1 -I{} mv {} bin/releases'
@@ -126,7 +127,7 @@ jobs:
     runs-on: ubuntu-20.04
     steps:
     - uses: actions/checkout@v1
-    - uses: actions/setup-ruby@v1
+    - uses: ruby/setup-ruby@v1
     - run: gem install packagecloud-ruby
     - run: git clone https://github.com/git-lfs/build-dockers.git "$HOME/build-dockers"
     - run: (cd "$HOME/build-dockers" && ./build_dockers.bsh)
@@ -144,13 +145,13 @@ jobs:
         container: [debian_11]
     steps:
     - uses: actions/checkout@v1
-    - uses: actions/setup-ruby@v1
+    - uses: ruby/setup-ruby@v1
+    - run: gem install packagecloud-ruby
     - run: |
         echo '{"experimental": true}' | sudo tee /etc/docker/daemon.json
         sudo systemctl restart docker.service
         docker version -f '{{.Server.Experimental}}'
     - uses: docker/setup-qemu-action@v1
-    - run: gem install packagecloud-ruby
     - run: git clone https://github.com/git-lfs/build-dockers.git "$HOME/build-dockers"
     - run: (cd "$HOME/build-dockers" && ./build_dockers.bsh --arch=$ARCH $CONTAINER)
       env:

.ruby-version

@@ -0,0 +1 @@
+3.1.2