From 7a6c715a491860811517ef039cc6de79b84a0e5f Mon Sep 17 00:00:00 2001 From: Evan Anderson Date: Thu, 4 Sep 2025 14:49:56 -0700 Subject: [PATCH 1/3] Add sandbox reviewer guide based on conversation in 2025-09-03 project reviews subproject meeting Signed-off-by: Evan Anderson --- .../sandbox-review-guide.md | 40 +++++++++++++++++++ 1 file changed, 40 insertions(+) create mode 100644 toc_subprojects/project-reviews-subproject/sandbox-review-guide.md diff --git a/toc_subprojects/project-reviews-subproject/sandbox-review-guide.md b/toc_subprojects/project-reviews-subproject/sandbox-review-guide.md new file mode 100644 index 000000000..a58d287f4 --- /dev/null +++ b/toc_subprojects/project-reviews-subproject/sandbox-review-guide.md @@ -0,0 +1,40 @@ +# Sandbox Reviewer Guide + +> Note! This is a living document, and is written in a somewhat informal style. + + +This document aims to record best practices (and the reasoning behind them) for CNCF sandbox application reviewers. This advice is intended to help streamline project reviews, **but it is not binding**. Use your best judgement when applying this advice, and feel free to ignore or adjust it for specific circumstances. + +## Overview + +Lots of projects apply to the CNCF Sandbox. They hope to gain a number of benefits from CNCF membership, including: visibility, neutral governance and IP ownership, access to CNCF expertise, and probably even more. The TOC approves Sandbox applications using the [sandbox process][sandbox]; the goal of sandbox reviews _is to provide the information the TOC needs to make [a status decision][sandbox-status]. + +To that end, the primary output of the review process is a fair assessment of the project's [general technical foundations][gtr]. Because the bar for sandbox is intentionally low, only the "Day 0" questions need to be filled out. + +Additionally, sandbox reviewers should check the general sandbox application answers, and [flag any concerns for the project and TOC to address](#other-application-concerns). + +### Recommended GTR Process: + +If the project has already completed the [General Technical Questions][gtr], this process can be simplified to reviewing the project's answers, rather than generating a new technical review document. + +If the project has not completed the technical questionnaire, copy the [General Technical Questions document][gtr] into a _new_ https://notes.cncf.io/ document for sharing with co-reviewers or the project. Note that only the "Day 0" contents are required for sandbox applications. + +Iterate on the questionnaire answers until you and any co-reviewer are satisfied that the questionnaire is complete. If you need information or clarification from the project, prefer public written (best!) or recorded (e.g. TAG presentation) formats over private channels such as DMs or 1:1 video meetings. Maintaining public channels makes it easier for interested participants and onlookers to understand and engage with the process, and fosters transparency. + +When the questionnaire is complete, _COPY_ all of the https://notes.cncf.io contents into a **comment** on the sandbox application issue. + +> Why _copy_ the contents back and forth between notes.cncf.io, the issue, and an eventual file in the `cncf/toc` repo? We're attempting to balance the following: +> +> * Only commit content to the `cncf/toc` repo for projects which have been accepted into the CNCF, to avoid confusion. +> * Make it easy to find (e.g. search) for previous applications, either for returning applications, or for related work. +> * The CNCF notes documents have access control which makes implementing search very difficult. They are useful for collaborative editing, but make it difficult to reference and index the contents later. +> * Preserve the record of decisions in a way that is clear and transparent to all participants, including those viewing the results in the future. + +### Other Application Concerns + +When reviewing a donation from a corporate entity which also intends to sell some portion of the service, ensure that the issue makes clear which code (preferably, as entire repositories) **will** and **will not** be donated. See [this comment](https://github.com/cncf/sandbox/issues/392#issuecomment-3173237281) for an example of such a clarification. + + +[sandbox]: https://github.com/cncf/sandbox +[sandbox-status]: https://github.com/cncf/sandbox/blob/main/README.md#the-tocs-sandbox-review-meeting +[gtr]: ./general-technical-questions.md \ No newline at end of file From 453d72b5d948aa97ced2a5790fef0e7172af8828 Mon Sep 17 00:00:00 2001 From: Evan Anderson Date: Sat, 6 Sep 2025 14:21:20 -0700 Subject: [PATCH 2/3] Update toc_subprojects/project-reviews-subproject/sandbox-review-guide.md Co-authored-by: Mario Signed-off-by: Evan Anderson --- .../project-reviews-subproject/sandbox-review-guide.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/toc_subprojects/project-reviews-subproject/sandbox-review-guide.md b/toc_subprojects/project-reviews-subproject/sandbox-review-guide.md index a58d287f4..054dc9083 100644 --- a/toc_subprojects/project-reviews-subproject/sandbox-review-guide.md +++ b/toc_subprojects/project-reviews-subproject/sandbox-review-guide.md @@ -19,7 +19,7 @@ If the project has already completed the [General Technical Questions][gtr], thi If the project has not completed the technical questionnaire, copy the [General Technical Questions document][gtr] into a _new_ https://notes.cncf.io/ document for sharing with co-reviewers or the project. Note that only the "Day 0" contents are required for sandbox applications. -Iterate on the questionnaire answers until you and any co-reviewer are satisfied that the questionnaire is complete. If you need information or clarification from the project, prefer public written (best!) or recorded (e.g. TAG presentation) formats over private channels such as DMs or 1:1 video meetings. Maintaining public channels makes it easier for interested participants and onlookers to understand and engage with the process, and fosters transparency. +Iterate on the questionnaire answers until you and any co-reviewer are satisfied that the questionnaire is complete. If you need information or clarification from the project, prefer public written in the application Issue (best!) or recorded (e.g. TAG presentation) formats over private channels such as DMs or 1:1 video meetings. Maintaining public channels makes it easier for interested participants and onlookers to understand and engage with the process, and fosters transparency. When the questionnaire is complete, _COPY_ all of the https://notes.cncf.io contents into a **comment** on the sandbox application issue. From bde61ce06db13b439e807f843b2360f1991eb5a0 Mon Sep 17 00:00:00 2001 From: Evan Anderson Date: Sat, 6 Sep 2025 14:21:42 -0700 Subject: [PATCH 3/3] Update toc_subprojects/project-reviews-subproject/sandbox-review-guide.md Co-authored-by: Mario Signed-off-by: Evan Anderson --- .../project-reviews-subproject/sandbox-review-guide.md | 1 + 1 file changed, 1 insertion(+) diff --git a/toc_subprojects/project-reviews-subproject/sandbox-review-guide.md b/toc_subprojects/project-reviews-subproject/sandbox-review-guide.md index 054dc9083..e586a323a 100644 --- a/toc_subprojects/project-reviews-subproject/sandbox-review-guide.md +++ b/toc_subprojects/project-reviews-subproject/sandbox-review-guide.md @@ -34,6 +34,7 @@ When the questionnaire is complete, _COPY_ all of the https://notes.cncf.io cont When reviewing a donation from a corporate entity which also intends to sell some portion of the service, ensure that the issue makes clear which code (preferably, as entire repositories) **will** and **will not** be donated. See [this comment](https://github.com/cncf/sandbox/issues/392#issuecomment-3173237281) for an example of such a clarification. +Keep also an eye on Gouvernance and potential license concerns, as Sandbox applications will not cover a full gouvernance review. Some examples could be, amount of *active* maintainers. Name violations or usages by other projects of commercials tools. Maintainership concerns when it comes to code contribution. [sandbox]: https://github.com/cncf/sandbox [sandbox-status]: https://github.com/cncf/sandbox/blob/main/README.md#the-tocs-sandbox-review-meeting