Skip to content

Commit 149b6ab

Browse files
committed
Fix incorrect use of NoLanes in executionContext check (facebook#33170)
## Summary This PR fixes a likely incorrect condition in the `scheduleUpdateOnFiber` function inside `ReactFiberWorkLoop.js`. Previously, the code checked: ```js (executionContext & RenderContext) !== NoLanes ```` However, `NoLanes` is part of the lane priority system, not the execution context flags. The intent here seems to be to detect whether the current execution context includes `RenderContext`, which should be compared against `NoContext`, not `NoLanes`. This fix replaces `NoLanes` with `NoContext` for semantic correctness and consistency with other checks throughout the codebase. **Fixes [[facebook#33169](https://github.com/facebook/react/issues/33169)](https://github.com/facebook/react/issues/33169)** --- ## How did you test this change? I ran the following commands to validate correctness and ensure nothing was broken: * `yarn lint` * `yarn linc` * `yarn test` * `yarn test --prod` * `yarn flow` * `yarn prettier` All checks passed. Since this is a minor internal logic fix and doesn't change public behavior or APIs, no additional tests are necessary at this time. DiffTrain build for [bfaeb4a](facebook@bfaeb4a)
1 parent 5d63b63 commit 149b6ab

34 files changed

+96
-96
lines changed

compiled/facebook-www/REVISION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
3e9db65fc3341148a5248b3ffc6bc68c0640fd3f
1+
bfaeb4a46175fa0f4edf2eba58349d5029e5e86e
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
3e9db65fc3341148a5248b3ffc6bc68c0640fd3f
1+
bfaeb4a46175fa0f4edf2eba58349d5029e5e86e

compiled/facebook-www/React-dev.classic.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1537,7 +1537,7 @@ __DEV__ &&
15371537
exports.useTransition = function () {
15381538
return resolveDispatcher().useTransition();
15391539
};
1540-
exports.version = "19.2.0-www-classic-3e9db65f-20250522";
1540+
exports.version = "19.2.0-www-classic-bfaeb4a4-20250522";
15411541
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
15421542
"function" ===
15431543
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/React-dev.modern.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1537,7 +1537,7 @@ __DEV__ &&
15371537
exports.useTransition = function () {
15381538
return resolveDispatcher().useTransition();
15391539
};
1540-
exports.version = "19.2.0-www-modern-3e9db65f-20250522";
1540+
exports.version = "19.2.0-www-modern-bfaeb4a4-20250522";
15411541
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
15421542
"function" ===
15431543
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/React-prod.classic.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -635,4 +635,4 @@ exports.useSyncExternalStore = function (
635635
exports.useTransition = function () {
636636
return ReactSharedInternals.H.useTransition();
637637
};
638-
exports.version = "19.2.0-www-classic-3e9db65f-20250522";
638+
exports.version = "19.2.0-www-classic-bfaeb4a4-20250522";

compiled/facebook-www/React-prod.modern.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -635,4 +635,4 @@ exports.useSyncExternalStore = function (
635635
exports.useTransition = function () {
636636
return ReactSharedInternals.H.useTransition();
637637
};
638-
exports.version = "19.2.0-www-modern-3e9db65f-20250522";
638+
exports.version = "19.2.0-www-modern-bfaeb4a4-20250522";

compiled/facebook-www/React-profiling.classic.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -639,7 +639,7 @@ exports.useSyncExternalStore = function (
639639
exports.useTransition = function () {
640640
return ReactSharedInternals.H.useTransition();
641641
};
642-
exports.version = "19.2.0-www-classic-3e9db65f-20250522";
642+
exports.version = "19.2.0-www-classic-bfaeb4a4-20250522";
643643
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
644644
"function" ===
645645
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/React-profiling.modern.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -639,7 +639,7 @@ exports.useSyncExternalStore = function (
639639
exports.useTransition = function () {
640640
return ReactSharedInternals.H.useTransition();
641641
};
642-
exports.version = "19.2.0-www-modern-3e9db65f-20250522";
642+
exports.version = "19.2.0-www-modern-bfaeb4a4-20250522";
643643
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
644644
"function" ===
645645
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/ReactART-dev.classic.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13971,7 +13971,7 @@ __DEV__ &&
1397113971
);
1397213972
markRootUpdated(root, lane);
1397313973
if (
13974-
0 !== (executionContext & RenderContext) &&
13974+
(executionContext & RenderContext) !== NoContext &&
1397513975
root === workInProgressRoot
1397613976
) {
1397713977
if (isRendering)
@@ -19080,10 +19080,10 @@ __DEV__ &&
1908019080
(function () {
1908119081
var internals = {
1908219082
bundleType: 1,
19083-
version: "19.2.0-www-classic-3e9db65f-20250522",
19083+
version: "19.2.0-www-classic-bfaeb4a4-20250522",
1908419084
rendererPackageName: "react-art",
1908519085
currentDispatcherRef: ReactSharedInternals,
19086-
reconcilerVersion: "19.2.0-www-classic-3e9db65f-20250522"
19086+
reconcilerVersion: "19.2.0-www-classic-bfaeb4a4-20250522"
1908719087
};
1908819088
internals.overrideHookState = overrideHookState;
1908919089
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -19117,7 +19117,7 @@ __DEV__ &&
1911719117
exports.Shape = Shape;
1911819118
exports.Surface = Surface;
1911919119
exports.Text = Text;
19120-
exports.version = "19.2.0-www-classic-3e9db65f-20250522";
19120+
exports.version = "19.2.0-www-classic-bfaeb4a4-20250522";
1912119121
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
1912219122
"function" ===
1912319123
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/ReactART-dev.modern.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13789,7 +13789,7 @@ __DEV__ &&
1378913789
);
1379013790
markRootUpdated(root, lane);
1379113791
if (
13792-
0 !== (executionContext & RenderContext) &&
13792+
(executionContext & RenderContext) !== NoContext &&
1379313793
root === workInProgressRoot
1379413794
) {
1379513795
if (isRendering)
@@ -18852,10 +18852,10 @@ __DEV__ &&
1885218852
(function () {
1885318853
var internals = {
1885418854
bundleType: 1,
18855-
version: "19.2.0-www-modern-3e9db65f-20250522",
18855+
version: "19.2.0-www-modern-bfaeb4a4-20250522",
1885618856
rendererPackageName: "react-art",
1885718857
currentDispatcherRef: ReactSharedInternals,
18858-
reconcilerVersion: "19.2.0-www-modern-3e9db65f-20250522"
18858+
reconcilerVersion: "19.2.0-www-modern-bfaeb4a4-20250522"
1885918859
};
1886018860
internals.overrideHookState = overrideHookState;
1886118861
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -18889,7 +18889,7 @@ __DEV__ &&
1888918889
exports.Shape = Shape;
1889018890
exports.Surface = Surface;
1889118891
exports.Text = Text;
18892-
exports.version = "19.2.0-www-modern-3e9db65f-20250522";
18892+
exports.version = "19.2.0-www-modern-bfaeb4a4-20250522";
1889318893
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
1889418894
"function" ===
1889518895
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

0 commit comments

Comments
 (0)