Skip to content

Adjusting gallery modal design #1151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 9, 2021
Merged

Adjusting gallery modal design #1151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e92263
adjusting modal design
sjmiller7 Feb 7, 2021
f676ad1
fixing modal scroll breakpoint & dumb padding
sjmiller7 Feb 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions gallery.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,6 @@
<div id="modal">
<i class="fas fa-times" id="close-modal"></i>
<img id="modal-img" src="https://images.unsplash.com/photo-1567309254107-5babef35b7b4?ixid=MXwxMjA3fDB8MHxwaG90by1wYWdlfHx8fGVufDB8fHw%3D&ixlib=rb-1.2.1&auto=format&fit=crop&w=1351&q=80" alt="image"/>
<!-- Commenting out modal (carousel) controls for later implementation -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

F 🙏

<!-- <div id="modal-controls">
<i class="fas fa-chevron-left"></i>
<i class="fas fa-chevron-right"></i>
</div> -->
</div>
<div id="modal-background"></div>
<nav>
Expand Down
55 changes: 23 additions & 32 deletions sass/gallery.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ p {
text-align: center;
background-color: $off-white;
border-radius: 20px;
padding: 20px;
padding-top: 50px;
top: 10%;
margin: auto;
width: auto;
Expand All @@ -149,42 +149,28 @@ p {
z-index: 3;
display: none;

i {
color: $orange;
font-size: 40px;
}

img {
display: block;
max-width: 100%;
max-height: calc(90vh - 40px); // 40px from the padding of modal (20 top + 20 bottom)
width: auto;
height: auto;
padding: 50px 40px;
border: 8px solid $off-white;
border-top: none;
border-radius: 20px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: maybe use var for border-radius to be consistent

}
}

#close-modal {
color: $orange;
font-size: 40px;
position: absolute;
top: 20px;
right: 40px;
top: 5px;
right: 15px;
z-index: 3;
cursor: pointer;
}

// Commenting out modal (carousel) controls for later implementation
/* #modal-controls {
width: 100%;
height: 100%;
position: absolute;
top: 0;
left: 0;
padding: 20px;
display: flex;
align-items: center;
justify-content: space-between;
} */

@media screen and (max-width: 1800px) {
.image-container {
grid-template-columns: repeat(4, 1fr);
Expand All @@ -201,6 +187,21 @@ p {
.image-container {
grid-template-columns: repeat(2, 1fr);
}

#modal {
width: 90%;
max-height: none;
padding-top: 40px;

img {
width: 100%;
max-height: none;
}
}

#close-modal {
font-size: 30px;
}
}

@media screen and (max-width: 660px) {
Expand Down Expand Up @@ -231,14 +232,4 @@ p {
.image-container {
grid-template-columns: repeat(1, 1fr);
}

#modal {
width: 80%;
max-height: none;

img {
width: 100%;
max-height: none;
}
}
}