Add default runtime parameters in config

Added a way to define default runtime parameters in config.

Fixes: https://github.com/containers/common/issues/715

Default runtime parameters should be defined as shown below:

[engine.runtimes_flags]
runsc = [
  "net-raw",
]

crun = [
  "debug",
]

Signed-off-by: Rosvaldas Atstupėnas <[email protected]>

Author: CowRules

cmd/podman/common/build.go

@@ -24,6 +24,7 @@ import (
 	enchelpers "github.com/containers/ocicrypt/helpers"
 	"github.com/containers/podman/v5/cmd/podman/registry"
 	"github.com/containers/podman/v5/cmd/podman/utils"
+	"github.com/containers/podman/v5/libpod"
 	"github.com/containers/podman/v5/pkg/domain/entities"
 	"github.com/containers/podman/v5/pkg/env"
 	"github.com/openshift/imagebuilder"
@@ -453,6 +454,12 @@ func buildFlagsWrapperToOptions(c *cobra.Command, contextDir string, flags *Buil
 		runtimeFlags = append(runtimeFlags, "--systemd-cgroup")
 	}
 
+	configIndex := libpod.RuntimeNameToConfigIndex(podmanConfig.RuntimePath)
+
+	for _, arg := range podmanConfig.ContainersConfDefaultsRO.Engine.OCIRuntimesFlags[configIndex] {
+		runtimeFlags = append(runtimeFlags, "--"+arg)
+	}
+
 	platforms, err := parse.PlatformsFromOptions(c)
 	if err != nil {
 		return nil, err

docs/source/markdown/options/runtime-flag.md

@@ -6,4 +6,6 @@
 
 Adds global flags for the container runtime. To list the supported flags, please consult the manpages of the selected container runtime.
 
+Default runtime flags can be added in containers.conf.
+
 Note: Do not pass the leading -- to the flag. To pass the runc flag --log-format json to buildah build, the option given is --runtime-flag log-format=json.

docs/source/markdown/podman.1.md

@@ -147,6 +147,8 @@ consult the manpages of the selected container runtime (`runc` is the default
 runtime, the manpage to consult is `runc(8)`.  When the machine is configured
 for cgroup V2, the default runtime is `crun`, the manpage to consult is `crun(8)`.).
 
+Default runtime flags can be added in containers.conf.
+
 Note: Do not pass the leading `--` to the flag. To pass the runc flag `--log-format json`
 to podman build, the option given can be `--runtime-flag log-format=json`.
 

libpod/oci_conmon_common.go

@@ -93,6 +93,12 @@ func newConmonOCIRuntime(name string, paths []string, conmonPath string, runtime
 		supportsKVM[r] = true
 	}
 
+	configIndex := RuntimeNameToConfigIndex(name)
+
+	for _, arg := range runtimeCfg.Engine.OCIRuntimesFlags[configIndex] {
+		runtimeFlags = append(runtimeFlags, "--"+arg)
+	}
+
 	runtime := new(ConmonOCIRuntime)
 	runtime.name = name
 	runtime.conmonPath = conmonPath
@@ -108,10 +114,9 @@ func newConmonOCIRuntime(name string, paths []string, conmonPath string, runtime
 	// TODO: probe OCI runtime for feature and enable automatically if
 	// available.
 
-	base := filepath.Base(name)
-	runtime.supportsJSON = supportsJSON[base]
-	runtime.supportsNoCgroups = supportsNoCgroups[base]
-	runtime.supportsKVM = supportsKVM[base]
+	runtime.supportsJSON = supportsJSON[configIndex]
+	runtime.supportsNoCgroups = supportsNoCgroups[configIndex]
+	runtime.supportsKVM = supportsKVM[configIndex]
 
 	foundPath := false
 	for _, path := range paths {

libpod/util.go

@@ -293,3 +293,7 @@ func isDirectory(path string) bool {
 	}
 	return info.IsDir()
 }
+
+func RuntimeNameToConfigIndex(runtimeName string) string {
+	return filepath.Base(runtimeName)
+}