fix: rolefilters correction with all applications and particular application selected. (#4820)

* merging issue resolved

* all namespace, cluster, kind remove as it is used in key

* removing unnecessary code

Author: Shivam-nagar23

pkg/auth/user/UserCommonService.go

@@ -638,7 +638,9 @@ func (impl UserCommonServiceImpl) BuildRoleFilterKeyForJobs(roleFilterMap map[st
 		roleFilterMap[key].Environment = fmt.Sprintf("%s,%s", roleFilterMap[key].Environment, role.Environment)
 	}
 	entityArr := strings.Split(roleFilterMap[key].EntityName, ",")
-	if !containsArr(entityArr, role.EntityName) {
+	if containsArr(entityArr, bean2.EmptyStringIndicatingAll) {
+		roleFilterMap[key].EntityName = bean2.EmptyStringIndicatingAll
+	} else if !containsArr(entityArr, role.EntityName) {
 		roleFilterMap[key].EntityName = fmt.Sprintf("%s,%s", roleFilterMap[key].EntityName, role.EntityName)
 	}
 	workflowArr := strings.Split(roleFilterMap[key].Workflow, ",")
@@ -657,7 +659,9 @@ func (impl UserCommonServiceImpl) BuildRoleFilterKeyForOtherEntity(roleFilterMap
 		roleFilterMap[key].Environment = fmt.Sprintf("%s,%s", roleFilterMap[key].Environment, role.Environment)
 	}
 	entityArr := strings.Split(roleFilterMap[key].EntityName, ",")
-	if !containsArr(entityArr, role.EntityName) {
+	if containsArr(entityArr, bean2.EmptyStringIndicatingAll) {
+		roleFilterMap[key].EntityName = bean2.EmptyStringIndicatingAll
+	} else if !containsArr(entityArr, role.EntityName) {
 		roleFilterMap[key].EntityName = fmt.Sprintf("%s,%s", roleFilterMap[key].EntityName, role.EntityName)
 	}
 }

pkg/auth/user/bean/bean.go

@@ -33,6 +33,7 @@ const (
 	EMPTY_ROLEFILTER_ENTRY_PLACEHOLDER          = "NONE"
 	RoleNotFoundStatusPrefix                    = "role not fount for any given filter: "
 	EntityJobs                                  = "jobs"
+	EmptyStringIndicatingAll                    = ""
 )
 
 const (